From patchwork Sat Sep 28 18:18:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Wetzel X-Patchwork-Id: 1168884 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=quarantine dis=none) header.from=wetzel-home.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uJkfCLdm"; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=wetzel-home.de header.i=@wetzel-home.de header.b="ZVgbs6eA"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46gcQc5zQJz9sPY for ; Sun, 29 Sep 2019 04:20:08 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8tM6mfZLVrp3PYS43RwnUURBUwK22e3BmN75X4vXuOM=; b=uJkfCLdmbau+cf S0eFHLVqGEZxg/z+UHS6SgsmPAv8yGvhAE7l9IW6AnonkyPbuunQLQ19mTw1GOJiLIeGja7yVR8yI C7V2CoyesI4ouSm+WsbuXSPn++QjZQSkerapSmS7NUvKN6FS3ZmepVoapPNzvqGQZmTg/KJwW5yQI e0fL1H2oMDncFCDx7Uv0Pz/2z1WvHBI8fN+ThJa8iJXuzgMmTmukp/yZX6X2ONi9nMVXulE2JsWFv 1CZ1cPsvxTBahTyBy5KAGUKQaZZKmw7toJY8yrx1rbnOHfc1WzvtGrSKTgtby0VkRAUEhz37+bK9d E7tgfeClscD/XB0wL2NA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEHK9-00021h-AF; Sat, 28 Sep 2019 18:20:05 +0000 Received: from 16.mo1.mail-out.ovh.net ([178.33.104.224]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iEHJL-00010f-V5 for hostap@lists.infradead.org; Sat, 28 Sep 2019 18:19:19 +0000 Received: from player776.ha.ovh.net (unknown [10.109.160.251]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id D4937190E37 for ; Sat, 28 Sep 2019 20:19:11 +0200 (CEST) Received: from awhome.eu (p4FF9144D.dip0.t-ipconnect.de [79.249.20.77]) (Authenticated sender: postmaster@awhome.eu) by player776.ha.ovh.net (Postfix) with ESMTPSA id 835CBA50F559; Sat, 28 Sep 2019 18:19:08 +0000 (UTC) From: Alexander Wetzel DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wetzel-home.de; s=wetzel-home; t=1569694743; bh=jzy9wg5wpbzypP65/RcFXdw2zTByK6H3xMV9v3Rv/IE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ZVgbs6eAjTkruQ5QWlVQnGenNAPImKzZivzv1tsEVxk4D+hY+wsPU4FS+WjdEy102 PD/D6rCxX4fvHzHIlaPoJvoI8n9UQr2WkcWMeS5pxq6PrMBuQOBYziefKQmOaa8MJl z38Q+nS6+qDtF/ZV+bHYXSAQ80K8e0CM+sg+jPAI= To: j@w1.fi Subject: [PATCH v6a 5/7] Fixes for wpa_supplicant: AP Extended Key ID support Date: Sat, 28 Sep 2019 20:18:05 +0200 Message-Id: <20190928181807.180530-6-alexander@wetzel-home.de> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190928181807.180530-1-alexander@wetzel-home.de> References: <20190928181807.180530-1-alexander@wetzel-home.de> MIME-Version: 1.0 X-Ovh-Tracer-Id: 11826171146665270524 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrfeekgdduvddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenuc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190928_111916_146886_A523CD43 X-CRM114-Status: UNSURE ( 8.80 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [178.33.104.224 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [178.33.104.224 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Wetzel , hostap@lists.infradead.org, luca@coelho.fi, johannes@sipsolutions.net Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This is a correction on top of: [PATCH v6 11/17] wpa_supplicant: AP Extended Key ID support Changes: - Only enable Extended Key ID support when it actually can be used - and make this log message level info instead of debug Signed-off-by: Alexander Wetzel --- wpa_supplicant/wpa_supplicant.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c index d3684fa1b..b073eccd3 100644 --- a/wpa_supplicant/wpa_supplicant.c +++ b/wpa_supplicant/wpa_supplicant.c @@ -1244,8 +1244,11 @@ int wpa_supplicant_set_suites(struct wpa_supplicant *wpa_s, const u8 *bss_wpa, *bss_rsn, *bss_osen; if (ssid->mode == WPAS_MODE_INFRA && ssid->wpa_extended_key_id && + ssid->proto & WPA_PROTO_RSN && + ssid->pairwise_cipher & (WPA_CIPHER_CCMP | WPA_CIPHER_CCMP_256 | + WPA_CIPHER_GCMP | WPA_CIPHER_GCMP_256) && wpa_s->drv_flags & WPA_DRIVER_FLAGS_EXTENDED_KEY_ID) { - wpa_msg(wpa_s, MSG_DEBUG, "Enable Extended Key ID support"); + wpa_msg(wpa_s, MSG_INFO, "Enable Extended Key ID support"); wpa_sm_set_param(wpa_s->wpa, WPA_PARAM_EXTENDED_KEY_ID, 1); } else { if (ssid->wpa_extended_key_id)