Patchwork pseries: Update SLOF firmware image

login
register
mail settings
Submitter David Gibson
Date Sept. 29, 2011, 4:19 a.m.
Message ID <1317269995-8275-1-git-send-email-david@gibson.dropbear.id.au>
Download mbox | patch
Permalink /patch/116887/
State New
Headers show

Comments

David Gibson - Sept. 29, 2011, 4:19 a.m.
This patch updates the SLOF submodule and recompiled image.  The new
SLOF versions contains two changes of note:

 * The previous SLOF has a bug in SCSI condition handling that was
   exposed by recent updates to qemu's SCSI emulation.  This update
   fixes the bug.

 * The previous SLOF has a bug in its addressing of SCSI devices,
   which can be exposed under certain conditions.  The new SLOF also
   fixes this.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 pc-bios/slof.bin |  Bin 579072 -> 578888 bytes
 roms/SLOF        |    2 +-
 2 files changed, 1 insertions(+), 1 deletions(-)
Paolo Bonzini - Sept. 29, 2011, 10:31 a.m.
On 09/29/2011 06:19 AM, David Gibson wrote:
> This patch updates the SLOF submodule and recompiled image.  The new
> SLOF versions contains two changes of note:
>
>   * The previous SLOF has a bug in SCSI condition handling that was
>     exposed by recent updates to qemu's SCSI emulation.  This update
>     fixes the bug.
>
>   * The previous SLOF has a bug in its addressing of SCSI devices,
>     which can be exposed under certain conditions.  The new SLOF also
>     fixes this.

Did you really fix this?  The SLOF.bin file here seems to be the same as 
in patch 50/58 from Alex's pull request, and the submodule likewise does 
not contain this fix.  Neither does your SLOF upstream repo, in fact. :)

Also, you're not updating pc-bios/README.

Paolo
David Gibson - Sept. 30, 2011, 5:50 a.m.
On Thu, Sep 29, 2011 at 12:31:39PM +0200, Paolo Bonzini wrote:
> On 09/29/2011 06:19 AM, David Gibson wrote:
> >This patch updates the SLOF submodule and recompiled image.  The new
> >SLOF versions contains two changes of note:
> >
> >  * The previous SLOF has a bug in SCSI condition handling that was
> >    exposed by recent updates to qemu's SCSI emulation.  This update
> >    fixes the bug.
> >
> >  * The previous SLOF has a bug in its addressing of SCSI devices,
> >    which can be exposed under certain conditions.  The new SLOF also
> >    fixes this.
> 
> Did you really fix this?  The SLOF.bin file here seems to be the
> same as in patch 50/58 from Alex's pull request, and the submodule
> likewise does not contain this fix.  Neither does your SLOF upstream
> repo, in fact. :)

Argh, dammit.  Pulled the new code, the forgot to push it to github.
Then pulled down github as submodule and built.  New spin coming.

> Also, you're not updating pc-bios/README.

Ah, yes.  Fixed.

Patch

diff --git a/pc-bios/slof.bin b/pc-bios/slof.bin
index 22c4c7f5c448e3002aefecf3438f5d080586d666..2fe0f84f977c5c9fcffaea9314a808b5bd3c3ef6 100644
GIT binary patch
delta 2659
zcma)+e@q+K9l+l^pTpUM1X3r^CMl25CD7z-Ln$>$T<kIk1PUdDHQg$e<9xPnIp1CG
z&c$9qc3QeD{igv-JN}>vt+sZXrYIZHyiQu<tyzNhqiwcDYX6y<WnIJ4NldLO8nk)u
z{Nsh?pY5b~-_QHL@B99GcQ5^;#-$%No^GeE_0IU(Xh*ZFW=3_<fBR^9#XNtN*_uh&
z12cbq82U0Z;ZJ6%Fcn;#8LrEu%QR~vsxr;eL{+9)yQRV|=4Lk#svyJ=au9M7`Vyf^
zLREw|652$lnotd)&4lhD<RY|%&{jgVgz5<0OXxmA+X!tZw1d$7gz5<)LJfp=5^5y$
z0HH4v+C^wLp(aAjgdQZchtOU^EFm``k4204jH+h?jrhdJKvgdQUtsCP@}F3aV7ZLt
z0G8LW9K!MgEPJrLipQIoqk%-th@hg@4%F&xX+bS*`&wEu*8?tUB9d7PY`1^UH`Z5~
z*&b}bip8#A8p4jnOOIXL0GBh<eNR>m^yhDX07_5h!@e8v2boKUcEb~yPY&&Yql<O@
z7a>e$-XFLK{fl#t--7UXW_sul{CDQvq5NhFY`+YuC$F@+d<$UMmj>y~hfjP1QknkY
zEPmS#KXiY|<Xbyk2XX+6T?Qa=x#DsNOU&uTBZs$bh69UgX!lu%T1dkd@|g=ZI0S!Y
zuGrus@ab$54VeRD%T#&}M*z5dFgBgfA6Nizs<JDAr@$H*&{PvR=Q#zy<7WWsXavxg
z10dN9Q0i0@2%Z7V<nMaV`ECGeDhkf|0N9xL7@$dq?e)p!{fX@906bqc(77Ovr{4ZF
zu?m5~|01>*ha675cq8G<)vsh;1!{l(vmf8$K>8+?K5ywQTg%3mt0=5n`<{CaAZ&Na
zJUs|s-f{2E*V4I?nd-}JTItV!`cZ%W^BP|R$eDo==rwz1>8g|QA&3Wshb<c)qTkr!
zIM~&-4>cVe9L<gj^qY|S;xn^4LVIeS#^nNF<BAf18uJOPF87a9XNGIdvk|(<Q8akr
zQinMlrtdTV9-((Y)nuadgd<w;0lhx++fn);^qqV!N@w4T+JDM!!~vU8o4d{Zuw|2-
z|Bn3_goPN}%*HwUJx+GDxS7RQ6OI(7D@}gR{&k97&F1Fp|Da4^hOSL@rqf{U)%?x1
zU*=c%c?PUq&#$gE<d;?(^1)kwN!O+RwU$WN1J@XKRvycppzcIHKnbwxuTy=LYf1#}
zTMq(e6dR<{0T4I?tCM53H}>ZM2tE&vre6YdYWn>^@D;G+`7QvHXDTk>gAVwn^R9gI
z7>yFs_^U{M&E=a0FxB@*^T~PpE_(woGAGRE=j|ScA0U5o8qE03pU>Mnq5tIVc{?5(
z@Tkb%o@ZFffzz{|J#S~dXPFCI9_Sk!IT9S~>PBA;4vcmqKCWqkY_MX;=|$zW?B^Gl
zy$<uKx0rg@9Rp-2C3Ewox0sjRy1*NXhFZKx&^TRiY62Hxc~0ec(MTd$F;HI*cIrjl
zNBfRAP4OZV&DwIzaeMalUo*#{IsPlAwh4LtmYI7e`iiI@E9|oTBpY@jUUNPa(iGKs
zq_=x8yY&k56S&EXM5GG_%Y{OkpzCkkTw<thD@Ft>WhEpaMHS>Cb%x?<(S0EUWVvz1
zlB_OBVf3ixw3cy6C5`#<Z<v+=UQ%?Su-&OWx^C6E-}$W0>mn=4B91PHSe@r&XQ8$E
z(o>iKdZ8qr$@c!1d66<<<%Vr$(>qMHdFA&^;HemwV8<neKgP=On3WzX&UEpcf;AmF
zT<S*;CrU!d$^qAgLRNRm%`G;kCpa+DU2JZlLyx?}bi!=nU1pG?Y(3`ERVEnlD5~M%
zHAUAw5uRrYzXdK&632Ous!Rx)%D1<%k|@U$o^esWTgRG?KQQi8*~HnU$YC)O*Kl4F
zq7mJPJW(Ykcnn2OddB0T6yhYwqiehs%)^(B5z88!hO6-36%sE9GB+*>rFGqp_hY51
z31KneFFQ}I_g*N*o$$3k)86*KYq}Fb;^au2iwL@($4V=ERu(33BT6$RZm?1O<q4Wz
zUe}YlA;efIC634C2~iH=1$+*Lgk{MxE6<Fm_0g`^=uyt<(j5~VDHacfB~JZsrLNzl
zh$yl3nvlRd#TX~CVM*Z(Gy5lIN2-v0Obu(KMe93c^&h9s7JG!F70e?s_5ZUj*EFsu
zhHhva{{ITqp&0(Xq<u&i_sJ1SaN;9I&*E;0id?*I@m=55)r_3@0!C7(aPy<b@RwzX
llHQD3-K}1Ci+S=I(`0XNQ&ryl{xyc(48Z!|=iFe2?LUQ&v-SW0

delta 2893
zcmb`Ie{3699l+nSeaYD@Ya5&&YnSz9q4_~_{*fld&5zY?m$gaSq-j&A5Yv3VJD;z;
z*yiq>Iy9AUC8a|`+7e5<FtW}?(*^^oPN}d!bjd^%s<E+vHq;52(sihrx=E1+C|W?~
zo$a@D9shu^_3rz5-|zQ*-+SNpeRtPhs?&d3_tY-SAHk%r&1S8uI5rt~-sA0ibRk##
zrN2oHOupL=yV4gIZcPTMDN7jcogBI^trua+N)$zyvJpiQrYNky!@oaOLZFlYO~6jT
zLEsAn?jcY{;9dfo2y7;>g+MuhFA{JPs31^Dpo%~>f%^z-C9sXa{RC<VJV0PO0Yspd
zz=H(p2z-ga4g&QA8VEEJXd>`s0?h<k2rvX(1l$F<mA<@i{r}X?PWkKFDPItj9RT28
zSURx$JC;YW{0Pf~SpF5uK`j4*<s(?Wjoa1qaes2lAyz@HJ5j60>qXx7j`sHS4ZpKN
zltOAO>TirI(kQD5D3p+7zNyRs02q&0UN``#ANzv6&UAI4wxr-Y+ZoUy^v?cj?_3GI
zksj~;8a3RX`{bSUa_>#}a(bb!0e(0AVP7+Rbhf&G4#LON*ALFYp4sU`w;>!$PYm|K
z<@B3_xpD;VUj&=Sf79ypWx$Y6r$Bo7@Ck_0{X<#&v>w^{K+)wp4?4T%0SGPvkX$TX
z<gpAcQebxY$hLAgJR9d5p0j80iUF|l5hG)TgK))IwZgAJJ=<u5bXU-)1Mq=GpT=1M
z!HHb1D+3@#K$_1Apl=?B2LPq?Mi96F=<#ddQZfjT?<TM$Zviy^L1*$z1YGg~aPPR?
z`T`ki%Is5qc)9E_UM1X<kwR+_Xx!D2mf&J;HTCO{lX&`}^hFR)ox7Rr&;9LZw^^XC
zSoF(gpV)o#gR7>GIrj8vfUw^=<9h?}$(o9lAL{c(x43V9(`tY2;~V|Cf0X%Z!Mx!=
z3O&Z_s?B~rF$i(9;AYJx25m1^?8Ymz;pW86x_{sp$k62zb0-#`-?UzK=%vbc=4;-2
zzkdI|eI2OrVId^3QPk#YbG0*GPj-i3`vtUoQf(}UZSE~P4uC_j1qncnfkc~|<ebe+
z4pkX3(bi}$IDC6yw^19mZ8d%=+G=3NxGvgG+2dvi06l)=c*M3J`p;(~wrnOs{hX=1
zYx1VTGP3;B)JX_yj3t9|84pcUG;~c4RU6x<DbeBr*(au{k1V@ubJx}bxux;3ZOQRx
z>XJBno7dUg^*uoytUsPxUcZ=I;ZD<F{YGwW{ngy+T5T?H`#rrn^-tr{52&in#{f!#
z`uES+EzUC%a2*Q*kkStW{{`qA3s&9ioChFq7JNg00@zX$Oa8#K;C1)&0Nnl&pr4+h
zDja9N?(|Inm}>g1v3-WBr!E35%^H0(l-u3~P<N9KCcBKYGt{2aE&x_S`T;|KhC=68
zW+>cBa4XHO%+RG4d$pMz0Gi*;u3ez7RFr=;aPU|U;u4A?L^Vd@9iHsc6}rV<=|Q~%
zM~4Fg`+88pM`IOHFkZbvS32^jF>)emtY4*3d9g3?NQ<F@pZgX1$-|$~Z_H6}$&WV&
z5Cab9Pz07|I5y65k~W5-F%9)Tf;{-&bG&yL86UnvN4)=a)a=nYTA}`jaSIEy0<)uw
z^ve)QcP<t0)N^MaFa5<`*Jz6|{u=G^bUH>=PL&ubDrpQG<r$S@qxe-vKDmV>u;Evx
z`Lj{kwb$r#7UR+zbcb>34ceRC`#bs}2thXWCOv4e*h-A0-_rqO=nu3j#mG`Lkz~YZ
z!m%$F4NGD|5qNY;(jpzm<#MYE=jMnWF{6lKOdAtFDUJ$?D#fDR4R>9G2I3P+;9zoh
zSdxVfx7(di6}K8;6~WENIJd}g48FA~_mQ5!!-slYdlRCH2MSR(BnynpM#Tgx3Tijk
z!ZkOygky@Pu+f%S=mcjz7_7wJaYYDA$!;@rz84b}c7#zAVN+{{--wu>ncwJ-BxFru
zl@u4*(BV{^6ci@^Ey1OW4f(yQW2z>MFyE4;5LV%*kQ6vxQu6b<3tH1LmcRuc<>Uk}
z@Qf&Envm2sf@=}87S--}OqG%(w3tdJ$r$F-ki{Twyh(Rq6L^wOt%V7TiHgd1WQ~(!
z94iam_%Ju-#qO%cb9f$Jz$da{FmuVIL~cW)3i#>>aoJooFRA&HP-9^&EXUY8cVb>#
z&D_Z;L5XvP3Ti3#cC{7yI7B{qTs+au3t<+gduJ<A%CV@(@UcWlP6>>+)wi((E+TLz
zrKs4g2(rMc0=DFj<Fk{Q<%%tln5z9pL*Yh$-sBk09|9VQ@q*le@KNlLk`7#os94N}
zH~8m1E5_Bg=&G#<S0O4CdlPDPwR&7$rcfKkpWmVzjm>Y<_00$&K@RU~i^n-ffp@k(
Prp6O@UDv5U{UrNuYT_#i

diff --git a/roms/SLOF b/roms/SLOF
index d1d6b53..3a3f328 160000
--- a/roms/SLOF
+++ b/roms/SLOF
@@ -1 +1 @@ 
-Subproject commit d1d6b53b713a2b7c2c25685268fa932d28a4b4c0
+Subproject commit 3a3f3280e6d08c21ba83ab15a7558c0747497189