From patchwork Fri Sep 27 14:04:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Sutter X-Patchwork-Id: 1168538 X-Patchwork-Delegate: pablo@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netfilter-devel-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=nwl.cc Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46ftpc0Y9Lz9sDB for ; Sat, 28 Sep 2019 00:04:56 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727355AbfI0OEz (ORCPT ); Fri, 27 Sep 2019 10:04:55 -0400 Received: from orbyte.nwl.cc ([151.80.46.58]:49980 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726926AbfI0OEz (ORCPT ); Fri, 27 Sep 2019 10:04:55 -0400 Received: from localhost ([::1]:34838 helo=tatos) by orbyte.nwl.cc with esmtp (Exim 4.91) (envelope-from ) id 1iDqrd-0006td-Uw; Fri, 27 Sep 2019 16:04:54 +0200 From: Phil Sutter To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org Subject: [iptables PATCH v2 06/12] nft: Eliminate pointless calls to nft_family_ops_lookup() Date: Fri, 27 Sep 2019 16:04:27 +0200 Message-Id: <20190927140433.9504-7-phil@nwl.cc> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190927140433.9504-1-phil@nwl.cc> References: <20190927140433.9504-1-phil@nwl.cc> MIME-Version: 1.0 Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org If nft_handle is available, use its 'ops' field instead of performing a new lookup. For the same reason, there is no need to pass ops pointer to __nft_print_header(). Signed-off-by: Phil Sutter --- iptables/nft.c | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/iptables/nft.c b/iptables/nft.c index 66d318b721551..6977b8946d08f 100644 --- a/iptables/nft.c +++ b/iptables/nft.c @@ -1757,11 +1757,8 @@ static const char *policy_name[NF_ACCEPT+1] = { int nft_chain_save(struct nft_handle *h, struct nftnl_chain_list *list) { struct nftnl_chain_list_iter *iter; - struct nft_family_ops *ops; struct nftnl_chain *c; - ops = nft_family_ops_lookup(h->family); - iter = nftnl_chain_list_iter_create(list); if (iter == NULL) return 0; @@ -1787,8 +1784,8 @@ int nft_chain_save(struct nft_handle *h, struct nftnl_chain_list *list) } } - if (ops->save_chain) - ops->save_chain(c, policy); + if (h->ops->save_chain) + h->ops->save_chain(c, policy); c = nftnl_chain_list_iter_next(iter); } @@ -2593,7 +2590,6 @@ static int nft_rule_count(struct nft_handle *h, struct nftnl_chain *c) } static void __nft_print_header(struct nft_handle *h, - const struct nft_family_ops *ops, struct nftnl_chain *c, unsigned int format) { const char *chain_name = nftnl_chain_get_str(c, NFTNL_CHAIN_NAME); @@ -2609,14 +2605,13 @@ static void __nft_print_header(struct nft_handle *h, if (nftnl_chain_is_set(c, NFTNL_CHAIN_POLICY)) pname = policy_name[nftnl_chain_get_u32(c, NFTNL_CHAIN_POLICY)]; - ops->print_header(format, chain_name, pname, + h->ops->print_header(format, chain_name, pname, &ctrs, basechain, refs - entries, entries); } int nft_rule_list(struct nft_handle *h, const char *chain, const char *table, int rulenum, unsigned int format) { - const struct nft_family_ops *ops; struct nftnl_chain_list *list; struct nftnl_chain_list_iter *iter; struct nftnl_chain *c; @@ -2625,8 +2620,6 @@ int nft_rule_list(struct nft_handle *h, const char *chain, const char *table, nft_xt_builtin_init(h, table); nft_assert_table_compatible(h, table, chain); - ops = nft_family_ops_lookup(h->family); - list = nft_chain_list_get(h, table, chain); if (!list) return 0; @@ -2637,11 +2630,11 @@ int nft_rule_list(struct nft_handle *h, const char *chain, const char *table, return 0; if (!rulenum) { - if (ops->print_table_header) - ops->print_table_header(table); - __nft_print_header(h, ops, c, format); + if (h->ops->print_table_header) + h->ops->print_table_header(table); + __nft_print_header(h, c, format); } - __nft_rule_list(h, c, rulenum, format, ops->print_rule); + __nft_rule_list(h, c, rulenum, format, h->ops->print_rule); return 1; } @@ -2649,16 +2642,16 @@ int nft_rule_list(struct nft_handle *h, const char *chain, const char *table, if (iter == NULL) return 0; - if (ops->print_table_header) - ops->print_table_header(table); + if (h->ops->print_table_header) + h->ops->print_table_header(table); c = nftnl_chain_list_iter_next(iter); while (c != NULL) { if (found) printf("\n"); - __nft_print_header(h, ops, c, format); - __nft_rule_list(h, c, rulenum, format, ops->print_rule); + __nft_print_header(h, c, format); + __nft_rule_list(h, c, rulenum, format, h->ops->print_rule); found = true; c = nftnl_chain_list_iter_next(iter);