Hi Simon, On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg@chromium.org> wrote: > > This condition is not correct since it should not include an SPL_ prefix. > Fix it and also add a note about the driver name in the same file. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > doc/driver-model/of-plat.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/driver-model/of-plat.rst b/doc/driver-model/of-plat.rst > index a38e58e4d29..557957d2a16 100644 > --- a/doc/driver-model/of-plat.rst > +++ b/doc/driver-model/of-plat.rst > @@ -269,7 +269,7 @@ For example: > }; > > U_BOOT_DRIVER(mmc_drv) = { > - .name = "mmc", > + .name = "vendor_mmc", /* matches compatible string */ This single line change only does half of what the commit message says. Where is the other half? > .id = UCLASS_MMC, > .of_match = mmc_ids, > .ofdata_to_platdata = mmc_ofdata_to_platdata, > -- Regards, Bin
Hi Bin, On Fri, 4 Oct 2019 at 03:44, Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Simon, > > On Wed, Sep 25, 2019 at 10:58 PM Simon Glass <sjg@chromium.org> wrote: > > > > This condition is not correct since it should not include an SPL_ prefix. > > Fix it and also add a note about the driver name in the same file. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > doc/driver-model/of-plat.rst | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/doc/driver-model/of-plat.rst b/doc/driver-model/of-plat.rst > > index a38e58e4d29..557957d2a16 100644 > > --- a/doc/driver-model/of-plat.rst > > +++ b/doc/driver-model/of-plat.rst > > @@ -269,7 +269,7 @@ For example: > > }; > > > > U_BOOT_DRIVER(mmc_drv) = { > > - .name = "mmc", > > + .name = "vendor_mmc", /* matches compatible string */ > > This single line change only does half of what the commit message > says. Where is the other half? Yes this part was fixed by someone else's patch and I forgot about it. I'll update the patch. > > > .id = UCLASS_MMC, > > .of_match = mmc_ids, > > .ofdata_to_platdata = mmc_ofdata_to_platdata, > > -- Regards, Simon
diff --git a/doc/driver-model/of-plat.rst b/doc/driver-model/of-plat.rst index a38e58e4d29..557957d2a16 100644 --- a/doc/driver-model/of-plat.rst +++ b/doc/driver-model/of-plat.rst @@ -269,7 +269,7 @@ For example: }; U_BOOT_DRIVER(mmc_drv) = { - .name = "mmc", + .name = "vendor_mmc", /* matches compatible string */ .id = UCLASS_MMC, .of_match = mmc_ids, .ofdata_to_platdata = mmc_ofdata_to_platdata,
This condition is not correct since it should not include an SPL_ prefix. Fix it and also add a note about the driver name in the same file. Signed-off-by: Simon Glass <sjg@chromium.org> --- doc/driver-model/of-plat.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)