[OpenWrt-Devel,3/3] kernel: trelay: log "started" and "stopped"
diff mbox series

Message ID 20190925144713.10632-3-alimjalnasrawy@gmail.com
State Accepted
Delegated to: Hauke Mehrtens
Headers show
Series
  • [OpenWrt-Devel,1/3] kernel: trelay: handle netdevice events correctly
Related show

Commit Message

Ali MJ Al-Nasrawy Sept. 25, 2019, 2:47 p.m. UTC
It is informative especially when using multiple device pairs.

Signed-off-by: Ali MJ Al-Nasrawy <alimjalnasrawy@gmail.com>
---
 package/kernel/trelay/src/trelay.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Patch
diff mbox series

diff --git a/package/kernel/trelay/src/trelay.c b/package/kernel/trelay/src/trelay.c
index 0e3d85bfef..4c1cf706d7 100644
--- a/package/kernel/trelay/src/trelay.c
+++ b/package/kernel/trelay/src/trelay.c
@@ -20,6 +20,10 @@ 
 #include <linux/rtnetlink.h>
 #include <linux/debugfs.h>
 
+#define trelay_log(loglevel, tr, fmt, ...) \
+	printk(loglevel "trelay: %s <-> %s: " fmt "\n", \
+		tr->dev1->name, tr->dev2->name, ##__VA_ARGS__);
+
 static LIST_HEAD(trelay_devs);
 static struct dentry *debugfs_dir;
 
@@ -71,6 +75,8 @@  static int trelay_do_remove(struct trelay *tr)
 	netdev_rx_handler_unregister(tr->dev1);
 	netdev_rx_handler_unregister(tr->dev2);
 
+	trelay_log(KERN_INFO, tr, "stopped");
+
 	kfree(tr);
 
 	return 0;
@@ -183,6 +189,8 @@  static int trelay_do_add(char *name, char *devn1, char *devn2)
 	tr->dev2 = dev2;
 	list_add_tail(&tr->list, &trelay_devs);
 
+	trelay_log(KERN_INFO, tr, "started");
+
 	tr->debugfs = debugfs_create_dir(name, debugfs_dir);
 	debugfs_create_file("remove", S_IWUSR, tr->debugfs, tr, &fops_remove);
 	ret = 0;