| Message ID | 20190924141228.25009-1-philmd@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/timer/pl031: Add warning "do not use as model to implement a RTC" | expand |
diff --git a/hw/timer/pl031.c b/hw/timer/pl031.c index 2b3e261006..da453b5b04 100644 --- a/hw/timer/pl031.c +++ b/hw/timer/pl031.c @@ -1,6 +1,14 @@ /* * ARM AMBA PrimeCell PL031 RTC * + * Note from the maintainer: + * + * Don't use the pl031 code as a good model of how to do an RTC, + * it has some definite flaws. x86 or ppc RTC handling is probably + * a better place to look. + * + * See https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg05399.html + * * Copyright (c) 2007 CodeSourcery * * This file is free software; you can redistribute it and/or modify
Peter said we should "not use the pl031 as a good model of how to do an RTC, it has some definite flaws." Add this information to the PL031 header for other developers. Suggested-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/timer/pl031.c | 8 ++++++++ 1 file changed, 8 insertions(+)