From patchwork Tue Sep 24 09:01:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anson Huang X-Patchwork-Id: 1166459 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 46cwFK5wFbz9s4Y for ; Tue, 24 Sep 2019 19:02:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729625AbfIXJCp (ORCPT ); Tue, 24 Sep 2019 05:02:45 -0400 Received: from inva020.nxp.com ([92.121.34.13]:35774 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726094AbfIXJCp (ORCPT ); Tue, 24 Sep 2019 05:02:45 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 5F3151A00D4; Tue, 24 Sep 2019 11:02:43 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 3048E1A0169; Tue, 24 Sep 2019 11:02:39 +0200 (CEST) Received: from localhost.localdomain (shlinux2.ap.freescale.net [10.192.224.44]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id BB501402ED; Tue, 24 Sep 2019 17:02:33 +0800 (SGT) From: Anson Huang To: thierry.reding@gmail.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Linux-imx@nxp.com Subject: [PATCH] pwm: pwm-imx-tpm: Use 'dev' instead of dereferencing it repeatedly Date: Tue, 24 Sep 2019 17:01:07 +0800 Message-Id: <1569315667-1525-1-git-send-email-Anson.Huang@nxp.com> X-Mailer: git-send-email 2.7.4 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Add helper variable dev = &pdev->dev to simply the code. Signed-off-by: Anson Huang --- drivers/pwm/pwm-imx-tpm.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c index e8385c1..4385801 100644 --- a/drivers/pwm/pwm-imx-tpm.c +++ b/drivers/pwm/pwm-imx-tpm.c @@ -337,11 +337,12 @@ static const struct pwm_ops imx_tpm_pwm_ops = { static int pwm_imx_tpm_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct imx_tpm_pwm_chip *tpm; int ret; u32 val; - tpm = devm_kzalloc(&pdev->dev, sizeof(*tpm), GFP_KERNEL); + tpm = devm_kzalloc(dev, sizeof(*tpm), GFP_KERNEL); if (!tpm) return -ENOMEM; @@ -351,23 +352,23 @@ static int pwm_imx_tpm_probe(struct platform_device *pdev) if (IS_ERR(tpm->base)) return PTR_ERR(tpm->base); - tpm->clk = devm_clk_get(&pdev->dev, NULL); + tpm->clk = devm_clk_get(dev, NULL); if (IS_ERR(tpm->clk)) { ret = PTR_ERR(tpm->clk); if (ret != -EPROBE_DEFER) - dev_err(&pdev->dev, + dev_err(dev, "failed to get PWM clock: %d\n", ret); return ret; } ret = clk_prepare_enable(tpm->clk); if (ret) { - dev_err(&pdev->dev, + dev_err(dev, "failed to prepare or enable clock: %d\n", ret); return ret; } - tpm->chip.dev = &pdev->dev; + tpm->chip.dev = dev; tpm->chip.ops = &imx_tpm_pwm_ops; tpm->chip.base = -1; tpm->chip.of_xlate = of_pwm_xlate_with_flags; @@ -381,7 +382,7 @@ static int pwm_imx_tpm_probe(struct platform_device *pdev) ret = pwmchip_add(&tpm->chip); if (ret) { - dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret); + dev_err(dev, "failed to add PWM chip: %d\n", ret); clk_disable_unprepare(tpm->clk); }