Patchwork event_notifier: move to top-level directory

login
register
mail settings
Submitter Avi Kivity
Date Sept. 27, 2011, 2:26 p.m.
Message ID <1317133583-25212-1-git-send-email-avi@redhat.com>
Download mbox | patch
Permalink /patch/116609/
State New
Headers show

Comments

Avi Kivity - Sept. 27, 2011, 2:26 p.m.
Has no business in hw/.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 hw/event_notifier.c => event_notifier.c |    1 -
 hw/event_notifier.h => event_notifier.h |    0
 2 files changed, 0 insertions(+), 1 deletions(-)
 rename hw/event_notifier.c => event_notifier.c (98%)
 rename hw/event_notifier.h => event_notifier.h (100%)

diff --git a/hw/event_notifier.h b/event_notifier.h
similarity index 100%
rename from hw/event_notifier.h
rename to event_notifier.h
Stefan Hajnoczi - Sept. 27, 2011, 3:17 p.m.
On Tue, Sep 27, 2011 at 3:26 PM, Avi Kivity <avi@redhat.com> wrote:
> Has no business in hw/.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
>  hw/event_notifier.c => event_notifier.c |    1 -
>  hw/event_notifier.h => event_notifier.h |    0
>  2 files changed, 0 insertions(+), 1 deletions(-)
>  rename hw/event_notifier.c => event_notifier.c (98%)
>  rename hw/event_notifier.h => event_notifier.h (100%)

Yay.  Now perhaps we can kill qemu_eventfd(), whose users are
typically poking around with write(2) and read(2) when really they
could use the high-level event_notifier.h API.

Stefan
Jan Kiszka - Sept. 27, 2011, 3:28 p.m.
On 2011-09-27 17:17, Stefan Hajnoczi wrote:
> On Tue, Sep 27, 2011 at 3:26 PM, Avi Kivity <avi@redhat.com> wrote:
>> Has no business in hw/.
>>
>> Signed-off-by: Avi Kivity <avi@redhat.com>
>> ---
>>  hw/event_notifier.c => event_notifier.c |    1 -
>>  hw/event_notifier.h => event_notifier.h |    0
>>  2 files changed, 0 insertions(+), 1 deletions(-)
>>  rename hw/event_notifier.c => event_notifier.c (98%)
>>  rename hw/event_notifier.h => event_notifier.h (100%)
> 
> Yay.  Now perhaps we can kill qemu_eventfd(), whose users are
> typically poking around with write(2) and read(2) when really they
> could use the high-level event_notifier.h API.

EventNotifiers will have to be superseded by something more generic
first. It's not fully covering the use cases of cpus.c and
posix-aio-compat.c.

Jan
Anthony Liguori - Nov. 1, 2011, 10:18 p.m.
On 09/27/2011 09:26 AM, Avi Kivity wrote:
> Has no business in hw/.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/event_notifier.c =>  event_notifier.c |    1 -
>   hw/event_notifier.h =>  event_notifier.h |    0
>   2 files changed, 0 insertions(+), 1 deletions(-)
>   rename hw/event_notifier.c =>  event_notifier.c (98%)
>   rename hw/event_notifier.h =>  event_notifier.h (100%)
>
> diff --git a/hw/event_notifier.c b/event_notifier.c
> similarity index 98%
> rename from hw/event_notifier.c
> rename to event_notifier.c
> index 13f3656..2c73555 100644
> --- a/hw/event_notifier.c
> +++ b/event_notifier.c
> @@ -10,7 +10,6 @@
>    * the COPYING file in the top-level directory.
>    */
>
> -#include "hw.h"
>   #include "event_notifier.h"
>   #ifdef CONFIG_EVENTFD
>   #include<sys/eventfd.h>
> diff --git a/hw/event_notifier.h b/event_notifier.h
> similarity index 100%
> rename from hw/event_notifier.h
> rename to event_notifier.h
Avi Kivity - Nov. 2, 2011, 5:12 p.m.
On 11/02/2011 08:10 PM, Alexander Graf wrote:
> Anthony Liguori wrote:
> > On 09/27/2011 09:26 AM, Avi Kivity wrote:
> >> Has no business in hw/.
> >>
> >> Signed-off-by: Avi Kivity<avi@redhat.com>
> >
> > Applied.  Thanks.
>
> make: *** No rule to make target
> `/home/agraf/release/qemu/hw/event_notifier.c', needed by
> `event_notifier.o'.  Stop.
> make: *** Waiting for unfinished jobs....
>
>

make clean
Avi Kivity - Nov. 2, 2011, 5:13 p.m.
On 11/02/2011 07:12 PM, Avi Kivity wrote:
> On 11/02/2011 08:10 PM, Alexander Graf wrote:
> > Anthony Liguori wrote:
> > > On 09/27/2011 09:26 AM, Avi Kivity wrote:
> > >> Has no business in hw/.
> > >>
> > >> Signed-off-by: Avi Kivity<avi@redhat.com>
> > >
> > > Applied.  Thanks.
> >
> > make: *** No rule to make target
> > `/home/agraf/release/qemu/hw/event_notifier.c', needed by
> > `event_notifier.o'.  Stop.
> > make: *** Waiting for unfinished jobs....
> >
> >
>
> make clean
>

Plus, remove the tachyons from your system.
Avi Kivity - Nov. 2, 2011, 5:22 p.m.
On 11/02/2011 08:23 PM, Alexander Graf wrote:
> >
> > Plus, remove the tachyons from your system.
> >   
>
> Ah, yes. That helped a lot. Damn those tachyons!

They're still there.

(I hate explaining a joke, but your system clock is an hour ahead)
Alexander Graf - Nov. 2, 2011, 5:27 p.m.
Avi Kivity wrote:
> On 11/02/2011 08:23 PM, Alexander Graf wrote:
>   
>>> Plus, remove the tachyons from your system.
>>>   
>>>       
>> Ah, yes. That helped a lot. Damn those tachyons!
>>     
>
> They're still there.
>
> (I hate explaining a joke, but your system clock is an hour ahead)
>   

Yeah, next time just don't explain it :). Makes me feel less dumb.


Alex
Alexander Graf - Nov. 2, 2011, 6:10 p.m.
Anthony Liguori wrote:
> On 09/27/2011 09:26 AM, Avi Kivity wrote:
>> Has no business in hw/.
>>
>> Signed-off-by: Avi Kivity<avi@redhat.com>
>
> Applied.  Thanks.

make: *** No rule to make target
`/home/agraf/release/qemu/hw/event_notifier.c', needed by
`event_notifier.o'.  Stop.
make: *** Waiting for unfinished jobs....


Alex
Alexander Graf - Nov. 2, 2011, 6:23 p.m.
Avi Kivity wrote:
> On 11/02/2011 07:12 PM, Avi Kivity wrote:
>   
>> On 11/02/2011 08:10 PM, Alexander Graf wrote:
>>     
>>> Anthony Liguori wrote:
>>>       
>>>> On 09/27/2011 09:26 AM, Avi Kivity wrote:
>>>>         
>>>>> Has no business in hw/.
>>>>>
>>>>> Signed-off-by: Avi Kivity<avi@redhat.com>
>>>>>           
>>>> Applied.  Thanks.
>>>>         
>>> make: *** No rule to make target
>>> `/home/agraf/release/qemu/hw/event_notifier.c', needed by
>>> `event_notifier.o'.  Stop.
>>> make: *** Waiting for unfinished jobs....
>>>
>>>
>>>       
>> make clean
>>
>>     
>
> Plus, remove the tachyons from your system.
>   

Ah, yes. That helped a lot. Damn those tachyons!


Alex

Patch

diff --git a/hw/event_notifier.c b/event_notifier.c
similarity index 98%
rename from hw/event_notifier.c
rename to event_notifier.c
index 13f3656..2c73555 100644
--- a/hw/event_notifier.c
+++ b/event_notifier.c
@@ -10,7 +10,6 @@ 
  * the COPYING file in the top-level directory.
  */
 
-#include "hw.h"
 #include "event_notifier.h"
 #ifdef CONFIG_EVENTFD
 #include <sys/eventfd.h>