fs/cifs/smb2pdu.c: Make SMB2_notify_init static
diff mbox series

Message ID 1569222378-22693-1-git-send-email-zhengbin13@huawei.com
State New
Headers show
Series
  • fs/cifs/smb2pdu.c: Make SMB2_notify_init static
Related show

Commit Message

zhengbin Sept. 23, 2019, 7:06 a.m. UTC
Fix sparse warnings:

fs/cifs/smb2pdu.c:3200:1: warning: symbol 'SMB2_notify_init' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
---
 fs/cifs/smb2pdu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4

Comments

Steve French Sept. 23, 2019, 7:17 a.m. UTC | #1
merged into cifs-2.6.git for-next

On Mon, Sep 23, 2019 at 1:59 AM zhengbin <zhengbin13@huawei.com> wrote:
>
> Fix sparse warnings:
>
> fs/cifs/smb2pdu.c:3200:1: warning: symbol 'SMB2_notify_init' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  fs/cifs/smb2pdu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index 8bcb278..5e87872 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -3200,7 +3200,7 @@ SMB2_get_srv_num(const unsigned int xid, struct cifs_tcon *tcon,
>   * See MS-SMB2 2.2.35 and 2.2.36
>   */
>
> -int
> +static int
>  SMB2_notify_init(const unsigned int xid, struct smb_rqst *rqst,
>                 struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid,
>                 u32 completion_filter, bool watch_tree)
> --
> 2.7.4
>

Patch
diff mbox series

diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
index 8bcb278..5e87872 100644
--- a/fs/cifs/smb2pdu.c
+++ b/fs/cifs/smb2pdu.c
@@ -3200,7 +3200,7 @@  SMB2_get_srv_num(const unsigned int xid, struct cifs_tcon *tcon,
  * See MS-SMB2 2.2.35 and 2.2.36
  */

-int
+static int
 SMB2_notify_init(const unsigned int xid, struct smb_rqst *rqst,
 		struct cifs_tcon *tcon, u64 persistent_fid, u64 volatile_fid,
 		u32 completion_filter, bool watch_tree)