Message ID | 200812012201.mB1M155p001654@imap1.linux-foundation.org |
---|---|
State | Rejected, archived |
Delegated to: | David Miller |
Headers | show |
Hi Andrew, > This patch causes the BT365 to be reset when the driver is loaded. > Without it, the machine is unable to connect to other devices or to scan > for devices. > > Signed-off-by: Mario Limonciello <mario_limonciello@dell.com> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > Cc: Marcel Holtmann <marcel@holtmann.org> > Cc: Dave Young <hidave.darkstar@gmail.com> > Cc: <stable@kernel.org> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> NAK. I fixed this differently by making the reset quirk default. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Marcel Holtmann wrote: > Hi Andrew, > >> This patch causes the BT365 to be reset when the driver is loaded. >> Without it, the machine is unable to connect to other devices or to scan >> for devices. >> >> Signed-off-by: Mario Limonciello <mario_limonciello@dell.com> >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> >> Cc: Marcel Holtmann <marcel@holtmann.org> >> Cc: Dave Young <hidave.darkstar@gmail.com> >> Cc: <stable@kernel.org> >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > > NAK. I fixed this differently by making the reset quirk default. > > Regards > > Marcel > > Does that mean the devices in blacklist_table that have _only_ BTUSB_RESET should be removed? It would get rid of roughly half of the entries. rtg
Hi Tim, > >> This patch causes the BT365 to be reset when the driver is loaded. > >> Without it, the machine is unable to connect to other devices or to scan > >> for devices. > >> > >> Signed-off-by: Mario Limonciello <mario_limonciello@dell.com> > >> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > >> Cc: Marcel Holtmann <marcel@holtmann.org> > >> Cc: Dave Young <hidave.darkstar@gmail.com> > >> Cc: <stable@kernel.org> > >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > > > > NAK. I fixed this differently by making the reset quirk default. > > Does that mean the devices in blacklist_table that have _only_ > BTUSB_RESET should be removed? It would get rid of roughly half of the > entries. that has already been done. See the pull request I sent to Dave. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -puN drivers/bluetooth/btusb.c~bluetooth-dell-wireless-365-requires-reset-quirk drivers/bluetooth/btusb.c --- a/drivers/bluetooth/btusb.c~bluetooth-dell-wireless-365-requires-reset-quirk +++ a/drivers/bluetooth/btusb.c @@ -125,6 +125,9 @@ static struct usb_device_id blacklist_ta /* Dell laptop with Broadcom chip */ { USB_DEVICE(0x413c, 0x8126), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU }, + /* Dell Wireless 365 */ + { USB_DEVICE(0x413c, 0x8160), .driver_info = BTUSB_RESET }, + /* Dell Wireless 370 */ { USB_DEVICE(0x413c, 0x8156), .driver_info = BTUSB_RESET | BTUSB_WRONG_SCO_MTU },