diff mbox series

[v2,1/2] edk2 build scripts: honor external BaseTools flags with uefi-test-tools

Message ID 20190920083808.21399-2-lersek@redhat.com
State New
Headers show
Series edk2 build scripts: eliminate python 2 dependency | expand

Commit Message

Laszlo Ersek Sept. 20, 2019, 8:38 a.m. UTC
Unify the recipe for "build-edk2-tools" in
"tests/uefi-test-tools/Makefile" with the recipe for "edk2-basetools" in
"roms/Makefile".

Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---

Notes:
    v2:
    - new patch

 tests/uefi-test-tools/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Philippe Mathieu-Daudé Sept. 20, 2019, 8:43 a.m. UTC | #1
On 9/20/19 10:38 AM, Laszlo Ersek wrote:
> Unify the recipe for "build-edk2-tools" in
> "tests/uefi-test-tools/Makefile" with the recipe for "edk2-basetools" in
> "roms/Makefile".
> 
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     v2:
>     - new patch
> 
>  tests/uefi-test-tools/Makefile | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/uefi-test-tools/Makefile b/tests/uefi-test-tools/Makefile
> index 1d78bc14d51a..7e0177d7337e 100644
> --- a/tests/uefi-test-tools/Makefile
> +++ b/tests/uefi-test-tools/Makefile
> @@ -99,7 +99,9 @@ Build/bios-tables-test.%.efi: build-edk2-tools
>  	+./build.sh $(edk2_dir) BiosTablesTest $* $@
>  
>  build-edk2-tools:
> -	$(MAKE) -C $(edk2_dir)/BaseTools
> +	$(MAKE) -C $(edk2_dir)/BaseTools \
> +		EXTRA_OPTFLAGS='$(EDK2_BASETOOLS_OPTFLAGS)' \
> +		EXTRA_LDFLAGS='$(EDK2_BASETOOLS_LDFLAGS)'
>  
>  clean:
>  	rm -rf Build Conf log
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
diff mbox series

Patch

diff --git a/tests/uefi-test-tools/Makefile b/tests/uefi-test-tools/Makefile
index 1d78bc14d51a..7e0177d7337e 100644
--- a/tests/uefi-test-tools/Makefile
+++ b/tests/uefi-test-tools/Makefile
@@ -99,7 +99,9 @@  Build/bios-tables-test.%.efi: build-edk2-tools
 	+./build.sh $(edk2_dir) BiosTablesTest $* $@
 
 build-edk2-tools:
-	$(MAKE) -C $(edk2_dir)/BaseTools
+	$(MAKE) -C $(edk2_dir)/BaseTools \
+		EXTRA_OPTFLAGS='$(EDK2_BASETOOLS_OPTFLAGS)' \
+		EXTRA_LDFLAGS='$(EDK2_BASETOOLS_LDFLAGS)'
 
 clean:
 	rm -rf Build Conf log