[ACT] UBUNTU: SAUCE: ubuntu_ltp_syscalls: skip inotify08 for kernels older than 4.13
diff mbox series

Message ID 20190920081535.4099-1-acelan.kao@canonical.com
State New
Headers show
Series
  • [ACT] UBUNTU: SAUCE: ubuntu_ltp_syscalls: skip inotify08 for kernels older than 4.13
Related show

Commit Message

AceLan Kao Sept. 20, 2019, 8:15 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1775784

The issue tested by LTP testcase inotify08 has been fixed by commit:
   764baba80168 ("ovl: hash non-dir by lower inode for fsnotify")

>From this upstream commit:
"The issue dates back to initial version of overlayfs, but this
patch depends on ovl_inode code that was introduced in kernel v4.13."

Our Xenial 4.4 kernel doesn't have the ovl_inode code, so blacklist this
testcase for kernels older than 4.13.

Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
 ubuntu_ltp_syscalls/testcase-blacklist.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kleber Souza Sept. 20, 2019, 8:50 a.m. UTC | #1
On 20.09.19 10:15, AceLan Kao wrote:
> BugLink: https://bugs.launchpad.net/bugs/1775784
> 
> The issue tested by LTP testcase inotify08 has been fixed by commit:
>    764baba80168 ("ovl: hash non-dir by lower inode for fsnotify")
> 
>>From this upstream commit:
> "The issue dates back to initial version of overlayfs, but this
> patch depends on ovl_inode code that was introduced in kernel v4.13."
> 
> Our Xenial 4.4 kernel doesn't have the ovl_inode code, so blacklist this
> testcase for kernels older than 4.13.
> 
> Signed-off-by: AceLan Kao <acelan.kao@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  ubuntu_ltp_syscalls/testcase-blacklist.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/ubuntu_ltp_syscalls/testcase-blacklist.yaml b/ubuntu_ltp_syscalls/testcase-blacklist.yaml
> index f84d7db..b4a3d21 100644
> --- a/ubuntu_ltp_syscalls/testcase-blacklist.yaml
> +++ b/ubuntu_ltp_syscalls/testcase-blacklist.yaml
> @@ -18,6 +18,8 @@ kernel:
>      4.13.0:
>          'inotify07 inotify07':
>              comment: 'the fix depends on ovl_inode code that was introduced in kernel v4.13 (LP: #1774387)'
> +        'inotify08 inotify08':
> +            comment: 'the fix depends on ovl_inode code that was introduced in kernel v4.13 (LP: #1775784)'
>      5.2.0:
>          'copy_file_range02 copy_file_range02':
>              comment: 'copy_file_range02 will not get fixed < 5.2.0 (https://lwn.net/Articles/774114)'
>
Po-Hsu Lin Sept. 20, 2019, 9:15 a.m. UTC | #2
Applied and pushed.

Thanks
Sam

Patch
diff mbox series

diff --git a/ubuntu_ltp_syscalls/testcase-blacklist.yaml b/ubuntu_ltp_syscalls/testcase-blacklist.yaml
index f84d7db..b4a3d21 100644
--- a/ubuntu_ltp_syscalls/testcase-blacklist.yaml
+++ b/ubuntu_ltp_syscalls/testcase-blacklist.yaml
@@ -18,6 +18,8 @@  kernel:
     4.13.0:
         'inotify07 inotify07':
             comment: 'the fix depends on ovl_inode code that was introduced in kernel v4.13 (LP: #1774387)'
+        'inotify08 inotify08':
+            comment: 'the fix depends on ovl_inode code that was introduced in kernel v4.13 (LP: #1775784)'
     5.2.0:
         'copy_file_range02 copy_file_range02':
             comment: 'copy_file_range02 will not get fixed < 5.2.0 (https://lwn.net/Articles/774114)'