Fix PR91767
diff mbox series

Message ID nycvar.YFH.7.76.1909200838400.5566@zhemvz.fhfr.qr
State New
Headers show
  • Fix PR91767
Related show

Commit Message

Richard Biener Sept. 20, 2019, 6:42 a.m. UTC
regno_reg_rtx[] is a smoking gun with C++ and references.

Committed as obvious.


2019-09-20  Richard Biener  <>

	PR target/91767
	* config/i386/i386-features.c (general_scalar_chain::convert_registers):
	Ensure there's a sequence point between allocating the new register
	and passing a reference to a reg via regno_reg_rtx.

diff mbox series

Index: gcc/config/i386/i386-features.c
--- gcc/config/i386/i386-features.c	(revision 275988)
+++ gcc/config/i386/i386-features.c	(working copy)
@@ -1210,7 +1210,10 @@  general_scalar_chain::convert_registers
   bitmap_iterator bi;
   unsigned id;
   EXECUTE_IF_SET_IN_BITMAP (defs_conv, 0, id, bi)
-    defs_map.put (regno_reg_rtx[id], gen_reg_rtx (smode));
+    {
+      rtx chain_reg = gen_reg_rtx (smode);
+      defs_map.put (regno_reg_rtx[id], chain_reg);
+    }
   EXECUTE_IF_SET_IN_BITMAP (insns_conv, 0, id, bi)
     for (df_ref ref = DF_INSN_UID_DEFS (id); ref; ref = DF_REF_NEXT_LOC (ref))
       if (bitmap_bit_p (defs_conv, DF_REF_REGNO (ref)))