Message ID | 20190919171236.111294-1-edumazet@google.com |
---|---|
State | Accepted |
Delegated to: | David Miller |
Headers | show |
Series | [net] ipv6: fix a typo in fib6_rule_lookup() | expand |
On Thu, 19 Sep 2019 10:12:36 -0700, Eric Dumazet wrote: > Yi Ren reported an issue discovered by syzkaller, and bisected > to the cited commit. > > Many thanks to Yi, this trivial patch does not reflect the patient > work that has been done. > > Fixes: d64a1f574a29 ("ipv6: honor RT6_LOOKUP_F_DST_NOREF in rule lookup logic") > Signed-off-by: Eric Dumazet <edumazet@google.com> > Acked-by: Wei Wang <weiwan@google.com> > Bisected-and-Reported-by: Yi Ren <c4tren@gmail.com> Apparently: WARNING: 'Bisected-and-reported-by:' is the preferred signature form #15: Bisected-and-Reported-by: Yi Ren <c4tren@gmail.com> total: 0 errors, 1 warnings, 0 checks, 8 lines checked So I lower-cased that R, hope that's okay. Applied, queued, thank you!
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index 87f47bc55c5e3f5e5f522d153fad69d6d82e6332..6e2af411cd9cc4131c5d457e6d48f177fc6d4428 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -318,7 +318,7 @@ struct dst_entry *fib6_rule_lookup(struct net *net, struct flowi6 *fl6, if (rt->dst.error == -EAGAIN) { ip6_rt_put_flags(rt, flags); rt = net->ipv6.ip6_null_entry; - if (!(flags | RT6_LOOKUP_F_DST_NOREF)) + if (!(flags & RT6_LOOKUP_F_DST_NOREF)) dst_hold(&rt->dst); }