Patchwork Lucid SRU: UBUNTU: SAUCE: rtl8192se spams log

login
register
mail settings
Submitter Tim Gardner
Date Sept. 26, 2011, 8:02 p.m.
Message ID <20110926200238.C38CCF8AFF@lochsa.rtg.net>
Download mbox | patch
Permalink /patch/116474/
State New
Headers show

Comments

Tim Gardner - Sept. 26, 2011, 8:02 p.m.
From 569610b2cf73a5981ea4ccf6d93a090141403d6b Mon Sep 17 00:00:00 2001
From: Tim Gardner <tim.gardner@canonical.com>
Date: Mon, 26 Sep 2011 13:52:05 -0600
Subject: [PATCH] UBUNTU: SAUCE: rtl8192se spams log

BugLink: http://bugs.launchpad.net/bugs/859702

This appears to be an entirely useless and repetetive log message.

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 ubuntu/rtl8192se/rtl_dm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Seth Forshee - Sept. 26, 2011, 8:44 p.m.
On Mon, Sep 26, 2011 at 02:02:38PM -0600, Tim Gardner wrote:
> From 569610b2cf73a5981ea4ccf6d93a090141403d6b Mon Sep 17 00:00:00 2001
> From: Tim Gardner <tim.gardner@canonical.com>
> Date: Mon, 26 Sep 2011 13:52:05 -0600
> Subject: [PATCH] UBUNTU: SAUCE: rtl8192se spams log
> 
> BugLink: http://bugs.launchpad.net/bugs/859702
> 
> This appears to be an entirely useless and repetetive log message.
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> ---
>  ubuntu/rtl8192se/rtl_dm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ubuntu/rtl8192se/rtl_dm.c b/ubuntu/rtl8192se/rtl_dm.c
> index 7d42604..220843d 100755
> --- a/ubuntu/rtl8192se/rtl_dm.c
> +++ b/ubuntu/rtl8192se/rtl_dm.c
> @@ -3804,7 +3804,7 @@ u8 RfOnOffDetect(struct net_device *dev)
>  	if(priv->pwrdown)
>  	{
>  		u1Tmp = read_nic_byte(dev, 0x06);
> -		printk("pwrdown, 0x6(BIT6)=%02x\n", u1Tmp);
> +		dev_dbg(&dev->dev, "pwrdown, 0x6(BIT6)=%02x\n", u1Tmp);
>  		retval = (u1Tmp & BIT6) ? eRfOn: eRfOff;
>  	}
>  	else

Trivial change, doesn't look likely to cause any regressions.

Acked-by: Seth Forshee <seth.forshee@canonical.com>
Leann Ogasawara - Sept. 26, 2011, 8:51 p.m.
On Mon, 2011-09-26 at 14:02 -0600, Tim Gardner wrote:
> From 569610b2cf73a5981ea4ccf6d93a090141403d6b Mon Sep 17 00:00:00 2001
> From: Tim Gardner <tim.gardner@canonical.com>
> Date: Mon, 26 Sep 2011 13:52:05 -0600
> Subject: [PATCH] UBUNTU: SAUCE: rtl8192se spams log
> 
> BugLink: http://bugs.launchpad.net/bugs/859702
> 
> This appears to be an entirely useless and repetetive log message.
> 
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>

Low risk of regression and reduces spam to log.

Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com>

> ---
>  ubuntu/rtl8192se/rtl_dm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/ubuntu/rtl8192se/rtl_dm.c b/ubuntu/rtl8192se/rtl_dm.c
> index 7d42604..220843d 100755
> --- a/ubuntu/rtl8192se/rtl_dm.c
> +++ b/ubuntu/rtl8192se/rtl_dm.c
> @@ -3804,7 +3804,7 @@ u8 RfOnOffDetect(struct net_device *dev)
>  	if(priv->pwrdown)
>  	{
>  		u1Tmp = read_nic_byte(dev, 0x06);
> -		printk("pwrdown, 0x6(BIT6)=%02x\n", u1Tmp);
> +		dev_dbg(&dev->dev, "pwrdown, 0x6(BIT6)=%02x\n", u1Tmp);
>  		retval = (u1Tmp & BIT6) ? eRfOn: eRfOff;
>  	}
>  	else
> -- 
> 1.7.0.4
> 
>
Stefan Bader - Sept. 27, 2011, 8:34 a.m.
Applient to Lucid master-next after reverting the dos2unix conversion
Thunderbird seems to be silently doing back to the dos format.

Failed once because one of the object dirs had no write permision for the group.
Anyone pushing there, make sure you got a umask 0002 set on kernel.ubuntu.com.

-Stefan

Patch

diff --git a/ubuntu/rtl8192se/rtl_dm.c b/ubuntu/rtl8192se/rtl_dm.c
index 7d42604..220843d 100755
--- a/ubuntu/rtl8192se/rtl_dm.c
+++ b/ubuntu/rtl8192se/rtl_dm.c
@@ -3804,7 +3804,7 @@  u8 RfOnOffDetect(struct net_device *dev)
 	if(priv->pwrdown)
 	{
 		u1Tmp = read_nic_byte(dev, 0x06);
-		printk("pwrdown, 0x6(BIT6)=%02x\n", u1Tmp);
+		dev_dbg(&dev->dev, "pwrdown, 0x6(BIT6)=%02x\n", u1Tmp);
 		retval = (u1Tmp & BIT6) ? eRfOn: eRfOff;
 	}
 	else