diff mbox series

[qemu-web] Gemfile: use a fixed version of sassc

Message ID 20190919130128.28770-1-pbonzini@redhat.com
State New
Headers show
Series [qemu-web] Gemfile: use a fixed version of sassc | expand

Commit Message

Paolo Bonzini Sept. 19, 2019, 1:01 p.m. UTC
Jekyll failed to run with sassc 2.2.0 due to a LoadError, so the
Gemfile was requiring an earlier version (2.1.0 in practice).
Since the bug has been fixed, remove the workaround and instead
require a fixed version.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 Gemfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Huth Sept. 19, 2019, 3:38 p.m. UTC | #1
On 19/09/2019 15.01, Paolo Bonzini wrote:
> Jekyll failed to run with sassc 2.2.0 due to a LoadError, so the
> Gemfile was requiring an earlier version (2.1.0 in practice).
> Since the bug has been fixed, remove the workaround and instead
> require a fixed version.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  Gemfile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Gemfile b/Gemfile
> index b76a4fd..2117bba 100644
> --- a/Gemfile
> +++ b/Gemfile
> @@ -24,4 +24,4 @@ group :jekyll_plugins do
>  end
>  
>  # for https://github.com/sass/sassc-ruby/issues/146
> -gem "sassc", "< 2.2.0"
> +gem "sassc", ">= 2.2.1"

I think you could simply drop the two lines now, "bundle install" will
pick up the newer version anyway.

Both ways work for me, so for any of the two solutions:

Tested-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/Gemfile b/Gemfile
index b76a4fd..2117bba 100644
--- a/Gemfile
+++ b/Gemfile
@@ -24,4 +24,4 @@  group :jekyll_plugins do
 end
 
 # for https://github.com/sass/sassc-ruby/issues/146
-gem "sassc", "< 2.2.0"
+gem "sassc", ">= 2.2.1"