From patchwork Thu Sep 19 10:09:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1164512 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46Ysyn4T2Nz9s4Y; Thu, 19 Sep 2019 20:09:36 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1iAtNV-0002OC-SO; Thu, 19 Sep 2019 10:09:33 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iAtNU-0002O4-TN for fwts-devel@lists.ubuntu.com; Thu, 19 Sep 2019 10:09:32 +0000 Received: from 2.general.alexhung.uk.vpn ([10.172.193.255] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iAtNU-0005XD-Im; Thu, 19 Sep 2019 10:09:32 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH][V2] acpi/boot: skip ACPI BOOT test on UEFI systems. Date: Thu, 19 Sep 2019 12:09:30 +0200 Message-Id: <20190919100930.11920-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" BOOT table is for PC-AT BIOS, and UEFI systems shall use SimpleBootFlag variable is stored in NVRAM. Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Ivan Hu --- src/acpi/boot/boot.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/acpi/boot/boot.c b/src/acpi/boot/boot.c index 081b8b37..c1ea810c 100644 --- a/src/acpi/boot/boot.c +++ b/src/acpi/boot/boot.c @@ -35,6 +35,10 @@ static int boot_init(fwts_framework *fw) fwts_log_error(fw, "Cannot read ACPI tables."); return FWTS_ERROR; } + if (fwts_firmware_detect() == FWTS_FIRMWARE_UEFI) { + fwts_log_error(fw, "ACPI BOOT table is depreciated on UEFI firmware, skipping test"); + return FWTS_SKIP; + } if (table == NULL || (table && table->length == 0)) { fwts_log_error(fw, "ACPI BOOT table does not exist, skipping test"); return FWTS_SKIP;