Patchwork softfloat: Reinstate accidentally disabled target-specific NaN handling

login
register
mail settings
Submitter Peter Maydell
Date Sept. 26, 2011, 3:56 p.m.
Message ID <1317052615-21607-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/116443/
State New
Headers show

Comments

Peter Maydell - Sept. 26, 2011, 3:56 p.m.
Include config.h in softfloat.c, so that the target specific ifdefs in
softfloat-specialize.h are evaluated correctly. This was accidentally
broken in commit 789ec7ce2 when config-target.h was removed from
softfloat.h, and means that most targets will have been returning the
wrong results for calculations involving NaNs.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 fpu/softfloat.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Blue Swirl - Oct. 1, 2011, 12:04 p.m.
Thanks, applied.

On Mon, Sep 26, 2011 at 3:56 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> Include config.h in softfloat.c, so that the target specific ifdefs in
> softfloat-specialize.h are evaluated correctly. This was accidentally
> broken in commit 789ec7ce2 when config-target.h was removed from
> softfloat.h, and means that most targets will have been returning the
> wrong results for calculations involving NaNs.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  fpu/softfloat.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 2b20085..3aafa81 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -35,6 +35,11 @@ these four paragraphs for those parts of this code that are retained.
>
>  =============================================================================*/
>
> +/* softfloat (and in particular the code in softfloat-specialize.h) is
> + * target-dependent and needs the TARGET_* macros.
> + */
> +#include "config.h"
> +
>  #include "softfloat.h"
>
>  /*----------------------------------------------------------------------------
> --
> 1.7.1
>
>
>

Patch

diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 2b20085..3aafa81 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -35,6 +35,11 @@  these four paragraphs for those parts of this code that are retained.
 
 =============================================================================*/
 
+/* softfloat (and in particular the code in softfloat-specialize.h) is
+ * target-dependent and needs the TARGET_* macros.
+ */
+#include "config.h"
+
 #include "softfloat.h"
 
 /*----------------------------------------------------------------------------