From patchwork Mon Sep 26 07:46:37 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 116376 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 26B7CB6F72 for ; Mon, 26 Sep 2011 17:46:53 +1000 (EST) Received: from localhost ([::1]:60133 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R85tq-0003zL-ES for incoming@patchwork.ozlabs.org; Mon, 26 Sep 2011 03:46:50 -0400 Received: from eggs.gnu.org ([140.186.70.92]:52722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R85tj-0003zA-RY for qemu-devel@nongnu.org; Mon, 26 Sep 2011 03:46:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R85ti-0002Mj-N4 for qemu-devel@nongnu.org; Mon, 26 Sep 2011 03:46:43 -0400 Received: from thoth.sbs.de ([192.35.17.2]:34606) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R85ti-0002MS-Bj for qemu-devel@nongnu.org; Mon, 26 Sep 2011 03:46:42 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by thoth.sbs.de (8.13.6/8.13.6) with ESMTP id p8Q7kdqn000384; Mon, 26 Sep 2011 09:46:39 +0200 Received: from mchn199C.mchp.siemens.de ([139.22.34.50]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id p8Q7kbFA014116; Mon, 26 Sep 2011 09:46:37 +0200 Message-ID: <4E802DDD.8090100@siemens.com> Date: Mon, 26 Sep 2011 09:46:37 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Anthony Liguori X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.2 Cc: Blue Swirl , Peter Maydell , qemu-devel Subject: [Qemu-devel] [PATCH] tcg: Remove stack protection from helper functions X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This increases the overhead of frequently executed helpers. Signed-off-by: Jan Kiszka --- Maybe this should be applied to more hot-path functions, but I haven't done any thorough analysis yet. Makefile.target | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index 88d2f1f..1cc758d 100644 --- a/Makefile.target +++ b/Makefile.target @@ -91,7 +91,7 @@ tcg/tcg.o: cpu.h # HELPER_CFLAGS is used for all the code compiled with static register # variables -op_helper.o user-exec.o: QEMU_CFLAGS += $(HELPER_CFLAGS) +op_helper.o user-exec.o: QEMU_CFLAGS := $(subst -fstack-protector-all,,$(QEMU_CFLAGS)) $(HELPER_CFLAGS) # Note: this is a workaround. The real fix is to avoid compiling # cpu_signal_handler() in user-exec.c.