diff mbox series

[U-Boot,3/3] tools: dumpimage: Fall-though to print usage for help command

Message ID 20190917210935.3666-3-afd@ti.com
State Accepted
Commit e3cd06be93e7e669a93d5786d131f421f346a925
Delegated to: Tom Rini
Headers show
Series [U-Boot,1/3] tools: dumpimage: Provide more feedback on internal errors | expand

Commit Message

Andrew Davis Sept. 17, 2019, 9:09 p.m. UTC 
This has the same result but some compilers will warn about this
fall-through if there are statements as part of the label block.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 tools/dumpimage.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Lokesh Vutla Nov. 14, 2019, 11:46 a.m. UTC | #1 
On 18/09/19 2:39 AM, Andrew F. Davis wrote:
> This has the same result but some compilers will warn about this
> fall-through if there are statements as part of the label block.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh
Tom Rini Jan. 8, 2020, 8:10 p.m. UTC | #2 
On Tue, Sep 17, 2019 at 05:09:35PM -0400, Andrew F. Davis wrote:

> This has the same result but some compilers will warn about this
> fall-through if there are statements as part of the label block.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/tools/dumpimage.c b/tools/dumpimage.c
index d5f893daf1..e5481435a7 100644
--- a/tools/dumpimage.c
+++ b/tools/dumpimage.c
@@ -104,7 +104,6 @@  int main(int argc, char **argv)
 			printf("dumpimage version %s\n", PLAIN_VERSION);
 			exit(EXIT_SUCCESS);
 		case 'h':
-			usage();
 		default:
 			usage();
 			break;