[2/3] dt-bindings: Add Logic PD Type 28 display panel
diff mbox series

Message ID 20190917161214.2913-2-aford173@gmail.com
State Superseded
Headers show
Series
  • Untitled series #131106
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Adam Ford Sept. 17, 2019, 4:12 p.m. UTC
This patch adds documentation of device tree bindings for the WVGA panel
Logic PD Type 28 display.

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Sam Ravnborg Sept. 21, 2019, 7:07 p.m. UTC | #1
Hi Adam.

Good with even more panels.
But for new bindings please use meta-schema (.yaml) format.
This is what we use for new bindings as it allows better
validation.

	Sam

On Tue, Sep 17, 2019 at 11:12:12AM -0500, Adam Ford wrote:
> This patch adds documentation of device tree bindings for the WVGA panel
> Logic PD Type 28 display.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt
> new file mode 100644
> index 000000000000..829fc5210e06
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt
> @@ -0,0 +1,26 @@
> +Logic PD Type 28 4.3" WQVGA TFT LCD panel
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.
> +
> +Required properties:
> +- compatible: should be "logicpd,type28"
> +
> +Optional properties:
> +- power-supply: regulator to provide the supply voltage
> +- enable-gpios: GPIO pin to enable or disable the panel
> +- backlight: phandle of the backlight device attached to the panel
Is it correct that these are optional for the descrivbed panel?

> +
> +Optional nodes:
> +- Video port for RGB input.
> +
> +Example:
> +	lcd0: display {
> +		compatible = "logicpd,type28";
> +		enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;
> +		port {
> +			lcd_in: endpoint {
> +				remote-endpoint = <&dpi_out>;
> +			};
> +		};
> +	};
> -- 
> 2.17.1
Adam Ford Sept. 23, 2019, 1:31 p.m. UTC | #2
On Sat, Sep 21, 2019 at 2:07 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Adam.
>
> Good with even more panels.
> But for new bindings please use meta-schema (.yaml) format.
> This is what we use for new bindings as it allows better
> validation.

I don't know that syntax, but I'll try to piece together a few
different examples to come up with something.  I should have a V2
today.

adam
>
>         Sam
>
> On Tue, Sep 17, 2019 at 11:12:12AM -0500, Adam Ford wrote:
> > This patch adds documentation of device tree bindings for the WVGA panel
> > Logic PD Type 28 display.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt
> > new file mode 100644
> > index 000000000000..829fc5210e06
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt
> > @@ -0,0 +1,26 @@
> > +Logic PD Type 28 4.3" WQVGA TFT LCD panel
> > +
> > +This binding is compatible with the simple-panel binding, which is specified
> > +in simple-panel.txt in this directory.
> > +
> > +Required properties:
> > +- compatible: should be "logicpd,type28"
> > +
> > +Optional properties:
> > +- power-supply: regulator to provide the supply voltage
> > +- enable-gpios: GPIO pin to enable or disable the panel
> > +- backlight: phandle of the backlight device attached to the panel
> Is it correct that these are optional for the descrivbed panel?
>
> > +
> > +Optional nodes:
> > +- Video port for RGB input.
> > +
> > +Example:
> > +     lcd0: display {
> > +             compatible = "logicpd,type28";
> > +             enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;
> > +             port {
> > +                     lcd_in: endpoint {
> > +                             remote-endpoint = <&dpi_out>;
> > +                     };
> > +             };
> > +     };
> > --
> > 2.17.1

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt
new file mode 100644
index 000000000000..829fc5210e06
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/logicpd,type28.txt
@@ -0,0 +1,26 @@ 
+Logic PD Type 28 4.3" WQVGA TFT LCD panel
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
+
+Required properties:
+- compatible: should be "logicpd,type28"
+
+Optional properties:
+- power-supply: regulator to provide the supply voltage
+- enable-gpios: GPIO pin to enable or disable the panel
+- backlight: phandle of the backlight device attached to the panel
+
+Optional nodes:
+- Video port for RGB input.
+
+Example:
+	lcd0: display {
+		compatible = "logicpd,type28";
+		enable-gpios = <&gpio5 27 GPIO_ACTIVE_HIGH>;
+		port {
+			lcd_in: endpoint {
+				remote-endpoint = <&dpi_out>;
+			};
+		};
+	};