diff mbox series

[1/1] package/openvmtools: source default file

Message ID 1568712701-114422-1-git-send-email-simon.rowe@citrix.com
State Accepted
Headers show
Series [1/1] package/openvmtools: source default file | expand

Commit Message

Simon Rowe Sept. 17, 2019, 9:31 a.m. UTC
In the SYSV init script allow /etc/default/vmtoolsd to override $ARGS
(if it present)

Signed-off-by: Simon Rowe <simon.rowe@citrix.com>
---
 package/openvmtools/S10vmtoolsd | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni Sept. 17, 2019, 7:40 p.m. UTC | #1
Hello Simon,

On Tue, 17 Sep 2019 10:31:41 +0100
Simon Rowe <simon.rowe@citrix.com> wrote:

> In the SYSV init script allow /etc/default/vmtoolsd to override $ARGS
> (if it present)
> 
> Signed-off-by: Simon Rowe <simon.rowe@citrix.com>
> ---
>  package/openvmtools/S10vmtoolsd | 2 ++
>  1 file changed, 2 insertions(+)

Applied to master, thanks. However, it would be nice to convert this
init script to our new "template", which can be seen in
package/busybox/S01syslogd.

Thanks,

Thomas
Simon Rowe Sept. 18, 2019, 8:11 a.m. UTC | #2
On 17/09/2019 20:40, Thomas Petazzoni wrote:

> Applied to master, thanks. However, it would be nice to convert this
> init script to our new "template", which can be seen in
> package/busybox/S01syslogd.

Sure, I create a patch for that,

Simon
Peter Korsgaard Sept. 26, 2019, 8:50 a.m. UTC | #3
>>>>> "Simon" == Simon Rowe <simon.rowe@citrix.com> writes:

 > In the SYSV init script allow /etc/default/vmtoolsd to override $ARGS
 > (if it present)

 > Signed-off-by: Simon Rowe <simon.rowe@citrix.com>

Committed to 2019.02.x, 2019.05.x and 2019.08.x, thanks.
diff mbox series

Patch

diff --git a/package/openvmtools/S10vmtoolsd b/package/openvmtools/S10vmtoolsd
index 6afb9ca..5fdb568 100644
--- a/package/openvmtools/S10vmtoolsd
+++ b/package/openvmtools/S10vmtoolsd
@@ -7,6 +7,8 @@  EXEC="/usr/bin/vmtoolsd"
 ARGS="-b"
 PID="/var/run/vmtoolsd.pid"
 
+[ -r /etc/default/vmtoolsd ] && . /etc/default/vmtoolsd
+
 case "$1" in
   start)
     printf "Starting vmtoolsd: "