devicetree: property-units: Add kohms unit
diff mbox series

Message ID 20190917075850.40039-1-biwen.li@nxp.com
State Changes Requested
Headers show
Series
  • devicetree: property-units: Add kohms unit
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Biwen Li Sept. 17, 2019, 7:58 a.m. UTC
The patch adds kohms unit

Signed-off-by: Biwen Li <biwen.li@nxp.com>
---
 Documentation/devicetree/bindings/property-units.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven Sept. 17, 2019, 8:19 a.m. UTC | #1
Hi Biwen,

On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@nxp.com> wrote:
> The patch adds kohms unit
>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/property-units.txt
> +++ b/Documentation/devicetree/bindings/property-units.txt
> @@ -27,6 +27,7 @@ Electricity
>  -microamp      : microampere
>  -microamp-hours : microampere hour
>  -ohms          : ohm
> +-kohms         : kiloohm
>  -micro-ohms    : microohm
>  -microwatt-hours: microwatt hour
>  -microvolt     : microvolt

What's your rationale for adding "kohms"?
Do you need to specify resistance values that do not fit in 32-bit, and
thus cannot be specified using "ohms"?

Gr{oetje,eeting}s,

                        Geert
Biwen Li Sept. 17, 2019, 8:25 a.m. UTC | #2
> 
> Caution: EXT Email
> 
> Hi Biwen,
> 
> On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@nxp.com> wrote:
> > The patch adds kohms unit
> >
> > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/property-units.txt
> > +++ b/Documentation/devicetree/bindings/property-units.txt
> > @@ -27,6 +27,7 @@ Electricity
> >  -microamp      : microampere
> >  -microamp-hours : microampere hour
> >  -ohms          : ohm
> > +-kohms         : kiloohm
> >  -micro-ohms    : microohm
> >  -microwatt-hours: microwatt hour
> >  -microvolt     : microvolt
> 
> What's your rationale for adding "kohms"?
> Do you need to specify resistance values that do not fit in 32-bit, and thus
32-bit is enough, I have three values, 60 kohm, 100 kohm and 500 kohm
> cannot be specified using "ohms"?
If replace with ohms, the value is as follows:
60000 ohm, 100000 ohm, 500000 ohm.
It's so long for everyone.

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But when
> I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
Rob Herring Sept. 30, 2019, 10:48 p.m. UTC | #3
On Tue, Sep 17, 2019 at 08:25:55AM +0000, Biwen Li wrote:
> > 
> > Caution: EXT Email
> > 
> > Hi Biwen,
> > 
> > On Tue, Sep 17, 2019 at 10:09 AM Biwen Li <biwen.li@nxp.com> wrote:
> > > The patch adds kohms unit
> > >
> > > Signed-off-by: Biwen Li <biwen.li@nxp.com>
> > 
> > Thanks for your patch!
> > 
> > > --- a/Documentation/devicetree/bindings/property-units.txt
> > > +++ b/Documentation/devicetree/bindings/property-units.txt
> > > @@ -27,6 +27,7 @@ Electricity
> > >  -microamp      : microampere
> > >  -microamp-hours : microampere hour
> > >  -ohms          : ohm
> > > +-kohms         : kiloohm
> > >  -micro-ohms    : microohm
> > >  -microwatt-hours: microwatt hour
> > >  -microvolt     : microvolt
> > 
> > What's your rationale for adding "kohms"?
> > Do you need to specify resistance values that do not fit in 32-bit, and thus
> 32-bit is enough, I have three values, 60 kohm, 100 kohm and 500 kohm
> > cannot be specified using "ohms"?
> If replace with ohms, the value is as follows:
> 60000 ohm, 100000 ohm, 500000 ohm.
> It's so long for everyone.

It's not any longer, it's still 32-bits.

Please stick with '-ohms'.

Rob

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/property-units.txt b/Documentation/devicetree/bindings/property-units.txt
index e9b8360b3288..97feb8995d1f 100644
--- a/Documentation/devicetree/bindings/property-units.txt
+++ b/Documentation/devicetree/bindings/property-units.txt
@@ -27,6 +27,7 @@  Electricity
 -microamp	: microampere
 -microamp-hours : microampere hour
 -ohms		: ohm
+-kohms		: kiloohm
 -micro-ohms	: microohm
 -microwatt-hours: microwatt hour
 -microvolt	: microvolt