Message ID | 20190916154847.28936-2-philmd@redhat.com |
---|---|
State | New |
Headers | show |
Series | hw: Split RTC devices from hw/timer/ to hw/rtc/ | expand |
On Mon, Sep 16, 2019 at 9:02 AM Philippe Mathieu-Daudé <philmd@redhat.com> wrote: > > All these devices do not contain any target-specific. While most > of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > endianess, ...). > Put them into common-obj-y to compile them once for all targets. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/timer/Makefile.objs | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/hw/timer/Makefile.objs b/hw/timer/Makefile.objs > index 123d92c969..f407523aa4 100644 > --- a/hw/timer/Makefile.objs > +++ b/hw/timer/Makefile.objs > @@ -25,20 +25,20 @@ common-obj-$(CONFIG_MILKYMIST) += milkymist-sysctl.o > common-obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp-rtc.o > common-obj-$(CONFIG_NRF51_SOC) += nrf51_timer.o > > -obj-$(CONFIG_ALTERA_TIMER) += altera_timer.o > -obj-$(CONFIG_EXYNOS4) += exynos4210_mct.o > -obj-$(CONFIG_EXYNOS4) += exynos4210_pwm.o > -obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o > -obj-$(CONFIG_OMAP) += omap_gptimer.o > -obj-$(CONFIG_OMAP) += omap_synctimer.o > -obj-$(CONFIG_PXA2XX) += pxa2xx_timer.o > -obj-$(CONFIG_SH4) += sh_timer.o > -obj-$(CONFIG_DIGIC) += digic-timer.o > -obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o > +common-obj-$(CONFIG_ALTERA_TIMER) += altera_timer.o > +common-obj-$(CONFIG_EXYNOS4) += exynos4210_mct.o > +common-obj-$(CONFIG_EXYNOS4) += exynos4210_pwm.o > +common-obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o > +common-obj-$(CONFIG_OMAP) += omap_gptimer.o > +common-obj-$(CONFIG_OMAP) += omap_synctimer.o > +common-obj-$(CONFIG_PXA2XX) += pxa2xx_timer.o > +common-obj-$(CONFIG_SH4) += sh_timer.o > +common-obj-$(CONFIG_DIGIC) += digic-timer.o > +common-obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o > > obj-$(CONFIG_MC146818RTC) += mc146818rtc.o > > -obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o > +common-obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o > > common-obj-$(CONFIG_STM32F2XX_TIMER) += stm32f2xx_timer.o > common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o aspeed_rtc.o > -- > 2.20.1 > >
On 16/09/2019 17.48, Philippe Mathieu-Daudé wrote: > All these devices do not contain any target-specific. While most > of them are arch-specific, they are shared between different > targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, > endianess, ...). > Put them into common-obj-y to compile them once for all targets. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/timer/Makefile.objs | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/hw/timer/Makefile.objs b/hw/timer/Makefile.objs > index 123d92c969..f407523aa4 100644 > --- a/hw/timer/Makefile.objs > +++ b/hw/timer/Makefile.objs > @@ -25,20 +25,20 @@ common-obj-$(CONFIG_MILKYMIST) += milkymist-sysctl.o > common-obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp-rtc.o > common-obj-$(CONFIG_NRF51_SOC) += nrf51_timer.o > > -obj-$(CONFIG_ALTERA_TIMER) += altera_timer.o > -obj-$(CONFIG_EXYNOS4) += exynos4210_mct.o > -obj-$(CONFIG_EXYNOS4) += exynos4210_pwm.o > -obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o > -obj-$(CONFIG_OMAP) += omap_gptimer.o > -obj-$(CONFIG_OMAP) += omap_synctimer.o > -obj-$(CONFIG_PXA2XX) += pxa2xx_timer.o > -obj-$(CONFIG_SH4) += sh_timer.o > -obj-$(CONFIG_DIGIC) += digic-timer.o > -obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o > +common-obj-$(CONFIG_ALTERA_TIMER) += altera_timer.o > +common-obj-$(CONFIG_EXYNOS4) += exynos4210_mct.o > +common-obj-$(CONFIG_EXYNOS4) += exynos4210_pwm.o > +common-obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o > +common-obj-$(CONFIG_OMAP) += omap_gptimer.o > +common-obj-$(CONFIG_OMAP) += omap_synctimer.o > +common-obj-$(CONFIG_PXA2XX) += pxa2xx_timer.o > +common-obj-$(CONFIG_SH4) += sh_timer.o > +common-obj-$(CONFIG_DIGIC) += digic-timer.o > +common-obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o > > obj-$(CONFIG_MC146818RTC) += mc146818rtc.o > > -obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o > +common-obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o > > common-obj-$(CONFIG_STM32F2XX_TIMER) += stm32f2xx_timer.o > common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o aspeed_rtc.o > Reviewed-by: Thomas Huth <thuth@redhat.com> FWIW, that change is also part of my "hw/*/Makefile.objs: Move many .o files to common-objs" patch ... but since it looks identical, it should not matter, which patch goes in first.
diff --git a/hw/timer/Makefile.objs b/hw/timer/Makefile.objs index 123d92c969..f407523aa4 100644 --- a/hw/timer/Makefile.objs +++ b/hw/timer/Makefile.objs @@ -25,20 +25,20 @@ common-obj-$(CONFIG_MILKYMIST) += milkymist-sysctl.o common-obj-$(CONFIG_XLNX_ZYNQMP) += xlnx-zynqmp-rtc.o common-obj-$(CONFIG_NRF51_SOC) += nrf51_timer.o -obj-$(CONFIG_ALTERA_TIMER) += altera_timer.o -obj-$(CONFIG_EXYNOS4) += exynos4210_mct.o -obj-$(CONFIG_EXYNOS4) += exynos4210_pwm.o -obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o -obj-$(CONFIG_OMAP) += omap_gptimer.o -obj-$(CONFIG_OMAP) += omap_synctimer.o -obj-$(CONFIG_PXA2XX) += pxa2xx_timer.o -obj-$(CONFIG_SH4) += sh_timer.o -obj-$(CONFIG_DIGIC) += digic-timer.o -obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o +common-obj-$(CONFIG_ALTERA_TIMER) += altera_timer.o +common-obj-$(CONFIG_EXYNOS4) += exynos4210_mct.o +common-obj-$(CONFIG_EXYNOS4) += exynos4210_pwm.o +common-obj-$(CONFIG_EXYNOS4) += exynos4210_rtc.o +common-obj-$(CONFIG_OMAP) += omap_gptimer.o +common-obj-$(CONFIG_OMAP) += omap_synctimer.o +common-obj-$(CONFIG_PXA2XX) += pxa2xx_timer.o +common-obj-$(CONFIG_SH4) += sh_timer.o +common-obj-$(CONFIG_DIGIC) += digic-timer.o +common-obj-$(CONFIG_MIPS_CPS) += mips_gictimer.o obj-$(CONFIG_MC146818RTC) += mc146818rtc.o -obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o +common-obj-$(CONFIG_ALLWINNER_A10_PIT) += allwinner-a10-pit.o common-obj-$(CONFIG_STM32F2XX_TIMER) += stm32f2xx_timer.o common-obj-$(CONFIG_ASPEED_SOC) += aspeed_timer.o aspeed_rtc.o
All these devices do not contain any target-specific. While most of them are arch-specific, they are shared between different targets of the same arch family (ARM and AArch64, MIPS32/MIPS64, endianess, ...). Put them into common-obj-y to compile them once for all targets. Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/timer/Makefile.objs | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)