From patchwork Sun Sep 15 20:08:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Wetzel X-Patchwork-Id: 1162538 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=quarantine dis=none) header.from=wetzel-home.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="npv3/8Ky"; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=wetzel-home.de header.i=@wetzel-home.de header.b="DRkmLoIq"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46WgTx5kcWz9sNx for ; Mon, 16 Sep 2019 06:10:29 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cMycSp49vJAZ49P3pMAG1vc830ZqIE0wVgzoZRxSMVM=; b=npv3/8Ky/ZZH7u UEHlG3KVFAcT+r8J26Vekbpa1SwBkqjyBlCx77JOcV5qIBoUbicXTvFmfQg+E7/ghla4ewxWJpa3p RAvxivZ1H0Roki7LcE7oFg2N71x5kGF1Nx6Fp9NNKJXiNMQZ79sPOy89Rzk9Ks9JF7gcrPcFKTDcK 6jzfyPzRJhKZpledF/S3hWd8JVPItmVO4WNy3krdAVLPlJXMXvclVBnc65RxA8yoNGrFrOE2sFEme FHjC7H3Z4PBkNkhuQ5YEHiPB4XQRQo9JNCe/C3PqwKh5wgvkVIZ07/z7YllXK5aCKSh9D2LAvkJfC 5BDeKV+RgWW/vRjMbfRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9aqp-0008Ho-6Q; Sun, 15 Sep 2019 20:10:27 +0000 Received: from 18.mo3.mail-out.ovh.net ([87.98.172.162]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1i9apt-0006Mb-Nt for hostap@lists.infradead.org; Sun, 15 Sep 2019 20:09:33 +0000 Received: from player696.ha.ovh.net (unknown [10.108.35.215]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id 3E1E2225D8B for ; Sun, 15 Sep 2019 22:09:20 +0200 (CEST) Received: from awhome.eu (p57B7E67F.dip0.t-ipconnect.de [87.183.230.127]) (Authenticated sender: postmaster@awhome.eu) by player696.ha.ovh.net (Postfix) with ESMTPSA id DC31E9E2E067; Sun, 15 Sep 2019 20:09:16 +0000 (UTC) From: Alexander Wetzel DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wetzel-home.de; s=wetzel-home; t=1568578151; bh=u3yFvZetlqdfo0ZrdjgV33DrLyWmPAaRbMbLHbCkUNI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DRkmLoIq0LRv3XD6lD1MOnen0XqzGB50ofnV8SfbAvl6c1I4gLCTV1gnXbYiUb+fv gYPXEYzIOpc7XyrC1RhQY5FCClXya2P0RI9LjW0xg9MqWq+yvxGSNETO9mPKiYWicr sGFU2KZf0yXBobfrgVXkxSR005kXFirDqVDCkIdQ= To: j@w1.fi Subject: [PATCH v6 13/17] hostapd: FILS Extended Key ID support Date: Sun, 15 Sep 2019 22:08:33 +0200 Message-Id: <20190915200837.196283-14-alexander@wetzel-home.de> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190915200837.196283-1-alexander@wetzel-home.de> References: <20190915200837.196283-1-alexander@wetzel-home.de> MIME-Version: 1.0 X-Ovh-Tracer-Id: 11128394681375399164 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedruddugddugeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenuc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190915_130930_084094_81C43C24 X-CRM114-Status: GOOD ( 19.36 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [87.98.172.162 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Wetzel , hostap@lists.infradead.org, luca@coelho.fi, johannes@sipsolutions.net Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org IEEE 802.11ai - 2016 is missing any instructions how to handle FILS in combination with Extended Key ID. There are two obvious ways: 1) FILS connections can only use keyid 0 and the STAs decide on rekey if they can use Extended Key ID or not. 2) FILS also checks if Extended Key ID can be used by both STAs and adds the KeyID KDE when it's used to the initial handshake without the normally required eapol handshake. The later seems to be closer to the intent of 802.11ai and since there are no other implementations for Extended Key ID we could become incompatible to this patch implements option 2) for now. Signed-off-by: Alexander Wetzel --- Now this is a very free interpretation of how to handle Extended Key ID in combination with FILS. Technically it's the same issue as we have for FT, so I'm using the same (arguable) solution here: We bypass the 4-way handshake and Extended Key ID is therefore mostly irrelevant. Neither FILS nor FT mention Extended Key ID but both have a mechanism to hand over/get the GTK ID: Which of course could also handle the (unicast) KeyID required for Extended Key ID support... Now the patch series is rigorously sticking to the key install mode used at the initial connect: When either the AP or the STA tries to use anything else than for the initial connect we kill the connection. By also adding the KeyID to the others KDEs these checks work basically out of the box and the Extended Key ID flag in the RSN capabilities serves a purpose. Alternatively we could relax the checks and accept that we either still set the Extended Key ID bit in RSN but just assume the keyid is always zero for the initial connect with FT or FILS or even drop the bit in the RSN capabilities - creating a discrepancy to the beacon - and relax the sanity checks for FILS and FT accordingly. Since not Extended Key ID capable STAs won't care either way and there are no other Extended Key ID implementations we have to stay compatible with I decided to first try what I consider the cleanest way. Therefore Unicast KeyIDs have been added to the frames transporting also the GTK ID. Based on the feedback we either keep or change it. src/ap/wpa_auth.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/ap/wpa_auth.c b/src/ap/wpa_auth.c index 2ac9e404e..1ecb9b491 100644 --- a/src/ap/wpa_auth.c +++ b/src/ap/wpa_auth.c @@ -2684,6 +2684,15 @@ static struct wpabuf * fils_prepare_plainbuf(struct wpa_state_machine *sm, wpabuf_put_u8(plain, WLAN_EID_EXT_KEY_DELIVERY); wpa_auth_get_seqnum(sm->wpa_auth, NULL, gsm->GN, wpabuf_put(plain, WPA_KEY_RSC_LEN)); + + hdr[1] = 0; + if (sm->use_extended_key_id) { + hdr[0] = sm->keyidx_active & 0x01; + tmp = wpabuf_put(plain, 0); + tmp2 = wpa_add_kde(tmp, RSN_KEY_DATA_KEYID, hdr, 2, NULL, 0); + wpabuf_put(plain, tmp2 - tmp); + } + /* GTK KDE */ gtk = gsm->GTK[gsm->GN - 1]; gtk_len = gsm->GTK_len; @@ -2700,7 +2709,6 @@ static struct wpabuf * fils_prepare_plainbuf(struct wpa_state_machine *sm, gtk = dummy_gtk; } hdr[0] = gsm->GN & 0x03; - hdr[1] = 0; tmp = wpabuf_put(plain, 0); tmp2 = wpa_add_kde(tmp, RSN_KEY_DATA_GROUPKEY, hdr, 2, gtk, gtk_len); @@ -2755,7 +2763,7 @@ int fils_set_tk(struct wpa_state_machine *sm) klen = wpa_cipher_key_len(sm->pairwise); wpa_printf(MSG_DEBUG, "FILS: Configure TK to the driver"); - if (wpa_auth_set_key(sm->wpa_auth, 0, alg, sm->addr, 0, + if (wpa_auth_set_key(sm->wpa_auth, 0, alg, sm->addr, sm->keyidx_active, sm->PTK.tk, klen, KEY_TYPE_PAIRWISE)) { wpa_printf(MSG_DEBUG, "FILS: Failed to set TK to the driver"); return -1;