diff mbox series

[U-Boot,2/3] stm32mp1: configs: Add CONFIG_SPL_SPI_FLASH_MTD

Message ID 20190913224242.21054-2-frieder.schrempf@kontron.de
State Accepted
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series [U-Boot,1/3] mtd: spi: Add a new option SPL_SPI_FLASH_MTD to Kconfig | expand

Commit Message

Frieder Schrempf Sept. 13, 2019, 10:43 p.m. UTC 
From: Frieder Schrempf <frieder.schrempf@kontron.de>

As SPI_FLASH_MTD is used in SPL and U-Boot proper, we enable both,
now that a separate option for SPL was introduced.

Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
---
 configs/stm32mp15_basic_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Lukasz Majewski Sept. 16, 2019, 12:04 p.m. UTC | #1 
On Fri, 13 Sep 2019 22:43:43 +0000
Schrempf Frieder <frieder.schrempf@kontron.de> wrote:

> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> As SPI_FLASH_MTD is used in SPL and U-Boot proper, we enable both,
> now that a separate option for SPL was introduced.
> 
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
>  configs/stm32mp15_basic_defconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/stm32mp15_basic_defconfig
> b/configs/stm32mp15_basic_defconfig index 09785b5dc1..390319657f
> 100644 --- a/configs/stm32mp15_basic_defconfig
> +++ b/configs/stm32mp15_basic_defconfig
> @@ -7,10 +7,10 @@ CONFIG_TARGET_STM32MP1=y
>  CONFIG_SPL_SPI_FLASH_SUPPORT=y
>  CONFIG_SPL_SPI_SUPPORT=y
>  # CONFIG_ARMV7_VIRT is not set
> +CONFIG_SPL_TEXT_BASE=0x2FFC2500
>  CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_FIT=y
>  CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
> -CONFIG_SPL_TEXT_BASE=0x2FFC2500
>  CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION=y
>  CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION=3
>  CONFIG_SPL_I2C_SUPPORT=y
> @@ -90,6 +90,7 @@ CONFIG_SPI_FLASH_STMICRO=y
>  CONFIG_SPI_FLASH_WINBOND=y
>  # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
>  CONFIG_SPI_FLASH_MTD=y
> +CONFIG_SPL_SPI_FLASH_MTD=y
>  CONFIG_DM_ETH=y
>  CONFIG_DWC_ETH_QOS=y
>  CONFIG_PHY=y

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Jagan Teki Oct. 16, 2019, 4:34 p.m. UTC | #2 
On Sat, Sep 14, 2019 at 4:18 AM Schrempf Frieder
<frieder.schrempf@kontron.de> wrote:
>
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> As SPI_FLASH_MTD is used in SPL and U-Boot proper, we enable both,
> now that a separate option for SPL was introduced.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
>  configs/stm32mp15_basic_defconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig
> index 09785b5dc1..390319657f 100644
> --- a/configs/stm32mp15_basic_defconfig
> +++ b/configs/stm32mp15_basic_defconfig
> @@ -7,10 +7,10 @@ CONFIG_TARGET_STM32MP1=y
>  CONFIG_SPL_SPI_FLASH_SUPPORT=y
>  CONFIG_SPL_SPI_SUPPORT=y
>  # CONFIG_ARMV7_VIRT is not set
> +CONFIG_SPL_TEXT_BASE=0x2FFC2500
>  CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_FIT=y
>  CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
> -CONFIG_SPL_TEXT_BASE=0x2FFC2500

Unrelated change wrt to commit message?
Frieder Schrempf Oct. 17, 2019, 6:42 a.m. UTC | #3 
Hi Jagan,

On 16.10.19 18:34, Jagan Teki wrote:
> On Sat, Sep 14, 2019 at 4:18 AM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
>>
>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>
>> As SPI_FLASH_MTD is used in SPL and U-Boot proper, we enable both,
>> now that a separate option for SPL was introduced.
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>> ---
>>   configs/stm32mp15_basic_defconfig | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig
>> index 09785b5dc1..390319657f 100644
>> --- a/configs/stm32mp15_basic_defconfig
>> +++ b/configs/stm32mp15_basic_defconfig
>> @@ -7,10 +7,10 @@ CONFIG_TARGET_STM32MP1=y
>>   CONFIG_SPL_SPI_FLASH_SUPPORT=y
>>   CONFIG_SPL_SPI_SUPPORT=y
>>   # CONFIG_ARMV7_VIRT is not set
>> +CONFIG_SPL_TEXT_BASE=0x2FFC2500
>>   CONFIG_DISTRO_DEFAULTS=y
>>   CONFIG_FIT=y
>>   CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
>> -CONFIG_SPL_TEXT_BASE=0x2FFC2500
> 
> Unrelated change wrt to commit message?

Yes, this is unrelated, but that's what 'menuconfig' and 'savedefconfig' 
gave me as output. So I would think it's ok. If you don't think so, feel 
free to remove this change or let me know if I should remove it.

Thanks,
Frieder
Frieder Schrempf Oct. 22, 2019, 12:53 p.m. UTC | #4 
Hi Jagan,

On 17.10.19 08:42, Frieder Schrempf wrote:
> Hi Jagan,
> 
> On 16.10.19 18:34, Jagan Teki wrote:
>> On Sat, Sep 14, 2019 at 4:18 AM Schrempf Frieder
>> <frieder.schrempf@kontron.de> wrote:
>>>
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> As SPI_FLASH_MTD is used in SPL and U-Boot proper, we enable both,
>>> now that a separate option for SPL was introduced.
>>>
>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>> ---
>>>   configs/stm32mp15_basic_defconfig | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configs/stm32mp15_basic_defconfig 
>>> b/configs/stm32mp15_basic_defconfig
>>> index 09785b5dc1..390319657f 100644
>>> --- a/configs/stm32mp15_basic_defconfig
>>> +++ b/configs/stm32mp15_basic_defconfig
>>> @@ -7,10 +7,10 @@ CONFIG_TARGET_STM32MP1=y
>>>   CONFIG_SPL_SPI_FLASH_SUPPORT=y
>>>   CONFIG_SPL_SPI_SUPPORT=y
>>>   # CONFIG_ARMV7_VIRT is not set
>>> +CONFIG_SPL_TEXT_BASE=0x2FFC2500
>>>   CONFIG_DISTRO_DEFAULTS=y
>>>   CONFIG_FIT=y
>>>   CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
>>> -CONFIG_SPL_TEXT_BASE=0x2FFC2500
>>
>> Unrelated change wrt to commit message?
> 
> Yes, this is unrelated, but that's what 'menuconfig' and 'savedefconfig' 
> gave me as output. So I would think it's ok. If you don't think so, feel 
> free to remove this change or let me know if I should remove it.

In patchwork all three patches of this series are marked with "Changes 
Requested". Can you please let me know what needs to be fixed?

Thanks,
Frieder
Jagan Teki Oct. 22, 2019, 6:10 p.m. UTC | #5 
On Tue, Oct 22, 2019 at 6:23 PM Schrempf Frieder
<frieder.schrempf@kontron.de> wrote:
>
> Hi Jagan,
>
> On 17.10.19 08:42, Frieder Schrempf wrote:
> > Hi Jagan,
> >
> > On 16.10.19 18:34, Jagan Teki wrote:
> >> On Sat, Sep 14, 2019 at 4:18 AM Schrempf Frieder
> >> <frieder.schrempf@kontron.de> wrote:
> >>>
> >>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>>
> >>> As SPI_FLASH_MTD is used in SPL and U-Boot proper, we enable both,
> >>> now that a separate option for SPL was introduced.
> >>>
> >>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> >>> ---
> >>>   configs/stm32mp15_basic_defconfig | 3 ++-
> >>>   1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/configs/stm32mp15_basic_defconfig
> >>> b/configs/stm32mp15_basic_defconfig
> >>> index 09785b5dc1..390319657f 100644
> >>> --- a/configs/stm32mp15_basic_defconfig
> >>> +++ b/configs/stm32mp15_basic_defconfig
> >>> @@ -7,10 +7,10 @@ CONFIG_TARGET_STM32MP1=y
> >>>   CONFIG_SPL_SPI_FLASH_SUPPORT=y
> >>>   CONFIG_SPL_SPI_SUPPORT=y
> >>>   # CONFIG_ARMV7_VIRT is not set
> >>> +CONFIG_SPL_TEXT_BASE=0x2FFC2500
> >>>   CONFIG_DISTRO_DEFAULTS=y
> >>>   CONFIG_FIT=y
> >>>   CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
> >>> -CONFIG_SPL_TEXT_BASE=0x2FFC2500
> >>
> >> Unrelated change wrt to commit message?
> >
> > Yes, this is unrelated, but that's what 'menuconfig' and 'savedefconfig'
> > gave me as output. So I would think it's ok. If you don't think so, feel
> > free to remove this change or let me know if I should remove it.
>
> In patchwork all three patches of this series are marked with "Changes
> Requested". Can you please let me know what needs to be fixed?

Thought you might drop that unrelated change and send next version,
but anyway I have changed and

Applied to u-boot-spi/master
Frieder Schrempf Oct. 23, 2019, 6:47 a.m. UTC | #6 
Hi Jagan,

On 22.10.19 20:10, Jagan Teki wrote:
> On Tue, Oct 22, 2019 at 6:23 PM Schrempf Frieder
> <frieder.schrempf@kontron.de> wrote:
>>
>> Hi Jagan,
>>
>> On 17.10.19 08:42, Frieder Schrempf wrote:
>>> Hi Jagan,
>>>
>>> On 16.10.19 18:34, Jagan Teki wrote:
>>>> On Sat, Sep 14, 2019 at 4:18 AM Schrempf Frieder
>>>> <frieder.schrempf@kontron.de> wrote:
>>>>>
>>>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>>>
>>>>> As SPI_FLASH_MTD is used in SPL and U-Boot proper, we enable both,
>>>>> now that a separate option for SPL was introduced.
>>>>>
>>>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>>> ---
>>>>>    configs/stm32mp15_basic_defconfig | 3 ++-
>>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/configs/stm32mp15_basic_defconfig
>>>>> b/configs/stm32mp15_basic_defconfig
>>>>> index 09785b5dc1..390319657f 100644
>>>>> --- a/configs/stm32mp15_basic_defconfig
>>>>> +++ b/configs/stm32mp15_basic_defconfig
>>>>> @@ -7,10 +7,10 @@ CONFIG_TARGET_STM32MP1=y
>>>>>    CONFIG_SPL_SPI_FLASH_SUPPORT=y
>>>>>    CONFIG_SPL_SPI_SUPPORT=y
>>>>>    # CONFIG_ARMV7_VIRT is not set
>>>>> +CONFIG_SPL_TEXT_BASE=0x2FFC2500
>>>>>    CONFIG_DISTRO_DEFAULTS=y
>>>>>    CONFIG_FIT=y
>>>>>    CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
>>>>> -CONFIG_SPL_TEXT_BASE=0x2FFC2500
>>>>
>>>> Unrelated change wrt to commit message?
>>>
>>> Yes, this is unrelated, but that's what 'menuconfig' and 'savedefconfig'
>>> gave me as output. So I would think it's ok. If you don't think so, feel
>>> free to remove this change or let me know if I should remove it.
>>
>> In patchwork all three patches of this series are marked with "Changes
>> Requested". Can you please let me know what needs to be fixed?
> 
> Thought you might drop that unrelated change and send next version,
> but anyway I have changed and

I have asked you to "let me know if I should remove it" above and you 
didn't do so. Therefore I assumed you do it yourself, or you apply it as is.

> 
> Applied to u-boot-spi/master
> 

Anyway, thanks a lot!

Regards,
Frieder
diff mbox series

Patch

diff --git a/configs/stm32mp15_basic_defconfig b/configs/stm32mp15_basic_defconfig
index 09785b5dc1..390319657f 100644
--- a/configs/stm32mp15_basic_defconfig
+++ b/configs/stm32mp15_basic_defconfig
@@ -7,10 +7,10 @@  CONFIG_TARGET_STM32MP1=y
 CONFIG_SPL_SPI_FLASH_SUPPORT=y
 CONFIG_SPL_SPI_SUPPORT=y
 # CONFIG_ARMV7_VIRT is not set
+CONFIG_SPL_TEXT_BASE=0x2FFC2500
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_FIT=y
 CONFIG_BOOTCOMMAND="run bootcmd_stm32mp"
-CONFIG_SPL_TEXT_BASE=0x2FFC2500
 CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_USE_PARTITION=y
 CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_PARTITION=3
 CONFIG_SPL_I2C_SUPPORT=y
@@ -90,6 +90,7 @@  CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
 CONFIG_SPI_FLASH_MTD=y
+CONFIG_SPL_SPI_FLASH_MTD=y
 CONFIG_DM_ETH=y
 CONFIG_DWC_ETH_QOS=y
 CONFIG_PHY=y