| Message ID | 20190913141930.15784-2-patrick.delaunay@st.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Lukasz Majewski |
| Headers | show |
| Series | dfu: update dfu stack and add MTD backend | expand |
On Fri, 13 Sep 2019 16:19:17 +0200 Patrick Delaunay <patrick.delaunay@st.com> wrote: > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> > --- > > drivers/dfu/dfu.c | 7 ++++--- > drivers/dfu/dfu_sf.c | 4 ++-- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c > index d2b67b18cf..e9db7f8d66 100644 > --- a/drivers/dfu/dfu.c > +++ b/drivers/dfu/dfu.c > @@ -478,14 +478,15 @@ int dfu_config_entities(char *env, char > *interface, char *devstr) > const char *dfu_get_dev_type(enum dfu_device_type t) > { > - const char *dev_t[] = {NULL, "eMMC", "OneNAND", "NAND", > "RAM", "SF" }; > + const char *const dev_t[] = {NULL, "eMMC", "OneNAND", > "NAND", "RAM", > + "SF"}; > return dev_t[t]; > } > > const char *dfu_get_layout(enum dfu_layout l) > { > - const char *dfu_layout[] = {NULL, "RAW_ADDR", "FAT", "EXT2", > - "EXT3", "EXT4", > "RAM_ADDR" }; > + const char *const dfu_layout[] = {NULL, "RAW_ADDR", "FAT", > "EXT2", > + "EXT3", "EXT4", "RAM_ADDR" > }; return dfu_layout[l]; > } > > diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c > index 066e7670d1..b78fcfd3a1 100644 > --- a/drivers/dfu/dfu_sf.c > +++ b/drivers/dfu/dfu_sf.c > @@ -19,7 +19,7 @@ static int dfu_get_medium_size_sf(struct dfu_entity > *dfu, u64 *size) } > > static int dfu_read_medium_sf(struct dfu_entity *dfu, u64 offset, > void *buf, > - long *len) > + long *len) > { > return spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start + > offset, *len, buf); > @@ -32,7 +32,7 @@ static u64 find_sector(struct dfu_entity *dfu, u64 > start, u64 offset) } > > static int dfu_write_medium_sf(struct dfu_entity *dfu, > - u64 offset, void *buf, long *len) > + u64 offset, void *buf, long *len) > { > int ret; > Acked-by: Lukasz Majewski <lukma@denx.de> Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff --git a/drivers/dfu/dfu.c b/drivers/dfu/dfu.c index d2b67b18cf..e9db7f8d66 100644 --- a/drivers/dfu/dfu.c +++ b/drivers/dfu/dfu.c @@ -478,14 +478,15 @@ int dfu_config_entities(char *env, char *interface, char *devstr) const char *dfu_get_dev_type(enum dfu_device_type t) { - const char *dev_t[] = {NULL, "eMMC", "OneNAND", "NAND", "RAM", "SF" }; + const char *const dev_t[] = {NULL, "eMMC", "OneNAND", "NAND", "RAM", + "SF"}; return dev_t[t]; } const char *dfu_get_layout(enum dfu_layout l) { - const char *dfu_layout[] = {NULL, "RAW_ADDR", "FAT", "EXT2", - "EXT3", "EXT4", "RAM_ADDR" }; + const char *const dfu_layout[] = {NULL, "RAW_ADDR", "FAT", "EXT2", + "EXT3", "EXT4", "RAM_ADDR" }; return dfu_layout[l]; } diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c index 066e7670d1..b78fcfd3a1 100644 --- a/drivers/dfu/dfu_sf.c +++ b/drivers/dfu/dfu_sf.c @@ -19,7 +19,7 @@ static int dfu_get_medium_size_sf(struct dfu_entity *dfu, u64 *size) } static int dfu_read_medium_sf(struct dfu_entity *dfu, u64 offset, void *buf, - long *len) + long *len) { return spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start + offset, *len, buf); @@ -32,7 +32,7 @@ static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 offset) } static int dfu_write_medium_sf(struct dfu_entity *dfu, - u64 offset, void *buf, long *len) + u64 offset, void *buf, long *len) { int ret;
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com> --- drivers/dfu/dfu.c | 7 ++++--- drivers/dfu/dfu_sf.c | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-)