Patchwork jffs2/security.c: local functions should be static

login
register
mail settings
Submitter hartleys
Date Sept. 23, 2011, 10:56 p.m.
Message ID <201109231556.15973.hartleys@visionengravers.com>
Download mbox | patch
Permalink /patch/116193/
State New
Headers show

Comments

hartleys - Sept. 23, 2011, 10:56 p.m.
Quiets the sparse noise:

warning: symbol 'jffs2_initxattrs' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: David Woodhouse <dwmw2@infradead.org>

---
Artem Bityutskiy - Oct. 1, 2011, 11:39 a.m.
On Fri, 2011-09-23 at 15:56 -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
> 
> warning: symbol 'jffs2_initxattrs' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: David Woodhouse <dwmw2@infradead.org>

Against which tree is this patch? My l2-mtd-2.6 tree does not have this
function, and it is based on Linux 3.1-rc2.

Patch

diff --git a/fs/jffs2/security.c b/fs/jffs2/security.c
index 0f20208..aca97f3 100644
--- a/fs/jffs2/security.c
+++ b/fs/jffs2/security.c
@@ -23,8 +23,8 @@ 
 #include "nodelist.h"
 
 /* ---- Initial Security Label(s) Attachment callback --- */
-int jffs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
-		     void *fs_info)
+static int jffs2_initxattrs(struct inode *inode,
+			    const struct xattr *xattr_array, void *fs_info)
 {
 	const struct xattr *xattr;
 	int err = 0;