Patchwork ext4/xattr_security.c: local functions should be static

login
register
mail settings
Submitter hartleys
Date Sept. 23, 2011, 10:38 p.m.
Message ID <201109231538.22933.hartleys@visionengravers.com>
Download mbox | patch
Permalink /patch/116191/
State Rejected
Headers show

Comments

hartleys - Sept. 23, 2011, 10:38 p.m.
Quiets the sparse noise:

warning: symbol 'ext4_initxattrs' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>

---

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Oct. 12, 2011, 3:09 a.m.
On Fri, Sep 23, 2011 at 03:38:22PM -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
> 
> warning: symbol 'ext4_initxattrs' was not declared. Should it be static?

What version of the kernel was this from?  I can't find
ext4_initxattrs in any kernel version that I can find in git...

		       	      	      	     - Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c
index 34e4350..827fbfd 100644
--- a/fs/ext4/xattr_security.c
+++ b/fs/ext4/xattr_security.c
@@ -48,7 +48,7 @@  ext4_xattr_security_set(struct dentry *dentry, const char *name,
 			      name, value, size, flags);
 }
 
-int ext4_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext4_initxattrs(struct inode *inode, const struct xattr *xattr_array,
 		    void *fs_info)
 {
 	const struct xattr *xattr;