Patchwork ext4/extents.c: quiet sparse noise about plain integer as NULL pointer

login
register
mail settings
Submitter hartleys
Date Sept. 23, 2011, 10:32 p.m.
Message ID <201109231532.44363.hartleys@visionengravers.com>
Download mbox | patch
Permalink /patch/116190/
State Accepted
Headers show

Comments

hartleys - Sept. 23, 2011, 10:32 p.m.
The third parameter to ext4_free_blocks is a struct buffer_head *.  This
parameter should be NULL not 0.

This quiets the sparse noise:

warning: Using plain integer as NULL pointer

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>

---

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - Oct. 12, 2011, 3:11 a.m.
On Fri, Sep 23, 2011 at 03:32:44PM -0700, H Hartley Sweeten wrote:
> The third parameter to ext4_free_blocks is a struct buffer_head *.  This
> parameter should be NULL not 0.
> 
> This quiets the sparse noise:
> 
> warning: Using plain integer as NULL pointer
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>

Thanks, applied.

					- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 57cf568..97e8d2b 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2238,7 +2238,7 @@  static int ext4_remove_blocks(handle_t *handle, struct inode *inode,
 		start = ext4_ext_pblock(ex);
 
 		ext_debug("free first %u blocks starting %llu\n", num, start);
-		ext4_free_blocks(handle, inode, 0, start, num, flags);
+		ext4_free_blocks(handle, inode, NULL, start, num, flags);
 
 	} else {
 		printk(KERN_INFO "strange request: removal(2) "