From patchwork Fri Sep 23 22:19:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hartley Sweeten X-Patchwork-Id: 116185 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 18AEBB6F82 for ; Sat, 24 Sep 2011 08:19:58 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752573Ab1IWWT4 (ORCPT ); Fri, 23 Sep 2011 18:19:56 -0400 Received: from mail127.messagelabs.com ([216.82.250.115]:23027 "EHLO mail127.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752276Ab1IWWTz convert rfc822-to-8bit (ORCPT ); Fri, 23 Sep 2011 18:19:55 -0400 X-Env-Sender: hartleys@visionengravers.com X-Msg-Ref: server-5.tower-127.messagelabs.com!1316816391!32614386!7 X-Originating-IP: [216.166.12.69] X-StarScan-Version: 6.3.6; banners=-,-,- X-VirusChecked: Checked Received: (qmail 22870 invoked from network); 23 Sep 2011 22:19:55 -0000 Received: from out001.collaborationhost.net (HELO out001.collaborationhost.net) (216.166.12.69) by server-5.tower-127.messagelabs.com with RC4-SHA encrypted SMTP; 23 Sep 2011 22:19:55 -0000 Received: from etch.local (10.2.3.210) by smtp.collaborationhost.net (10.2.0.118) with Microsoft SMTP Server (TLS) id 8.3.137.0; Fri, 23 Sep 2011 17:19:54 -0500 From: H Hartley Sweeten To: Linux Kernel Subject: [PATCH] ext4/ialloc.c: functions should not be declared extern Date: Fri, 23 Sep 2011 15:19:45 -0700 User-Agent: KMail/1.9.9 CC: , , MIME-Version: 1.0 Content-Disposition: inline Message-ID: <201109231519.45350.hartleys@visionengravers.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org The function declaration in ext4.h is already marked extern.  The function definition should not have the tag. This quiets the sparse noise: warning: function 'ext4_init_inode_table' with external linkage has definition Signed-off-by: H Hartley Sweeten Cc: "Theodore Ts'o" Cc: Andreas Dilger --- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index fd96ea1..ef9bdd6 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -1235,7 +1235,7 @@ unsigned long ext4_count_dirs(struct super_block * sb) * inode allocation from the current group, so we take alloc_sem lock, to * block ext4_claim_inode until we are finished. */ -extern int ext4_init_inode_table(struct super_block *sb, ext4_group_t group, +int ext4_init_inode_table(struct super_block *sb, ext4_group_t group, int barrier) { struct ext4_group_info *grp = ext4_get_group_info(sb, group);