Patchwork ext3/xattr_seciruty.c: local functions should be static

login
register
mail settings
Submitter hartleys
Date Sept. 23, 2011, 10:07 p.m.
Message ID <201109231507.09998.hartleys@visionengravers.com>
Download mbox | patch
Permalink /patch/116182/
State Not Applicable
Headers show

Comments

hartleys - Sept. 23, 2011, 10:07 p.m.
Quiets the sparse noise:

warning: symbol 'ext3_initxattrs' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>

---

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Kara - Oct. 4, 2011, 11:37 p.m.
On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
> Quiets the sparse noise:
> 
> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
  Here applies the same comment as to the ext2 patch - not in current
Linus' kernel AFAICS.

								Honza
> 
> ---
> 
> diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
> index 3c218b8..3f065f8 100644
> --- a/fs/ext3/xattr_security.c
> +++ b/fs/ext3/xattr_security.c
> @@ -48,7 +48,7 @@ ext3_xattr_security_set(struct dentry *dentry, const char *name,
>  			      name, value, size, flags);
>  }
>  
> -int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
>  		    void *fs_info)
>  {
>  	const struct xattr *xattr;
hartleys - Oct. 5, 2011, 5:27 p.m.
On Tuesday, October 04, 2011 4:38 PM, Jan Kara wrote:
> On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
>> Quiets the sparse noise:
>> 
>> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Jan Kara <jack@suse.cz>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
>  Here applies the same comment as to the ext2 patch - not in current
> Linus' kernel AFAICS.

These are in linux-next due to:

commit 9d8f13ba3f4833219e50767b022b82cd0da930eb
Author: Mimi Zohar <zohar@linux.vnet.ibm.com>
Date:   Mon Jun 6 15:29:25 2011 -0400

    security: new security_inode_init_security API adds function callback

I can repost these after this commit hits Linus' kernel if necessary.

Thanks,
Hartley--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jan Kara - Oct. 5, 2011, 8:18 p.m.
On Wed 05-10-11 12:27:06, H Hartley Sweeten wrote:
> On Tuesday, October 04, 2011 4:38 PM, Jan Kara wrote:
> > On Fri 23-09-11 15:07:09, H Hartley Sweeten wrote:
> >> Quiets the sparse noise:
> >> 
> >> warning: symbol 'ext3_initxattrs' was not declared. Should it be static?
> >> 
> >> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> >> Cc: Jan Kara <jack@suse.cz>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> >  Here applies the same comment as to the ext2 patch - not in current
> > Linus' kernel AFAICS.
> 
> These are in linux-next due to:
> 
> commit 9d8f13ba3f4833219e50767b022b82cd0da930eb
> Author: Mimi Zohar <zohar@linux.vnet.ibm.com>
> Date:   Mon Jun 6 15:29:25 2011 -0400
> 
>     security: new security_inode_init_security API adds function callback
> 
> I can repost these after this commit hits Linus' kernel if necessary.
  I see. OK, please repost when they hit Linus' kernel since I guess it's
not urgent to merge these.

								Honza

Patch

diff --git a/fs/ext3/xattr_security.c b/fs/ext3/xattr_security.c
index 3c218b8..3f065f8 100644
--- a/fs/ext3/xattr_security.c
+++ b/fs/ext3/xattr_security.c
@@ -48,7 +48,7 @@  ext3_xattr_security_set(struct dentry *dentry, const char *name,
 			      name, value, size, flags);
 }
 
-int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext3_initxattrs(struct inode *inode, const struct xattr *xattr_array,
 		    void *fs_info)
 {
 	const struct xattr *xattr;