| Message ID | 20190912130007.4469-4-bparrot@ti.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | media: i2c: ov2659: maintenance series | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
Hi Benoit, Thank you for the patch. On Thu, Sep 12, 2019 at 1:58 PM Benoit Parrot <bparrot@ti.com> wrote: > > Add powerdown-gpios to the list of optional properties for the OV2659 > camera sensor. > > Signed-off-by: Benoit Parrot <bparrot@ti.com> > --- > Documentation/devicetree/bindings/media/i2c/ov2659.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ov2659.txt > index cabc7d827dfb..f55204cce0cd 100644 > --- a/Documentation/devicetree/bindings/media/i2c/ov2659.txt > +++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt > @@ -12,6 +12,10 @@ Required Properties: > - clock-names: should be "xvclk". > - link-frequencies: target pixel clock frequency. > > +Optional Properties: > +- powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any. > + Active is low. > + as per the datasheet this should be active high with pull-down resistor. Cheers, --Prabhakar Lad
Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote on Sat [2019-Sep-14 11:11:02 +0100]: > Hi Benoit, > > Thank you for the patch. > > On Thu, Sep 12, 2019 at 1:58 PM Benoit Parrot <bparrot@ti.com> wrote: > > > > Add powerdown-gpios to the list of optional properties for the OV2659 > > camera sensor. > > > > Signed-off-by: Benoit Parrot <bparrot@ti.com> > > --- > > Documentation/devicetree/bindings/media/i2c/ov2659.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ov2659.txt > > index cabc7d827dfb..f55204cce0cd 100644 > > --- a/Documentation/devicetree/bindings/media/i2c/ov2659.txt > > +++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt > > @@ -12,6 +12,10 @@ Required Properties: > > - clock-names: should be "xvclk". > > - link-frequencies: target pixel clock frequency. > > > > +Optional Properties: > > +- powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any. > > + Active is low. > > + > as per the datasheet this should be active high with pull-down resistor. Ahhh, yes I'll fix that. > > Cheers, > --Prabhakar Lad
diff --git a/Documentation/devicetree/bindings/media/i2c/ov2659.txt b/Documentation/devicetree/bindings/media/i2c/ov2659.txt index cabc7d827dfb..f55204cce0cd 100644 --- a/Documentation/devicetree/bindings/media/i2c/ov2659.txt +++ b/Documentation/devicetree/bindings/media/i2c/ov2659.txt @@ -12,6 +12,10 @@ Required Properties: - clock-names: should be "xvclk". - link-frequencies: target pixel clock frequency. +Optional Properties: +- powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any. + Active is low. + For further reading on port node refer to Documentation/devicetree/bindings/media/video-interfaces.txt. @@ -27,6 +31,8 @@ Example: clocks = <&clk_ov2659 0>; clock-names = "xvclk"; + powerdown-gpios = <&gpio6 14 GPIO_ACTIVE_LOW>; + port { ov2659_0: endpoint { remote-endpoint = <&vpfe_ep>;
Add powerdown-gpios to the list of optional properties for the OV2659 camera sensor. Signed-off-by: Benoit Parrot <bparrot@ti.com> --- Documentation/devicetree/bindings/media/i2c/ov2659.txt | 6 ++++++ 1 file changed, 6 insertions(+)