Message ID | 20190912091656.14301-3-rasmus.villemoes@prevas.dk |
---|---|
State | Accepted |
Commit | fb9462522991a50b95ea00fdbc495634bb6a7cca |
Delegated to: | Stefano Babic |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=prevas.dk Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=prevas.se header.i=@prevas.se header.b="ssC01U1Q"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46TYFS0f1pz9s4Y for <incoming@patchwork.ozlabs.org>; Thu, 12 Sep 2019 19:22:20 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id C2C32C21E34; Thu, 12 Sep 2019 09:20:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 95C23C21E44; Thu, 12 Sep 2019 09:17:36 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 2D203C21E74; Thu, 12 Sep 2019 09:17:28 +0000 (UTC) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60138.outbound.protection.outlook.com [40.107.6.138]) by lists.denx.de (Postfix) with ESMTPS id 34C89C21E49 for <u-boot@lists.denx.de>; Thu, 12 Sep 2019 09:17:12 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kLpirOA8CUKJKHAcPYxc04kio8GI1SDNU1Azjwf9Yy/RLZqVF41JICP6AMote99mfM41hXo1gskRjPCxra+va/8WJl+r0NmMhIQTQKtQlCAOhzTNcwl9j+GAY9R0vsup3WeDgB5cwSUmL5000ByxIN8EysOLQ6/Ltjg6+vELnDiaKUCoNc4KFogcYDxaZSuJWYBNelDemhBZfi+SxtuoKkeoy8fOGmSbO6L0/L575sgfEeChTLzwToC061BtHXEmhfLpaFNg5mWCrkufsj0qrfMac2C195iXzctIHHj9bAljz1t6SnKK8JOz581fiUpSoUfXuJht4tLyjOq7T5/cmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GUOghRGOTkMEMW2OIZtXd1olkgrCIQQc2W7KVlr54sA=; b=HFGvkro1tU8FLvEn9FiwC/67sLgo7PdygyWr5abKWKDHhQmg69gUOwk7+ojZQqwD3L9PYJu4azP5Y7piXC6vRW/8VK0L4280dtMtf73GUxLKqPWvHsi+ibXXW6tbz9TNZ7/jofiDRg0PYM6+O3o7qlvogMjf+HcXw/+J6q0PrBYC9Y1t5zfPQSWZdIrNXlwuQKwbrXgnguqhAD8V5KyTZfKhWbqrKYHONJ9P/PWO5wp4zJRJGZDOyHXMZ05RMKv645aJ32dKjADHEiisRw0OOEGIjogNbHk7FfETb7K+dZqMN66zqD8bJ/gtUJoA10rETaSGU1NpxwKPdXOypxX09A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=prevas.se; dmarc=pass action=none header.from=prevas.dk; dkim=pass header.d=prevas.dk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.se; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GUOghRGOTkMEMW2OIZtXd1olkgrCIQQc2W7KVlr54sA=; b=ssC01U1QruqoQ3UPFONL/Zxrg0FTeKG9xCiMWNMldRgyOpxTBmpu7Shbks/UIUuOrZuw8uhqh4FWCBqTAP1te7Yj2Rqhd2mdQNgvabqTWNCwwh9IlqhU1+uOVvhy70Re+3LsZAi24QE7A5Lk/vCU4QIUr06RCKAUaTpxcRf3RiE= Received: from AM7PR10MB3478.EURPRD10.PROD.OUTLOOK.COM (10.186.168.7) by AM7PR10MB3480.EURPRD10.PROD.OUTLOOK.COM (10.186.168.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14; Thu, 12 Sep 2019 09:17:10 +0000 Received: from AM7PR10MB3478.EURPRD10.PROD.OUTLOOK.COM ([fe80::f0d2:3945:47d4:747b]) by AM7PR10MB3478.EURPRD10.PROD.OUTLOOK.COM ([fe80::f0d2:3945:47d4:747b%3]) with mapi id 15.20.2241.018; Thu, 12 Sep 2019 09:17:10 +0000 From: Rasmus Villemoes <rasmus.villemoes@prevas.dk> To: "u-boot@lists.denx.de" <u-boot@lists.denx.de> Thread-Topic: [PATCH 2/4] arm: mxs: fix comments in arch_cpu_init to match the code Thread-Index: AQHVaUrbmvXJ82hs1ECQwoJR8vFHIA== Date: Thu, 12 Sep 2019 09:17:10 +0000 Message-ID: <20190912091656.14301-3-rasmus.villemoes@prevas.dk> References: <20190912091656.14301-1-rasmus.villemoes@prevas.dk> In-Reply-To: <20190912091656.14301-1-rasmus.villemoes@prevas.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR0202CA0019.eurprd02.prod.outlook.com (2603:10a6:3:8c::29) To AM7PR10MB3478.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:131::7) x-mailer: git-send-email 2.20.1 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasmus.Villemoes@prevas.se; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [81.216.59.226] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 725485a8-f092-45e5-6a33-08d73761fdb8 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:AM7PR10MB3480; x-ms-traffictypediagnostic: AM7PR10MB3480: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <AM7PR10MB3480E88F2B7F18FDC0A3104C8AB00@AM7PR10MB3480.EURPRD10.PROD.OUTLOOK.COM> x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 01583E185C x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39850400004)(366004)(346002)(376002)(136003)(396003)(199004)(189003)(66556008)(66476007)(71200400001)(1076003)(64756008)(3846002)(4326008)(6116002)(5640700003)(2501003)(6916009)(6512007)(52116002)(107886003)(2906002)(6486002)(7736002)(8936002)(5660300002)(256004)(25786009)(71190400001)(53936002)(8976002)(50226002)(14454004)(305945005)(2351001)(81166006)(36756003)(54906003)(186003)(478600001)(4744005)(66946007)(99286004)(66066001)(8676002)(81156014)(446003)(76176011)(102836004)(476003)(11346002)(6436002)(2616005)(44832011)(486006)(66446008)(316002)(42882007)(26005)(386003)(6506007); DIR:OUT; SFP:1102; SCL:1; SRVR:AM7PR10MB3480; H:AM7PR10MB3478.EURPRD10.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: prevas.se does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: i3yOdnvlnE4K6kov16Vqxsa2L58hXsmuD58mgXyvrqyh5cqBGYpHa0iB+dPSL6YQ3l0fTFZP8Lds/ay+9YhG4yMJSI5zmfQFG6kHnlo84RwE79K7Np1DbTVGxz0ybygv7DR9ZEUG/QeU6AU8Ff6oY9mvD8X7o8boItxxzNf6jhYHEL36nJJRLOQ3AxuUbEC2zGZz037SLN4felyU6YUVj9t9tKE5Htc0RsNiTyGqapcTpfZxlTkHfktfU39iZlMlfgJMQ8UjPz8G7jAZgrnyq9fOhEaAUI33dWDjO/aMp+zy6T5aDsW3b8oztUh5Wijsp8lyCHbUqQ8ICTreO02hqilY0VJXZ/lFhDeWVoTjp7oqYQQ/gGBbMbgrft3xrzijWzUJukDKlPLMr8gcD0UAVQtCw45plGmVKdhBkWLMduI= MIME-Version: 1.0 X-OriginatorOrg: prevas.dk X-MS-Exchange-CrossTenant-Network-Message-Id: 725485a8-f092-45e5-6a33-08d73761fdb8 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2019 09:17:10.6172 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d350cf71-778d-4780-88f5-071a4cb1ed61 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cAkb5g6tUBtZ2WpA5iboQ7Zmw2usf5aJmZm1LoL+IOvD9s1TR58W14xSUUXqQEKezJ1g4I6suzacodBLgSOZi/9vLvSlPA2GyvhQ8lwC8mA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR10MB3480 Cc: Rasmus Villemoes <Rasmus.Villemoes@prevas.se>, "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>, Marek Vasut <marek.vasut+renesas@gmail.com> Subject: [U-Boot] [PATCH 2/4] arm: mxs: fix comments in arch_cpu_init to match the code X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> |
Series |
arm: mxs: mxs_set_gpmiclk
|
expand
|
diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c b/arch/arm/cpu/arm926ejs/mxs/mxs.c index 85c65dcb44..585c53baf6 100644 --- a/arch/arm/cpu/arm926ejs/mxs/mxs.c +++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c @@ -98,11 +98,11 @@ int arch_cpu_init(void) /* * Enable NAND clock */ - /* Clear bypass bit */ + /* Set bypass bit */ writel(CLKCTRL_CLKSEQ_BYPASS_GPMI, &clkctrl_regs->hw_clkctrl_clkseq_set); - /* Set GPMI clock to ref_gpmi / 12 */ + /* Set GPMI clock to ref_xtal / 1 */ clrsetbits_le32(&clkctrl_regs->hw_clkctrl_gpmi, CLKCTRL_GPMI_CLKGATE | CLKCTRL_GPMI_DIV_MASK, 1);
The comment says to clear the bypass bit, but in fact it sets it, thus selecting ref_xtal. And the next line of code does not set the divider to 12, but to (the reset value of) 1. Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> --- arch/arm/cpu/arm926ejs/mxs/mxs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)