exfat, exfat-utils: fix the installation path of the helper utilities
diff mbox series

Message ID 466c3d76-7b83-90e6-27f2-aa78f70d47aa@grandegger.com
State Superseded
Headers show
Series
  • exfat, exfat-utils: fix the installation path of the helper utilities
Related show

Commit Message

Wolfgang Grandegger Sept. 12, 2019, 7:17 a.m. UTC
"mount" from the "util-linux" package does expect the helper utilities
in "/sbin" and not "/usr/sbin".

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
 package/exfat-utils/exfat-utils.mk | 2 ++
 package/exfat/exfat.mk             | 2 ++
 2 files changed, 4 insertions(+)

Comments

Carlos Santos Sept. 20, 2019, 1:15 p.m. UTC | #1
On Thu, Sep 12, 2019 at 4:25 AM Wolfgang Grandegger <wg@grandegger.com> wrote:
>
> "mount" from the "util-linux" package does expect the helper utilities
> in "/sbin" and not "/usr/sbin".
>
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> ---
>  package/exfat-utils/exfat-utils.mk | 2 ++
>  package/exfat/exfat.mk             | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
> index 62cd471..d22d5c9 100644
> --- a/package/exfat-utils/exfat-utils.mk
> +++ b/package/exfat-utils/exfat-utils.mk
> @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
>  EXFAT_UTILS_LICENSE = GPL-3.0+
>  EXFAT_UTILS_LICENSE_FILES = COPYING
>
> +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> +
>  $(eval $(autotools-package))
> diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> index b52b197..0d4f1c9 100644
> --- a/package/exfat/exfat.mk
> +++ b/package/exfat/exfat.mk
> @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
>  EXFAT_LICENSE_FILES = COPYING
>  EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
>
> +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> +
>  $(eval $(autotools-package))
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

We normally use a patch series instead of changing more than one
package in a single patch. In this case, however, I think it's fine to
do it at once, since it's necessary to fix both  mount.exfat (exfat)
and {fsck,mkfs}.exfat (exfat-utils). So,

Reviewed-by: Carlos Santos <unixmania@gmail.com>
Arnout Vandecappelle Sept. 21, 2019, 11:39 a.m. UTC | #2
On 12/09/2019 09:17, Wolfgang Grandegger wrote:
> "mount" from the "util-linux" package does expect the helper utilities
> in "/sbin" and not "/usr/sbin".
> 
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> ---
>  package/exfat-utils/exfat-utils.mk | 2 ++
>  package/exfat/exfat.mk             | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
> index 62cd471..d22d5c9 100644
> --- a/package/exfat-utils/exfat-utils.mk
> +++ b/package/exfat-utils/exfat-utils.mk
> @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
>  EXFAT_UTILS_LICENSE = GPL-3.0+
>  EXFAT_UTILS_LICENSE_FILES = COPYING
>  
> +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> +
>  $(eval $(autotools-package))
> diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> index b52b197..0d4f1c9 100644
> --- a/package/exfat/exfat.mk
> +++ b/package/exfat/exfat.mk
> @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
>  EXFAT_LICENSE_FILES = COPYING
>  EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
>  
> +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib

 Why not just set --prefix=/ ?

 Regards,
 Arnout

> +
>  $(eval $(autotools-package))
>
Carlos Santos Sept. 22, 2019, 10:34 p.m. UTC | #3
On Sat, Sep 21, 2019 at 8:40 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 12/09/2019 09:17, Wolfgang Grandegger wrote:
> > "mount" from the "util-linux" package does expect the helper utilities
> > in "/sbin" and not "/usr/sbin".
> >
> > Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> > ---
> >  package/exfat-utils/exfat-utils.mk | 2 ++
> >  package/exfat/exfat.mk             | 2 ++
> >  2 files changed, 4 insertions(+)
> >
> > diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
> > index 62cd471..d22d5c9 100644
> > --- a/package/exfat-utils/exfat-utils.mk
> > +++ b/package/exfat-utils/exfat-utils.mk
> > @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
> >  EXFAT_UTILS_LICENSE = GPL-3.0+
> >  EXFAT_UTILS_LICENSE_FILES = COPYING
> >
> > +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> > +
> >  $(eval $(autotools-package))
> > diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> > index b52b197..0d4f1c9 100644
> > --- a/package/exfat/exfat.mk
> > +++ b/package/exfat/exfat.mk
> > @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
> >  EXFAT_LICENSE_FILES = COPYING
> >  EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
> >
> > +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
>
>  Why not just set --prefix=/ ?
>
>  Regards,
>  Arnout
>
> > +
> >  $(eval $(autotools-package))
> >
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

No, because --prefix=/usr is passed by package/pkg-autotools.mk first
and the additional --prefix=/ is discarded.
Carlos Santos Sept. 22, 2019, 10:37 p.m. UTC | #4
On Sun, Sep 22, 2019 at 7:34 PM Carlos Santos <unixmania@gmail.com> wrote:
>
> On Sat, Sep 21, 2019 at 8:40 AM Arnout Vandecappelle <arnout@mind.be> wrote:
> >
> >
> >
> > On 12/09/2019 09:17, Wolfgang Grandegger wrote:
> > > "mount" from the "util-linux" package does expect the helper utilities
> > > in "/sbin" and not "/usr/sbin".
> > >
> > > Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> > > ---
> > >  package/exfat-utils/exfat-utils.mk | 2 ++
> > >  package/exfat/exfat.mk             | 2 ++
> > >  2 files changed, 4 insertions(+)
> > >
> > > diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
> > > index 62cd471..d22d5c9 100644
> > > --- a/package/exfat-utils/exfat-utils.mk
> > > +++ b/package/exfat-utils/exfat-utils.mk
> > > @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
> > >  EXFAT_UTILS_LICENSE = GPL-3.0+
> > >  EXFAT_UTILS_LICENSE_FILES = COPYING
> > >
> > > +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> > > +
> > >  $(eval $(autotools-package))
> > > diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
> > > index b52b197..0d4f1c9 100644
> > > --- a/package/exfat/exfat.mk
> > > +++ b/package/exfat/exfat.mk
> > > @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
> > >  EXFAT_LICENSE_FILES = COPYING
> > >  EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
> > >
> > > +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
> >
> >  Why not just set --prefix=/ ?
> >
> >  Regards,
> >  Arnout
> >
> > > +
> > >  $(eval $(autotools-package))
> > >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> No, because --prefix=/usr is passed by package/pkg-autotools.mk first
> and the additional --prefix=/ is discarded.

Which by the way reminds me that --prefix=/usr is passed by 46 .mk
packages, which seems to be redundant.
Wolfgang Grandegger Sept. 24, 2019, 7:38 a.m. UTC | #5
Am 23.09.19 um 00:34 schrieb Carlos Santos:
> On Sat, Sep 21, 2019 at 8:40 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>>
>>
>>
>> On 12/09/2019 09:17, Wolfgang Grandegger wrote:
>>> "mount" from the "util-linux" package does expect the helper utilities
>>> in "/sbin" and not "/usr/sbin".
>>>
>>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
>>> ---
>>>  package/exfat-utils/exfat-utils.mk | 2 ++
>>>  package/exfat/exfat.mk             | 2 ++
>>>  2 files changed, 4 insertions(+)
>>>
>>> diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
>>> index 62cd471..d22d5c9 100644
>>> --- a/package/exfat-utils/exfat-utils.mk
>>> +++ b/package/exfat-utils/exfat-utils.mk
>>> @@ -9,4 +9,6 @@ EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
>>>  EXFAT_UTILS_LICENSE = GPL-3.0+
>>>  EXFAT_UTILS_LICENSE_FILES = COPYING
>>>
>>> +EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
>>> +
>>>  $(eval $(autotools-package))
>>> diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
>>> index b52b197..0d4f1c9 100644
>>> --- a/package/exfat/exfat.mk
>>> +++ b/package/exfat/exfat.mk
>>> @@ -12,4 +12,6 @@ EXFAT_LICENSE = GPL-3.0+
>>>  EXFAT_LICENSE_FILES = COPYING
>>>  EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
>>>
>>> +EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
>>
>>  Why not just set --prefix=/ ?
>>
>>  Regards,
>>  Arnout
>>
>>> +
>>>  $(eval $(autotools-package))
>>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> No, because --prefix=/usr is passed by package/pkg-autotools.mk first
> and the additional --prefix=/ is discarded.

Hm, "--prefix=/" works for me!. I'm going to send v2 then.

Wolfgang
Arnout Vandecappelle Sept. 24, 2019, 8:21 p.m. UTC | #6
On 23/09/2019 00:37, Carlos Santos wrote:
> Which by the way reminds me that --prefix=/usr is passed by 46 .mk
> packages, which seems to be redundant.

 Of these, most are not autotools packages so the --prefix is not passed by default.

 And the ones which are autotools packages override CONFIGURE_CMDS.

 I couldn't find any case where the --prefix is redundant.

 But thanks for thinking of this anyway :-)

 Regards,
 Arnout

Patch
diff mbox series

diff --git a/package/exfat-utils/exfat-utils.mk b/package/exfat-utils/exfat-utils.mk
index 62cd471..d22d5c9 100644
--- a/package/exfat-utils/exfat-utils.mk
+++ b/package/exfat-utils/exfat-utils.mk
@@ -9,4 +9,6 @@  EXFAT_UTILS_SITE = https://github.com/relan/exfat/releases/download/v$(EXFAT_UTI
 EXFAT_UTILS_LICENSE = GPL-3.0+
 EXFAT_UTILS_LICENSE_FILES = COPYING
 
+EXFAT_UTILS_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
+
 $(eval $(autotools-package))
diff --git a/package/exfat/exfat.mk b/package/exfat/exfat.mk
index b52b197..0d4f1c9 100644
--- a/package/exfat/exfat.mk
+++ b/package/exfat/exfat.mk
@@ -12,4 +12,6 @@  EXFAT_LICENSE = GPL-3.0+
 EXFAT_LICENSE_FILES = COPYING
 EXFAT_CFLAGS = $(TARGET_CFLAGS) -std=c99
 
+EXFAT_CONF_OPTS += --bindir=/bin --sbindir=/sbin --libdir=/lib
+
 $(eval $(autotools-package))