| Message ID | 1568245042-66967-1-git-send-email-decui@microsoft.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] hv_sock: Add the support of hibernation | expand |
From: Dexuan Cui <decui@microsoft.com> Date: Wed, 11 Sep 2019 23:37:27 +0000 > Add the necessary dummy callbacks for hibernation. > > Signed-off-by: Dexuan Cui <decui@microsoft.com> > --- > This patch is basically a pure Hyper-V specific change and it has a > build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus: Implement > suspend/resume for VSC drivers for hibernation"), which is on Sasha Levin's > Hyper-V tree's hyperv-next branch: > https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/log/?h=hyperv-next > > I request this patch should go through Sasha's tree rather than the > net-next tree. That's fine: Acked-by: David S. Miller <davem@davemloft.net>
> From: David Miller <davem@davemloft.net> > Sent: Friday, September 13, 2019 1:04 PM > > From: Dexuan Cui <decui@microsoft.com> > Date: Wed, 11 Sep 2019 23:37:27 +0000 > > I request this patch should go through Sasha's tree rather than the > > net-next tree. > > That's fine: > > Acked-by: David S. Miller <davem@davemloft.net> Thanks, David! @Sasha: I found a few typos in my comment below. I'll post a v2. > > +/* hv_sock connections can not persist across hibernation, and all the hv_sock > > + * channels are forceed to be rescinded before hibernation: see forceed -> forced > > + * are only needed because hibernation requires that every device's driver every device's driver -> every vmbus device's driver Thanks, -- Dexuan
diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c index f2084e3..e91a884 100644 --- a/net/vmw_vsock/hyperv_transport.c +++ b/net/vmw_vsock/hyperv_transport.c @@ -930,6 +930,24 @@ static int hvs_remove(struct hv_device *hdev) return 0; } +/* hv_sock connections can not persist across hibernation, and all the hv_sock + * channels are forceed to be rescinded before hibernation: see + * vmbus_bus_suspend(). Here the dummy hvs_suspend() and hvs_resume() + * are only needed because hibernation requires that every device's driver + * should have a .suspend and .resume callback: see vmbus_suspend(). + */ +static int hvs_suspend(struct hv_device *hv_dev) +{ + /* Dummy */ + return 0; +} + +static int hvs_resume(struct hv_device *dev) +{ + /* Dummy */ + return 0; +} + /* This isn't really used. See vmbus_match() and vmbus_probe() */ static const struct hv_vmbus_device_id id_table[] = { {}, @@ -941,6 +959,8 @@ static int hvs_remove(struct hv_device *hdev) .id_table = id_table, .probe = hvs_probe, .remove = hvs_remove, + .suspend = hvs_suspend, + .resume = hvs_resume, }; static int __init hvs_init(void)
Add the necessary dummy callbacks for hibernation. Signed-off-by: Dexuan Cui <decui@microsoft.com> --- This patch is basically a pure Hyper-V specific change and it has a build dependency on the commit 271b2224d42f ("Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for hibernation"), which is on Sasha Levin's Hyper-V tree's hyperv-next branch: https://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux.git/log/?h=hyperv-next I request this patch should go through Sasha's tree rather than the net-next tree. net/vmw_vsock/hyperv_transport.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)