From patchwork Wed Sep 11 21:18:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yifeng Sun X-Patchwork-Id: 1161291 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=openvswitch.org (client-ip=140.211.169.12; helo=mail.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Fq4Vt9nd"; dkim-atps=neutral Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46TFCp3LRBz9s00 for ; Thu, 12 Sep 2019 07:19:50 +1000 (AEST) Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id E6BD3D7A; Wed, 11 Sep 2019 21:18:46 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@mail.linuxfoundation.org Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id C3D38B79 for ; Wed, 11 Sep 2019 21:18:44 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.7.6 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7777982B for ; Wed, 11 Sep 2019 21:18:44 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id y72so14463774pfb.12 for ; Wed, 11 Sep 2019 14:18:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wdNX1Kb5JanR6M5zQcpP4INIWHoHyvMSOfZE8oAxwv8=; b=Fq4Vt9nd/T2UzJSzCYJ6J7VttA2LoAHmZmPiW+DUeHEJQEB+sJMc48HcLkruDmGNFU TeVfNlDCUTm7JlMAQPkmN5AUKPmPtx2C7gqHb+yJbgEl0eKh4JND/3KSIzirvtElYIx7 jOmTo5CNf5XGNvbD4BVLnxK47YSWYP51K+/vkTihtHxYJtKh2x93SDWnXksLmzm5/s4a K9nyQGMzdHtRMx3xWIIicanqq8e2JS7Vte6o7z1B6ujRGNZXmE8iF+64dJ1IEG56tpvB xcz4795ueHXuttEua7xWWnvtc+xSWBU8uChWnxqavIUWgZAA8flL++nwm/d/B0cx+/Tw mdMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wdNX1Kb5JanR6M5zQcpP4INIWHoHyvMSOfZE8oAxwv8=; b=P+X+PcEPPaIkp4KgjFekgul7KOS3fYEdH7Nal+StH8Jh8WZSY1FG5ja++MjhSelvCA QROo76j6M/ArLHMqC4x7WVxk0dzGODeLTdREoHFuGrB7U6dWaly8rK/3+7IyD6qmKPv5 bH7XgA5TnYSvuBVhxKd2qWamPrpoQwcFtcPCB5ZVbrUAkNdf/i1bHsZ+N3gvqUzqhQkP Hq+MHd97DfqCI+2YaXty0i+eSz2J2h9UDwbuyA6KcgX6bJQzM0gflplZJAcWe/4kfErb rFrJjwxCdhA6VW4Wjqw7GiP3/mjLecLimPQQjyQ5cNinaO9v31EHhZ61V2Ni4FYPD3SP uV9w== X-Gm-Message-State: APjAAAXA1JwJKiCco3hBmQGbL5uwP+Fou7A5y3uxdZiVGUPJ3hjgnK7j eX9udRBZLlNGDhZ8KfVxVJWY/tTK X-Google-Smtp-Source: APXvYqy17Jwl0F5ZIJLD45PyMWYnIwG7JVFYUMlC2DWONzOwrnENYiedqpcLHmdUhZtH6VpfIJDULg== X-Received: by 2002:a17:90a:de0f:: with SMTP id m15mr7921609pjv.107.1568236723650; Wed, 11 Sep 2019 14:18:43 -0700 (PDT) Received: from kern417.eng.vmware.com ([66.170.99.1]) by smtp.gmail.com with ESMTPSA id k1sm24612487pfi.132.2019.09.11.14.18.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Sep 2019 14:18:43 -0700 (PDT) From: Yifeng Sun To: dev@openvswitch.org Date: Wed, 11 Sep 2019 14:18:29 -0700 Message-Id: <1568236716-18105-3-git-send-email-pkusunyifeng@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1568236716-18105-1-git-send-email-pkusunyifeng@gmail.com> References: <1568236716-18105-1-git-send-email-pkusunyifeng@gmail.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on smtp1.linux-foundation.org Subject: [ovs-dev] [PATCH 03/10] dpif-netdev: Handle uninitialized value error for 'match.wc' X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ovs-dev-bounces@openvswitch.org Errors-To: ovs-dev-bounces@openvswitch.org Valgrind reported that match.wc was not initialized, as below: 1176: ofproto-dpif - fragment handling - actions ==21214== Conditional jump or move depends on uninitialised value(s) ==21214== at 0x4B77C1: odp_flow_key_from_flow__ (odp-util.c:6143) ==21214== by 0x46DB58: dp_netdev_upcall (dpif-netdev.c:6239) ==21214== by 0x4774A7: handle_packet_upcall (dpif-netdev.c:6608) ==21214== by 0x4774A7: fast_path_processing (dpif-netdev.c:6726) ==21214== by 0x47933C: dp_netdev_input__ (dpif-netdev.c:6814) ==21214== by 0x479AB8: dp_netdev_input (dpif-netdev.c:6852) ==21214== by 0x479AB8: dp_netdev_process_rxq_port (dpif-netdev.c:4287) ==21214== by 0x47A6A9: dpif_netdev_run (dpif-netdev.c:5264) ==21214== by 0x4324E7: type_run (ofproto-dpif.c:342) ==21214== by 0x41C5FE: ofproto_type_run (ofproto.c:1734) ==21214== by 0x40BAAC: bridge_run__ (bridge.c:2965) ==21214== by 0x410CF3: bridge_run (bridge.c:3029) ==21214== by 0x407614: main (ovs-vswitchd.c:127) ==21214== Uninitialised value was created by a stack allocation ==21214== at 0x4769C3: fast_path_processing (dpif-netdev.c:6672) 'match' is allocated on stack but its 'wc' is accessed in odp_flow_key_from_flow__ without proper initialization. This patch fixes it. Signed-off-by: Yifeng Sun Acked-by: William Tu --- lib/dpif-netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index a88a78f8a688..6be6e47ed127 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -6600,6 +6600,7 @@ handle_packet_upcall(struct dp_netdev_pmd_thread *pmd, match.tun_md.valid = false; miniflow_expand(&key->mf, &match.flow); + memset(&match.wc, 0, sizeof match.wc); ofpbuf_clear(actions); ofpbuf_clear(put_actions);