[1/1] package/kompexsqlite: fixup the 'v' prefix in the version
diff mbox series

Message ID 20190911172256.30003-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series
  • [1/1] package/kompexsqlite: fixup the 'v' prefix in the version
Related show

Commit Message

Fabrice Fontaine Sept. 11, 2019, 5:22 p.m. UTC
In order for the kompexsqlite version to match what is given by
release-monitoring.org, the 'v' prefix should be encoded in
KOMPEXSQLITE_SOURCE and not KOMPEXSQLITE_VERSION.

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/kompexsqlite/kompexsqlite.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni Sept. 14, 2019, 2:03 p.m. UTC | #1
Hello Fabrice,

On Wed, 11 Sep 2019 19:22:56 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> In order for the kompexsqlite version to match what is given by
> release-monitoring.org, the 'v' prefix should be encoded in
> KOMPEXSQLITE_SOURCE and not KOMPEXSQLITE_VERSION.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

I've applied to master, but I have a comment, see below.

> -KOMPEXSQLITE_VERSION = v1.10.12-1
> -KOMPEXSQLITE_SOURCE = $(KOMPEXSQLITE_VERSION).tar.gz
> +KOMPEXSQLITE_VERSION = 1.10.12-1
> +KOMPEXSQLITE_SOURCE = v$(KOMPEXSQLITE_VERSION).tar.gz
>  KOMPEXSQLITE_SITE = https://github.com/Aethelflaed/kompex-sqlite-wrapper/archive

When I look at
https://github.com/Aethelflaed/kompex-sqlite-wrapper/releases, to me it
seems like only the automatically generated tarballs are there. In such
cases, we should use the github macro instead.

Best regards,

Thomas

Patch
diff mbox series

diff --git a/package/kompexsqlite/kompexsqlite.mk b/package/kompexsqlite/kompexsqlite.mk
index 51b80aa86b..92a4ddc22a 100644
--- a/package/kompexsqlite/kompexsqlite.mk
+++ b/package/kompexsqlite/kompexsqlite.mk
@@ -4,8 +4,8 @@ 
 #
 ################################################################################
 
-KOMPEXSQLITE_VERSION = v1.10.12-1
-KOMPEXSQLITE_SOURCE = $(KOMPEXSQLITE_VERSION).tar.gz
+KOMPEXSQLITE_VERSION = 1.10.12-1
+KOMPEXSQLITE_SOURCE = v$(KOMPEXSQLITE_VERSION).tar.gz
 KOMPEXSQLITE_SITE = https://github.com/Aethelflaed/kompex-sqlite-wrapper/archive
 KOMPEXSQLITE_INSTALL_STAGING = YES
 KOMPEXSQLITE_LICENSE = LGPL-3.0+ (wrapper), Public Domain (bundled sqlite)