Patchwork [U-Boot,v2] zmx25: Fix build warning due to 'get_reset_cause' defined but not used

login
register
mail settings
Submitter Fabio Estevam
Date Sept. 23, 2011, 2:16 p.m.
Message ID <1316787411-11758-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/116086/
State Changes Requested
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Sept. 23, 2011, 2:16 p.m.
When building the zmx25 target we get:

Configuring for zmx25 board...
generic.c:108: warning: 'get_reset_cause' defined but not used

Fix this warning by defining get_reset_cause only if CONFIG_DISPLAY_CPUINFO is defined.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:

- Only define get_reset_cause when CONFIG_DISPLAY_CPUINFO is defined.

 arch/arm/cpu/arm926ejs/mx25/generic.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Stefano Babic - Sept. 23, 2011, 2:23 p.m.
On 09/23/2011 04:16 PM, Fabio Estevam wrote:
> When building the zmx25 target we get:
> 
> Configuring for zmx25 board...
> generic.c:108: warning: 'get_reset_cause' defined but not used
> 
> Fix this warning by defining get_reset_cause only if CONFIG_DISPLAY_CPUINFO is defined.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> 
> - Only define get_reset_cause when CONFIG_DISPLAY_CPUINFO is defined.
> 
>  arch/arm/cpu/arm926ejs/mx25/generic.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mx25/generic.c b/arch/arm/cpu/arm926ejs/mx25/generic.c
> index 1261640..91b04c1 100644
> --- a/arch/arm/cpu/arm926ejs/mx25/generic.c
> +++ b/arch/arm/cpu/arm926ejs/mx25/generic.c
> @@ -105,6 +105,7 @@ ulong imx_get_perclk (int clk)
>  	return lldiv (fref, div);
>  }
>  
> +#if defined(CONFIG_DISPLAY_CPUINFO)
>  static char *get_reset_cause(void)
>  {
>  	/* read RCSR register from CCM module */
> @@ -127,6 +128,7 @@ static char *get_reset_cause(void)
>  		return "unknown reset";
>  
>  }
> +#endif
>  

I know it does not change how it works...but should be not better to
move the get_reset_cause() function where the CONFIG_DISPLAY_CPUINFO is
already active ? I mean, before the print_cpuinfo() function ? This
enforces that the two functions are not disjuncted. I know this is only
a question of taste, what do you think about it ?

Stefano

Patch

diff --git a/arch/arm/cpu/arm926ejs/mx25/generic.c b/arch/arm/cpu/arm926ejs/mx25/generic.c
index 1261640..91b04c1 100644
--- a/arch/arm/cpu/arm926ejs/mx25/generic.c
+++ b/arch/arm/cpu/arm926ejs/mx25/generic.c
@@ -105,6 +105,7 @@  ulong imx_get_perclk (int clk)
 	return lldiv (fref, div);
 }
 
+#if defined(CONFIG_DISPLAY_CPUINFO)
 static char *get_reset_cause(void)
 {
 	/* read RCSR register from CCM module */
@@ -127,6 +128,7 @@  static char *get_reset_cause(void)
 		return "unknown reset";
 
 }
+#endif
 
 u32 get_cpu_rev(void)
 {