diff mbox series

[U-Boot] arm64: versal: Fix for OCM overwriting issue

Message ID 2ca554a2340a555ed97384abbf1a8ac6efea5db9.1568191958.git.michal.simek@xilinx.com
State Accepted
Commit a85f388565063404ec6cd8b908094c0e3e6472e3
Delegated to: Michal Simek
Headers show
Series [U-Boot] arm64: versal: Fix for OCM overwriting issue | expand

Commit Message

Michal Simek Sept. 11, 2019, 8:52 a.m. UTC 
From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>

This patch reduces the console buffer size from 2048 to 1024, thus fixes
OCM overwriting issue.

Differences are in bss section as is shown from output:
xilinx_versal_mini: all -2056 bss -2048 text -8
   u-boot: add: 0/0, grow: 0/-3 bytes: 0/-2056 (-2056)
     function                                   old     new   delta
     cli_simple_run_command                     340     332      -8
     static.lastcommand                        2049    1025   -1024
     console_buffer                            2049    1025   -1024

Better would be to use PPU RAM but this change is also aligned with changes
done in ZynqMP mini configurations.

Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 include/configs/xilinx_versal_mini.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Michal Simek Oct. 8, 2019, 7:44 a.m. UTC | #1 
st 11. 9. 2019 v 10:52 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> From: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
>
> This patch reduces the console buffer size from 2048 to 1024, thus fixes
> OCM overwriting issue.
>
> Differences are in bss section as is shown from output:
> xilinx_versal_mini: all -2056 bss -2048 text -8
>    u-boot: add: 0/0, grow: 0/-3 bytes: 0/-2056 (-2056)
>      function                                   old     new   delta
>      cli_simple_run_command                     340     332      -8
>      static.lastcommand                        2049    1025   -1024
>      console_buffer                            2049    1025   -1024
>
> Better would be to use PPU RAM but this change is also aligned with changes
> done in ZynqMP mini configurations.
>
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  include/configs/xilinx_versal_mini.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/configs/xilinx_versal_mini.h b/include/configs/xilinx_versal_mini.h
> index 4b3691b40733..2195bf0e1064 100644
> --- a/include/configs/xilinx_versal_mini.h
> +++ b/include/configs/xilinx_versal_mini.h
> @@ -29,4 +29,7 @@
>  #undef CONFIG_BOOTP_BOOTFILESIZE
>  #undef CONFIG_BOOTP_MAY_FAIL
>
> +#undef CONFIG_SYS_CBSIZE
> +#define CONFIG_SYS_CBSIZE              1024
> +
>  #endif /* __CONFIG_VERSAL_MINI_H */
> --
> 2.17.1
>

Applied.
M
diff mbox series

Patch

diff --git a/include/configs/xilinx_versal_mini.h b/include/configs/xilinx_versal_mini.h
index 4b3691b40733..2195bf0e1064 100644
--- a/include/configs/xilinx_versal_mini.h
+++ b/include/configs/xilinx_versal_mini.h
@@ -29,4 +29,7 @@ 
 #undef CONFIG_BOOTP_BOOTFILESIZE
 #undef CONFIG_BOOTP_MAY_FAIL
 
+#undef CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_CBSIZE		1024
+
 #endif /* __CONFIG_VERSAL_MINI_H */