Patchwork [U-Boot,2/5,V4] NAND: Add nand read.raw and write.raw commands

login
register
mail settings
Submitter Marek Vasut
Date Sept. 23, 2011, 1:43 p.m.
Message ID <1316785390-17006-1-git-send-email-marek.vasut@gmail.com>
Download mbox | patch
Permalink /patch/116074/
State Accepted
Delegated to: Scott Wood
Headers show

Comments

Marek Vasut - Sept. 23, 2011, 1:43 p.m.
These commands should work around various "hardware" ECC and BCH methods.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
---
 common/cmd_nand.c |   19 +++++++++++++++++++
 doc/README.nand   |    9 +++++++++
 2 files changed, 28 insertions(+), 0 deletions(-)

V2: Add documentation.
V3: Drop size param.
V4: Dont drop size of read/write commands, operate on pages
Scott Wood - Sept. 27, 2011, 6:57 p.m.
On Fri, Sep 23, 2011 at 03:43:10PM +0200, Marek Vasut wrote:
> These commands should work around various "hardware" ECC and BCH methods.
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Detlev Zundel <dzu@denx.de>
> ---
>  common/cmd_nand.c |   19 +++++++++++++++++++
>  doc/README.nand   |    9 +++++++++
>  2 files changed, 28 insertions(+), 0 deletions(-)
> 
> V2: Add documentation.
> V3: Drop size param.
> V4: Dont drop size of read/write commands, operate on pages

Applied to u-boot-nand-flash next

> +	"nand read.raw - addr off|partition\n"
> +	"nand write.raw - addr off|partition\n"
> +	"    Use read.raw/write.raw to avoid ECC and write the page as-is.\n"

...with s/write the page/access the page/

-Scott

Patch

diff --git a/common/cmd_nand.c b/common/cmd_nand.c
index 66e06a5..14c7c09 100644
--- a/common/cmd_nand.c
+++ b/common/cmd_nand.c
@@ -606,6 +606,22 @@  int do_nand(cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 				ret = nand->read_oob(nand, off, &ops);
 			else
 				ret = nand->write_oob(nand, off, &ops);
+		} else if (!strcmp(s, ".raw")) {
+			/* Raw access */
+			mtd_oob_ops_t ops = {
+				.datbuf = (u8 *)addr,
+				.oobbuf = ((u8 *)addr) + nand->writesize,
+				.len = nand->writesize,
+				.ooblen = nand->oobsize,
+				.mode = MTD_OOB_RAW
+			};
+
+			rwsize = nand->writesize + nand->oobsize;
+
+			if (read)
+				ret = nand->read_oob(nand, off, &ops);
+			else
+				ret = nand->write_oob(nand, off, &ops);
 		} else {
 			printf("Unknown nand command suffix '%s'.\n", s);
 			return 1;
@@ -699,6 +715,9 @@  U_BOOT_CMD(
 	"nand write - addr off|partition size\n"
 	"    read/write 'size' bytes starting at offset 'off'\n"
 	"    to/from memory address 'addr', skipping bad blocks.\n"
+	"nand read.raw - addr off|partition\n"
+	"nand write.raw - addr off|partition\n"
+	"    Use read.raw/write.raw to avoid ECC and write the page as-is.\n"
 #ifdef CONFIG_CMD_NAND_TRIMFFS
 	"nand write.trimffs - addr off|partition size\n"
 	"    write 'size' bytes starting at offset 'off' from memory address\n"
diff --git a/doc/README.nand b/doc/README.nand
index 751b693..023740e 100644
--- a/doc/README.nand
+++ b/doc/README.nand
@@ -94,6 +94,15 @@  Commands:
       of data for one 512-byte page or 2 256-byte pages. There is no check
       for bad blocks.
 
+   nand read.raw addr ofs|partition
+      Read page from `ofs' in NAND flash to `addr'. This reads the raw page,
+      so ECC is avoided and the OOB area is read as well.
+
+   nand write.raw addr ofs|partition
+      Write page from `addr' to `ofs' in NAND flash. This writes the raw page,
+      so ECC is avoided and the OOB area is written as well, making the whole
+      page written as-is.
+
 Configuration Options:
 
    CONFIG_CMD_NAND