| Message ID | f4e59fe8-647f-fe44-da32-e5d890503d2a@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [AArch64] Update hwcap string for fp16fml in aarch64-option-extensions.def | expand |
Hi all, On 9/10/19 1:34 PM, Stam Markianos-Wright wrote: > > Hi all, > > This is a minor patch that fixes the entry for the fp16fml feature in > GCC's aarch64-option-extensions.def. > > As can be seen in the Linux sources here > https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L69 > > the correct string is "asimdfhm", not "asimdfml". > > Cross-compiled and tested on aarch64-none-linux-gnu. > > Is this ok for trunk? > > Also, I don't have commit rights, so could someone commit it on my behalf? > James approved it offline so I've committed it on Stam's behalf as r276097 with a slightly adjusted ChangeLog: 2019-09-24 Stamatis Markianos-Wright <stam.markianos-wright@arm.com> * config/aarch64/aarch64-option-extensions.def (fp16fml): Update hwcap string for fp16fml. Thanks, Kyrill > Thanks, > Stam Markianos-Wright > > > The diff is: > > diff --git a/gcc/config/aarch64/aarch64-option-extensions.def > b/gcc/config/aarch64/aarch64-option-extensions.def > index 9919edd43d0..60e8f28fff5 100644 > --- a/gcc/config/aarch64/aarch64-option-extensions.def > +++ b/gcc/config/aarch64/aarch64-option-extensions.def > @@ -135,7 +135,7 @@ AARCH64_OPT_EXTENSION("sm4", AARCH64_FL_SM4, > AARCH64_FL_SIMD, \ > /* Enabling "fp16fml" also enables "fp" and "fp16". > Disabling "fp16fml" just disables "fp16fml". */ > AARCH64_OPT_EXTENSION("fp16fml", AARCH64_FL_F16FML, \ > - AARCH64_FL_FP | AARCH64_FL_F16, 0, false, "asimdfml") > + AARCH64_FL_FP | AARCH64_FL_F16, 0, false, "asimdfhm") > > /* Enabling "sve" also enables "fp16", "fp" and "simd". > Disabling "sve" disables "sve", "sve2", "sve2-aes", "sve2-sha3", > "sve2-sm4" > > > > gcc/ChangeLog: > > 2019-09-09 Stamatis Markianos-Wright <stam.markianos-wright@arm.com> > > * config/aarch64/aarch64-option-extensions.def: Updated hwcap > string for fp16fml. > >
OK to backport to GCC 9? Thanks, Tamar > -----Original Message----- > From: gcc-patches-owner@gcc.gnu.org <gcc-patches-owner@gcc.gnu.org> > On Behalf Of Kyrill Tkachov > Sent: Tuesday, September 24, 2019 14:32 > To: Stam Markianos-Wright <Stam.Markianos-Wright@arm.com>; gcc- > patches@gcc.gnu.org > Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>; > James Greenhalgh <James.Greenhalgh@arm.com>; Marcus Shawcroft > <Marcus.Shawcroft@arm.com> > Subject: Re: [GCC][PATCH][AArch64] Update hwcap string for fp16fml in > aarch64-option-extensions.def > > Hi all, > > On 9/10/19 1:34 PM, Stam Markianos-Wright wrote: > > > > Hi all, > > > > This is a minor patch that fixes the entry for the fp16fml feature in > > GCC's aarch64-option-extensions.def. > > > > As can be seen in the Linux sources here > > https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinf > > o.c#L69 > > > > the correct string is "asimdfhm", not "asimdfml". > > > > Cross-compiled and tested on aarch64-none-linux-gnu. > > > > Is this ok for trunk? > > > > Also, I don't have commit rights, so could someone commit it on my behalf? > > > James approved it offline so I've committed it on Stam's behalf as > r276097 with a slightly adjusted ChangeLog: > > 2019-09-24 Stamatis Markianos-Wright <stam.markianos-wright@arm.com> > > * config/aarch64/aarch64-option-extensions.def (fp16fml): > Update hwcap string for fp16fml. > > Thanks, > > Kyrill > > > Thanks, > > Stam Markianos-Wright > > > > > > The diff is: > > > > diff --git a/gcc/config/aarch64/aarch64-option-extensions.def > > b/gcc/config/aarch64/aarch64-option-extensions.def > > index 9919edd43d0..60e8f28fff5 100644 > > --- a/gcc/config/aarch64/aarch64-option-extensions.def > > +++ b/gcc/config/aarch64/aarch64-option-extensions.def > > @@ -135,7 +135,7 @@ AARCH64_OPT_EXTENSION("sm4", > AARCH64_FL_SM4, > > AARCH64_FL_SIMD, \ > > /* Enabling "fp16fml" also enables "fp" and "fp16". > > Disabling "fp16fml" just disables "fp16fml". */ > > AARCH64_OPT_EXTENSION("fp16fml", AARCH64_FL_F16FML, \ > > - AARCH64_FL_FP | AARCH64_FL_F16, 0, false, "asimdfml") > > + AARCH64_FL_FP | AARCH64_FL_F16, 0, false, "asimdfhm") > > > > /* Enabling "sve" also enables "fp16", "fp" and "simd". > > Disabling "sve" disables "sve", "sve2", "sve2-aes", "sve2-sha3", > > "sve2-sm4" > > > > > > > > gcc/ChangeLog: > > > > 2019-09-09 Stamatis Markianos-Wright <stam.markianos-wright@arm.com> > > > > * config/aarch64/aarch64-option-extensions.def: Updated hwcap > > string for fp16fml. > > > >
On 11/18/19 12:54 PM, Tamar Christina wrote: > OK to backport to GCC 9? Yes. Thanks, Kyrill > Thanks, > Tamar > >> -----Original Message----- >> From: gcc-patches-owner@gcc.gnu.org <gcc-patches-owner@gcc.gnu.org> >> On Behalf Of Kyrill Tkachov >> Sent: Tuesday, September 24, 2019 14:32 >> To: Stam Markianos-Wright <Stam.Markianos-Wright@arm.com>; gcc- >> patches@gcc.gnu.org >> Cc: nd <nd@arm.com>; Richard Earnshaw <Richard.Earnshaw@arm.com>; >> James Greenhalgh <James.Greenhalgh@arm.com>; Marcus Shawcroft >> <Marcus.Shawcroft@arm.com> >> Subject: Re: [GCC][PATCH][AArch64] Update hwcap string for fp16fml in >> aarch64-option-extensions.def >> >> Hi all, >> >> On 9/10/19 1:34 PM, Stam Markianos-Wright wrote: >>> Hi all, >>> >>> This is a minor patch that fixes the entry for the fp16fml feature in >>> GCC's aarch64-option-extensions.def. >>> >>> As can be seen in the Linux sources here >>> https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinf >>> o.c#L69 >>> >>> the correct string is "asimdfhm", not "asimdfml". >>> >>> Cross-compiled and tested on aarch64-none-linux-gnu. >>> >>> Is this ok for trunk? >>> >>> Also, I don't have commit rights, so could someone commit it on my behalf? >>> >> James approved it offline so I've committed it on Stam's behalf as >> r276097 with a slightly adjusted ChangeLog: >> >> 2019-09-24 Stamatis Markianos-Wright <stam.markianos-wright@arm.com> >> >> * config/aarch64/aarch64-option-extensions.def (fp16fml): >> Update hwcap string for fp16fml. >> >> Thanks, >> >> Kyrill >> >>> Thanks, >>> Stam Markianos-Wright >>> >>> >>> The diff is: >>> >>> diff --git a/gcc/config/aarch64/aarch64-option-extensions.def >>> b/gcc/config/aarch64/aarch64-option-extensions.def >>> index 9919edd43d0..60e8f28fff5 100644 >>> --- a/gcc/config/aarch64/aarch64-option-extensions.def >>> +++ b/gcc/config/aarch64/aarch64-option-extensions.def >>> @@ -135,7 +135,7 @@ AARCH64_OPT_EXTENSION("sm4", >> AARCH64_FL_SM4, >>> AARCH64_FL_SIMD, \ >>> /* Enabling "fp16fml" also enables "fp" and "fp16". >>> Disabling "fp16fml" just disables "fp16fml". */ >>> AARCH64_OPT_EXTENSION("fp16fml", AARCH64_FL_F16FML, \ >>> - AARCH64_FL_FP | AARCH64_FL_F16, 0, false, "asimdfml") >>> + AARCH64_FL_FP | AARCH64_FL_F16, 0, false, "asimdfhm") >>> >>> /* Enabling "sve" also enables "fp16", "fp" and "simd". >>> Disabling "sve" disables "sve", "sve2", "sve2-aes", "sve2-sha3", >>> "sve2-sm4" >>> >>> >>> >>> gcc/ChangeLog: >>> >>> 2019-09-09 Stamatis Markianos-Wright <stam.markianos-wright@arm.com> >>> >>> * config/aarch64/aarch64-option-extensions.def: Updated hwcap >>> string for fp16fml. >>> >>>
diff --git a/gcc/config/aarch64/aarch64-option-extensions.def b/gcc/config/aarch64/aarch64-option-extensions.def index 9919edd43d0..60e8f28fff5 100644 --- a/gcc/config/aarch64/aarch64-option-extensions.def +++ b/gcc/config/aarch64/aarch64-option-extensions.def @@ -135,7 +135,7 @@ AARCH64_OPT_EXTENSION("sm4", AARCH64_FL_SM4, AARCH64_FL_SIMD, \ /* Enabling "fp16fml" also enables "fp" and "fp16". Disabling "fp16fml" just disables "fp16fml". */ AARCH64_OPT_EXTENSION("fp16fml", AARCH64_FL_F16FML, \ - AARCH64_FL_FP | AARCH64_FL_F16, 0, false, "asimdfml") + AARCH64_FL_FP | AARCH64_FL_F16, 0, false, "asimdfhm") /* Enabling "sve" also enables "fp16", "fp" and "simd". Disabling "sve" disables "sve", "sve2", "sve2-aes", "sve2-sha3", "sve2-sm4"
Hi all, This is a minor patch that fixes the entry for the fp16fml feature in GCC's aarch64-option-extensions.def. As can be seen in the Linux sources here https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/cpuinfo.c#L69 the correct string is "asimdfhm", not "asimdfml". Cross-compiled and tested on aarch64-none-linux-gnu. Is this ok for trunk? Also, I don't have commit rights, so could someone commit it on my behalf? Thanks, Stam Markianos-Wright The diff is: Disabling "sve" disables "sve", "sve2", "sve2-aes", "sve2-sha3", "sve2-sm4" gcc/ChangeLog: 2019-09-09 Stamatis Markianos-Wright <stam.markianos-wright@arm.com> * config/aarch64/aarch64-option-extensions.def: Updated hwcap string for fp16fml.