diff mbox series

[SRU,B/D,linux-signed] UBUNTU: fix vmlinuz-* permissions for opal signed kernels

Message ID 20190909193719.28893-1-cascardo@canonical.com
State New
Headers show
Series [SRU,B/D,linux-signed] UBUNTU: fix vmlinuz-* permissions for opal signed kernels | expand

Commit Message

Thadeu Lima de Souza Cascardo Sept. 9, 2019, 7:37 p.m. UTC
From: Seth Forshee <seth.forshee@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1843327

We're currently changing the permissions on the signature file
instead of the concatenated kernel+signature file which will be
installed. Fix this.

Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
---
 debian/rules | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Kleber Sacilotto de Souza Sept. 24, 2019, 2:14 p.m. UTC | #1
On 09.09.19 21:37, Thadeu Lima de Souza Cascardo wrote:
> From: Seth Forshee <seth.forshee@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1843327
> 
> We're currently changing the permissions on the signature file
> instead of the concatenated kernel+signature file which will be
> installed. Fix this.
> 
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  debian/rules | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/debian/rules b/debian/rules
> index 62c132c83ba4..f11e4455f907 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -49,10 +49,10 @@ override_dh_auto_build:
>  		done;								\
>  		for s in *.opal.sig; do						\
>  			[ ! -f "$$s" ] && continue;				\
> -			chmod 600 "$$s";					\
>  			base=$$(echo "$$s" | sed -e 's/.opal.sig//');		\
> -			cat "$$base.opal" "$$s" >"../SIGNED/$$base";\
> -		done								\
> +			cat "$$base.opal" "$$s" >"../SIGNED/$$base";		\
> +			chmod 600 "../SIGNED/$$base";				\
> +		done;								\
>  	)
>  
>  override_dh_auto_install:
>
Sultan Alsawaf Sept. 25, 2019, 3:40 p.m. UTC | #2
On Mon, Sep 09, 2019 at 04:37:19PM -0300, Thadeu Lima de Souza Cascardo wrote:
> From: Seth Forshee <seth.forshee@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1843327
> 
> We're currently changing the permissions on the signature file
> instead of the concatenated kernel+signature file which will be
> installed. Fix this.
> 
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
>  debian/rules | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/debian/rules b/debian/rules
> index 62c132c83ba4..f11e4455f907 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -49,10 +49,10 @@ override_dh_auto_build:
>  		done;								\
>  		for s in *.opal.sig; do						\
>  			[ ! -f "$$s" ] && continue;				\
> -			chmod 600 "$$s";					\
>  			base=$$(echo "$$s" | sed -e 's/.opal.sig//');		\
> -			cat "$$base.opal" "$$s" >"../SIGNED/$$base";\
> -		done								\
> +			cat "$$base.opal" "$$s" >"../SIGNED/$$base";		\
> +			chmod 600 "../SIGNED/$$base";				\
> +		done;								\
>  	)
>  
>  override_dh_auto_install:
> -- 
> 2.20.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com>
Kleber Sacilotto de Souza Sept. 27, 2019, 1:05 p.m. UTC | #3
On 09.09.19 21:37, Thadeu Lima de Souza Cascardo wrote:
> From: Seth Forshee <seth.forshee@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1843327
> 
> We're currently changing the permissions on the signature file
> instead of the concatenated kernel+signature file which will be
> installed. Fix this.
> 
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
> ---
>  debian/rules | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/debian/rules b/debian/rules
> index 62c132c83ba4..f11e4455f907 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -49,10 +49,10 @@ override_dh_auto_build:
>  		done;								\
>  		for s in *.opal.sig; do						\
>  			[ ! -f "$$s" ] && continue;				\
> -			chmod 600 "$$s";					\
>  			base=$$(echo "$$s" | sed -e 's/.opal.sig//');		\
> -			cat "$$base.opal" "$$s" >"../SIGNED/$$base";\
> -		done								\
> +			cat "$$base.opal" "$$s" >"../SIGNED/$$base";		\
> +			chmod 600 "../SIGNED/$$base";				\
> +		done;								\
>  	)
>  
>  override_dh_auto_install:
> 

Applied to bionic/linux-signed/master and disco/linux-signed/master
branches.

Thanks,
Kleber
diff mbox series

Patch

diff --git a/debian/rules b/debian/rules
index 62c132c83ba4..f11e4455f907 100755
--- a/debian/rules
+++ b/debian/rules
@@ -49,10 +49,10 @@  override_dh_auto_build:
 		done;								\
 		for s in *.opal.sig; do						\
 			[ ! -f "$$s" ] && continue;				\
-			chmod 600 "$$s";					\
 			base=$$(echo "$$s" | sed -e 's/.opal.sig//');		\
-			cat "$$base.opal" "$$s" >"../SIGNED/$$base";\
-		done								\
+			cat "$$base.opal" "$$s" >"../SIGNED/$$base";		\
+			chmod 600 "../SIGNED/$$base";				\
+		done;								\
 	)
 
 override_dh_auto_install: