[v2] package/minimodem: new package
diff mbox series

Message ID 20190909182345.1615-1-user@vserver64
State Accepted
Headers show
Series
  • [v2] package/minimodem: new package
Related show

Commit Message

Alexander Kurz Sept. 9, 2019, 6:23 p.m. UTC
From: Alexander Kurz <akurz@blala.de>

Minimodem is a command-line program which decodes (or generates)
audio modem tones at any specified baud rate, using various
framing protocols. It acts a general-purpose software FSK modem,
and includes support for various standard FSK protocols such as
Bell103, Bell202, RTTY, TTY/TDD NOAA SAME, and Caller-ID.

Signed-off-by: Alexander Kurz <akurz@blala.de>

---
Changes v1 -> v2:
  - add libfftw-single dependency (suggested by Arnout Vandecappelle)
  - remove obsolete select BR2_PACKAGE_FFTW
  - add pkg-dependency to libsndfile, alsa or pulseaudio, at least
    one is required to build minimodem
  - remove default value of _SOURCE variable fixes check-package warn

Changes v0 -> v1:
  - add optinal package dependencies
  - add DEVELOPERS entry (suggested by Arnout Vandecappelle)

Signed-off-by: Alexander Kurz <akurz@blala.de>
---
 DEVELOPERS                       |  3 +++
 package/Config.in                |  1 +
 package/minimodem/Config.in      | 14 ++++++++++++++
 package/minimodem/minimodem.hash |  2 ++
 package/minimodem/minimodem.mk   | 35 +++++++++++++++++++++++++++++++++++
 5 files changed, 55 insertions(+)
 create mode 100644 package/minimodem/Config.in
 create mode 100644 package/minimodem/minimodem.hash
 create mode 100644 package/minimodem/minimodem.mk

Comments

Thomas Petazzoni Sept. 11, 2019, 1:52 p.m. UTC | #1
Hello Alexander,

On Mon,  9 Sep 2019 18:23:45 +0000
Alexander Kurz <akurz@blala.de> wrote:

> diff --git a/package/minimodem/Config.in b/package/minimodem/Config.in
> new file mode 100644
> index 0000000000..9d2afd6798
> --- /dev/null
> +++ b/package/minimodem/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_MINIMODEM
> +	select BR2_PACKAGE_FFTW_SINGLE
> +	depends on BR2_PACKAGE_LIBSNDFILE || BR2_PACKAGE_ALSA_LIB_PCM || \
> +		BR2_PACKAGE_PULSEAUDIO

I changed this to a select, as was initially suggested by Arnout.

> +	bool "minimodem"

The bool statement should be before the select/depends on. This is just
a Buildroot rule, so that we do things consistently between packages. I
think it is reported by "make check-package".

> +MINIMODEM_DEPENDENCIES += fftw-single

A dependency on host-pkgconf was missing here.

I fixed those different issues, and applied. Thanks a lot for your
contribution!

Best regards,

Thomas

Patch
diff mbox series

diff --git a/DEVELOPERS b/DEVELOPERS
index 5784843e33..47a1136f03 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -103,6 +103,9 @@  F:	package/fastd/
 F:	package/libuecc/
 F:	package/putty/
 
+N:	Alexander Kurz <akurz@blala.de>
+F:	package/minimodem/
+
 N:	Alexander Lukichev <alexander.lukichev@espotel.com>
 F:	package/openpgm/
 
diff --git a/package/Config.in b/package/Config.in
index 9336261c5d..7d915ea4d7 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -32,6 +32,7 @@  menu "Audio and video applications"
 	source "package/lame/Config.in"
 	source "package/madplay/Config.in"
 	source "package/mimic/Config.in"
+	source "package/minimodem/Config.in"
 	source "package/miraclecast/Config.in"
 	source "package/mjpegtools/Config.in"
 	source "package/modplugtools/Config.in"
diff --git a/package/minimodem/Config.in b/package/minimodem/Config.in
new file mode 100644
index 0000000000..9d2afd6798
--- /dev/null
+++ b/package/minimodem/Config.in
@@ -0,0 +1,14 @@ 
+config BR2_PACKAGE_MINIMODEM
+	select BR2_PACKAGE_FFTW_SINGLE
+	depends on BR2_PACKAGE_LIBSNDFILE || BR2_PACKAGE_ALSA_LIB_PCM || \
+		BR2_PACKAGE_PULSEAUDIO
+	bool "minimodem"
+	help
+	  Minimodem is a command-line program which decodes (or
+	  generates) audio modem tones at any specified baud rate,
+	  using various framing protocols. It acts a general-purpose
+	  software FSK modem, and includes support for various
+	  standard FSK protocols such as Bell103, Bell202, RTTY,
+	  TTY/TDD NOAA SAME, and Caller-ID.
+
+	  http://www.whence.com/minimodem/
diff --git a/package/minimodem/minimodem.hash b/package/minimodem/minimodem.hash
new file mode 100644
index 0000000000..084a5606fb
--- /dev/null
+++ b/package/minimodem/minimodem.hash
@@ -0,0 +1,2 @@ 
+sha256 f8cca4db8e3f284d67f843054d6bb4d88a3db5e77b26192410e41e9a06f4378e  minimodem-0.24.tar.gz
+sha256 c298178753129680ef6d3112f0f8b61acc405c86c1997dfe59735257988f8b33  COPYING
diff --git a/package/minimodem/minimodem.mk b/package/minimodem/minimodem.mk
new file mode 100644
index 0000000000..0ddce41856
--- /dev/null
+++ b/package/minimodem/minimodem.mk
@@ -0,0 +1,35 @@ 
+################################################################################
+#
+# minimodem
+#
+################################################################################
+
+MINIMODEM_VERSION = 0.24
+MINIMODEM_SITE = http://www.whence.com/minimodem
+MINIMODEM_LICENSE = GPL-3.0+
+MINIMODEM_LICENSE_FILES = COPYING
+
+MINIMODEM_DEPENDENCIES += fftw-single
+
+ifeq ($(BR2_PACKAGE_ALSA_LIB_PCM),y)
+MINIMODEM_DEPENDENCIES += alsa-lib
+MINIMODEM_CONF_OPTS += --with-alsa
+else
+MINIMODEM_CONF_OPTS += --without-alsa
+endif
+
+ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
+MINIMODEM_DEPENDENCIES += pulseaudio
+MINIMODEM_CONF_OPTS += --with-pulseaudio
+else
+MINIMODEM_CONF_OPTS += --without-pulseaudio
+endif
+
+ifeq ($(BR2_PACKAGE_LIBSNDFILE),y)
+MINIMODEM_DEPENDENCIES += libsndfile
+MINIMODEM_CONF_OPTS += --with-sndfile
+else
+MINIMODEM_CONF_OPTS += --without-sndfile
+endif
+
+$(eval $(autotools-package))