Patchwork [U-Boot,10/13] mx53loco: Place machine ID into board config

login
register
mail settings
Submitter Fabio Estevam
Date Sept. 22, 2011, 6:07 p.m.
Message ID <1316714842-18271-10-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/115983/
State Accepted
Commit 9df82896c5cbd896ceb78af49d061221ced959e8
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - Sept. 22, 2011, 6:07 p.m.
Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx53loco/mx53loco.c |    1 -
 include/configs/mx53loco.h          |    2 ++
 2 files changed, 2 insertions(+), 1 deletions(-)
Stefano Babic - Sept. 23, 2011, 8:30 a.m.
On 09/22/2011 08:07 PM, Fabio Estevam wrote:
> Let common code set the machine ID.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx53loco/mx53loco.c |    1 -
>  include/configs/mx53loco.h          |    2 ++
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c
> index ade1006..156f8b5 100644
> --- a/board/freescale/mx53loco/mx53loco.c
> +++ b/board/freescale/mx53loco/mx53loco.c
> @@ -288,7 +288,6 @@ int board_early_init_f(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_arch_number = MACH_TYPE_MX53_LOCO;
>  	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
>  
>  	return 0;
> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
> index cfb38a5..4091703 100644
> --- a/include/configs/mx53loco.h
> +++ b/include/configs/mx53loco.h
> @@ -30,6 +30,8 @@
>  #define CONFIG_DISPLAY_CPUINFO
>  #define CONFIG_DISPLAY_BOARDINFO
>  
> +#define CONFIG_MACH_TYPE	MACH_TYPE_MX53_LOCO
> +
>  #include <asm/arch/imx-regs.h>
>  
>  #define CONFIG_CMDLINE_TAG


No problem with the patch, but it should be sent to the board
maintainer,too (Jason, in CC).

Best regards,
Stefano Babic
Jason Liu - Sept. 23, 2011, 8:42 a.m.
On Fri, Sep 23, 2011 at 4:30 PM, Stefano Babic <sbabic@denx.de> wrote:
> On 09/22/2011 08:07 PM, Fabio Estevam wrote:
>> Let common code set the machine ID.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

As Stefano said, please Cc me here.

>> ---
>>  board/freescale/mx53loco/mx53loco.c |    1 -
>>  include/configs/mx53loco.h          |    2 ++
>>  2 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c
>> index ade1006..156f8b5 100644
>> --- a/board/freescale/mx53loco/mx53loco.c
>> +++ b/board/freescale/mx53loco/mx53loco.c
>> @@ -288,7 +288,6 @@ int board_early_init_f(void)
>>
>>  int board_init(void)
>>  {
>> -     gd->bd->bi_arch_number = MACH_TYPE_MX53_LOCO;
>>       gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
>>
>>       return 0;
>> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
>> index cfb38a5..4091703 100644
>> --- a/include/configs/mx53loco.h
>> +++ b/include/configs/mx53loco.h
>> @@ -30,6 +30,8 @@
>>  #define CONFIG_DISPLAY_CPUINFO
>>  #define CONFIG_DISPLAY_BOARDINFO
>>
>> +#define CONFIG_MACH_TYPE     MACH_TYPE_MX53_LOCO
>> +
>>  #include <asm/arch/imx-regs.h>
>>
>>  #define CONFIG_CMDLINE_TAG
>
>
> No problem with the patch, but it should be sent to the board
> maintainer,too (Jason, in CC).
+1, please

Acked-by: Jason Liu <jason.hui@linaro.org>

>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
> =====================================================================
>
Stefano Babic - Sept. 23, 2011, 8:54 a.m.
On 09/22/2011 08:07 PM, Fabio Estevam wrote:
> Let common code set the machine ID.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx53loco/mx53loco.c |    1 -
>  include/configs/mx53loco.h          |    2 ++
>  2 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c
> index ade1006..156f8b5 100644
> --- a/board/freescale/mx53loco/mx53loco.c
> +++ b/board/freescale/mx53loco/mx53loco.c
> @@ -288,7 +288,6 @@ int board_early_init_f(void)
>  
>  int board_init(void)
>  {
> -	gd->bd->bi_arch_number = MACH_TYPE_MX53_LOCO;
>  	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
>  
>  	return 0;
> diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
> index cfb38a5..4091703 100644
> --- a/include/configs/mx53loco.h
> +++ b/include/configs/mx53loco.h
> @@ -30,6 +30,8 @@
>  #define CONFIG_DISPLAY_CPUINFO
>  #define CONFIG_DISPLAY_BOARDINFO
>  
> +#define CONFIG_MACH_TYPE	MACH_TYPE_MX53_LOCO
> +
>  #include <asm/arch/imx-regs.h>
>  
>  #define CONFIG_CMDLINE_TAG

Applied to u-boot-imx, next branch, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c
index ade1006..156f8b5 100644
--- a/board/freescale/mx53loco/mx53loco.c
+++ b/board/freescale/mx53loco/mx53loco.c
@@ -288,7 +288,6 @@  int board_early_init_f(void)
 
 int board_init(void)
 {
-	gd->bd->bi_arch_number = MACH_TYPE_MX53_LOCO;
 	gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100;
 
 	return 0;
diff --git a/include/configs/mx53loco.h b/include/configs/mx53loco.h
index cfb38a5..4091703 100644
--- a/include/configs/mx53loco.h
+++ b/include/configs/mx53loco.h
@@ -30,6 +30,8 @@ 
 #define CONFIG_DISPLAY_CPUINFO
 #define CONFIG_DISPLAY_BOARDINFO
 
+#define CONFIG_MACH_TYPE	MACH_TYPE_MX53_LOCO
+
 #include <asm/arch/imx-regs.h>
 
 #define CONFIG_CMDLINE_TAG