[1/1] docs/manual/adding-packages-python.txt: fix outdated Python 3 sentence.
diff mbox series

Message ID 20190909115807.5753-1-raphael.melotte@essensium.com
State Accepted
Headers show
Series
  • [1/1] docs/manual/adding-packages-python.txt: fix outdated Python 3 sentence.
Related show

Commit Message

Raphaël Mélotte Sept. 9, 2019, 11:58 a.m. UTC
From: Raphaël Mélotte <raphael.melotte@essensium.com>

Python packages should no longer depend on BR2_PACKAGE_PYTHON
in their config file, unless they are only compatible with Python 2.

Signed-off-by: Raphaël Mélotte <raphael.melotte@essensium.com>
---
 docs/manual/adding-packages-python.txt | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

Comments

Thomas Petazzoni Sept. 10, 2019, 5:29 p.m. UTC | #1
On Mon,  9 Sep 2019 13:58:07 +0200
raphael.melotte@essensium.com wrote:

> From: Raphaël Mélotte <raphael.melotte@essensium.com>
> 
> Python packages should no longer depend on BR2_PACKAGE_PYTHON
> in their config file, unless they are only compatible with Python 2.
> 
> Signed-off-by: Raphaël Mélotte <raphael.melotte@essensium.com>
> ---
>  docs/manual/adding-packages-python.txt | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
Peter Korsgaard Sept. 24, 2019, 2:32 p.m. UTC | #2
>>>>> "raphael" == raphael melotte <raphael.melotte@essensium.com> writes:

 > From: Raphaël Mélotte <raphael.melotte@essensium.com>
 > Python packages should no longer depend on BR2_PACKAGE_PYTHON
 > in their config file, unless they are only compatible with Python 2.

 > Signed-off-by: Raphaël Mélotte <raphael.melotte@essensium.com>

Committed to 2019.02.x, 2019.05.x and 2019.08.x, thanks.

Patch
diff mbox series

diff --git a/docs/manual/adding-packages-python.txt b/docs/manual/adding-packages-python.txt
index 15137cfd6d..74e2e78b29 100644
--- a/docs/manual/adding-packages-python.txt
+++ b/docs/manual/adding-packages-python.txt
@@ -67,9 +67,13 @@  Python build system, but are not Python modules, can freely choose
 their name (existing examples in Buildroot are +scons+ and
 +supervisor+).
 
-In their +Config.in+ file, they should depend on +BR2_PACKAGE_PYTHON+
-so that when Buildroot will enable Python 3 usage for modules, we will
-be able to enable Python modules progressively on Python 3.
+Packages that are only compatible with one version of Python (as in:
+Python 2 or Python 3) should depend on that version explicitely in
+their +Config.in+ file (+BR2_PACKAGE_PYTHON+ for Python 2,
++BR2_PACKAGE_PYTHON3+ for Python 3).  Packages that are compatible
+with both versions should not explicitely depend on them in their
++Config.in+ file, since that condition is already expressed for the
+whole "External python modules" menu.
 
 The main macro of the Python package infrastructure is
 +python-package+. It is similar to the +generic-package+ macro. It is