Patchwork [vms] Use fix include on alpha-vms

login
register
mail settings
Submitter Tristan Gingold
Date Sept. 22, 2011, 1:59 p.m.
Message ID <4464615C-A0BB-4CA6-A2B3-5E5167B7C7C7@adacore.com>
Download mbox | patch
Permalink /patch/115951/
State New
Headers show

Comments

Tristan Gingold - Sept. 22, 2011, 1:59 p.m.
Hi,

currently alpha-vms is listed as a particular target in fixincludes/mkfixinc.sh but ia64-vms isn't.
As I will submit a patch to add some rules for both alpha and ia64 VMS, first fixincludes must be enabled on both.

Committed on trunk.

Tristan.

fixincludes/
2011-09-22  Tristan Gingold  <gingold@adacore.com>

	* mkfixinc.sh (target): Remove alpha-vms from particular targets.
Bruce Korb - Sept. 22, 2011, 2:21 p.m.
Hi Tristan,

On Thu, Sep 22, 2011 at 6:59 AM, Tristan Gingold <gingold@adacore.com> wrote:
> Hi,
>
> currently alpha-vms is listed as a particular target in fixincludes/mkfixinc.sh but ia64-vms isn't.
> As I will submit a patch to add some rules for both alpha and ia64 VMS, first fixincludes must be enabled on both.
>
> Committed on trunk.

Are the current fixes working reasonably for VMS?  If so, then approved.
If not, then maybe defer the activation until it is working better?  Thanks.
Tristan Gingold - Sept. 22, 2011, 2:25 p.m.
On Sep 22, 2011, at 4:21 PM, Bruce Korb wrote:

> Hi Tristan,
> 
> On Thu, Sep 22, 2011 at 6:59 AM, Tristan Gingold <gingold@adacore.com> wrote:
>> Hi,
>> 
>> currently alpha-vms is listed as a particular target in fixincludes/mkfixinc.sh but ia64-vms isn't.
>> As I will submit a patch to add some rules for both alpha and ia64 VMS, first fixincludes must be enabled on both.
>> 
>> Committed on trunk.
> 
> Are the current fixes working reasonably for VMS?

Yes, as they don't generate invalid headers.

>  If so, then approved.
> If not, then maybe defer the activation until it is working better?  Thanks.

I will submit a few rules to improve the fixes on VMS.
But the first purpose of this patch was to fix the inconsistency between alpha and ia64 VMS.

Tristan.

Patch

--- fixincludes/mkfixinc.sh	(revision 179086)
+++ fixincludes/mkfixinc.sh	(working copy)
@@ -11,7 +11,6 @@ 
 
 # Check for special fix rules for particular targets
 case $machine in
-    alpha*-dec-*vms* | \
     i?86-*-cygwin* | \
     i?86-*-mingw32* | \
     x86_64-*-mingw32* | \