[v2,02/12] package/llvm: add the version major variable

Message ID	20190907094027.9537-3-romain.naour@smile.fr
State	Changes Requested
Headers	show Return-Path: <buildroot-bounces@busybox.net> From: Romain Naour <romain.naour@smile.fr> To: buildroot@buildroot.org Date: Sat, 7 Sep 2019 11:40:17 +0200 Message-Id: <20190907094027.9537-3-romain.naour@smile.fr> In-Reply-To: <20190907094027.9537-1-romain.naour@smile.fr> References: <20190907094027.9537-1-romain.naour@smile.fr> MIME-Version: 1.0 Subject: [Buildroot] [PATCH v2 02/12] package/llvm: add the version major variable Precedence: list Cc: Romain Naour <romain.naour@smile.fr>, Valentin Korenblit <valentinkorenblit@gmail.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" <buildroot-bounces@busybox.net>
Series	Add the support for Clang cross-compiler \| expand [v2,00/12] Add the support for Clang cross-compiler [v2,02/12] package/llvm: add the version major variable [v2,03/12] package/clang: add the version major variable [v2,04/12] package/clang: install a toolchain-wrapper for the host clang cross-compiler [v2,05/12] linux: override CC for the case CC is not GCC [v2,06/12] package/meson: use TARGET_{CC, CXX} instead of TARGET_CROSS for cc and cpp [v2,07/12] package/busybox: fix applets runtime issue when building with clang cross-compiler [v2,08/12] package/clang: add a host entry for clang [v2,09/12] package/glibc: use GCC cross-compiler if Clang is used as cross-compiler [v2,10/12] core: allow to use Clang as cross-compiler [v2,11/12] toolchain: add a warning when Clang is used as cross-compiler [v2,12/12] linux: don't set -Wno-attribute-alias flag when Clang is used as cross-compiler

Message ID

20190907094027.9537-3-romain.naour@smile.fr

State

Changes Requested

Headers

From: Romain Naour <romain.naour@smile.fr>
To: buildroot@buildroot.org
Date: Sat,  7 Sep 2019 11:40:17 +0200
Message-Id: <20190907094027.9537-3-romain.naour@smile.fr>
In-Reply-To: <20190907094027.9537-1-romain.naour@smile.fr>
References: <20190907094027.9537-1-romain.naour@smile.fr>
MIME-Version: 1.0
Subject: [Buildroot] [PATCH v2 02/12] package/llvm: add the version major
	variable
Precedence: list
Cc: Romain Naour <romain.naour@smile.fr>,
	Valentin Korenblit <valentinkorenblit@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: buildroot-bounces@busybox.net
Sender: "buildroot" <buildroot-bounces@busybox.net>

Series

Add the support for Clang cross-compiler | expand

Signed-off-by: Romain Naour <romain.naour@smile.fr> Cc: Matt Weber <matthew.weber@rockwellcollins.com> Cc: Valentin Korenblit <valentinkorenblit@gmail.com> --- package/llvm/llvm.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Arnout Vandecappelle Aug. 29, 2020, 7 p.m. UTC | #1

On 07/09/2019 11:40, Romain Naour wrote:
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Cc: Matt Weber <matthew.weber@rockwellcollins.com>
> Cc: Valentin Korenblit <valentinkorenblit@gmail.com>
> ---
>  package/llvm/llvm.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index f14b537d94..e885c63f98 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -5,7 +5,8 @@
>  ################################################################################
>  
>  # LLVM and Clang should be version bumped together
> -LLVM_VERSION = 8.0.1
> +LLVM_VERSION_MAJOR = 8

 I guess this is a leftover from previous iterations, because LLVM_VERSION_MAJOR
is not used anywhere in this series. So this patch can be dropped IMO.

 Regards,
 Arnout

> +LLVM_VERSION = $(LLVM_VERSION_MAJOR).0.1
>  LLVM_SITE = https://github.com/llvm/llvm-project/releases/download/llvmorg-$(LLVM_VERSION)
>  LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
>  LLVM_LICENSE = NCSA
>

diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index f14b537d94..e885c63f98 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -5,7 +5,8 @@ 
 ################################################################################
 
 # LLVM and Clang should be version bumped together
-LLVM_VERSION = 8.0.1
+LLVM_VERSION_MAJOR = 8
+LLVM_VERSION = $(LLVM_VERSION_MAJOR).0.1
 LLVM_SITE = https://github.com/llvm/llvm-project/releases/download/llvmorg-$(LLVM_VERSION)
 LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz
 LLVM_LICENSE = NCSA

[v2,02/12] package/llvm: add the version major variable

Commit Message

Comments

Patch