From patchwork Fri Sep 6 09:47:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1158913 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 46Pt5K57f0z9sNf; Fri, 6 Sep 2019 19:47:33 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1i6Aq2-0002ko-07; Fri, 06 Sep 2019 09:47:29 +0000 Received: from mail-pf1-f196.google.com ([209.85.210.196]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1i6Aq0-0002k5-Br for kernel-team@lists.ubuntu.com; Fri, 06 Sep 2019 09:47:28 +0000 Received: by mail-pf1-f196.google.com with SMTP id b13so4045393pfo.8 for ; Fri, 06 Sep 2019 02:47:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KqoTCwhilZdAs59AUCSPK4hSuE5PgbFD4csuVOhQg+s=; b=cy0lyJkhrbUhEi5CjxLLDpizhAKTOProR5puIHQjxciBNcr0/sVt6U6vSe3eOuBlB2 9A8AoRPWs4ywN2orNFAYWBxWr1YVn0md527gVt8eHY1XDjzeoanqLlalMPBBUxrqv+fb JXMrw02ScRQ7/zSavOaya5KK+ahFJBy/w/QQbFNo+nL/pN0dNX9MhOOKfRWaw+yILHJY 82oW06Pxi0mFoASKUH8gw6UcOn8zeXpgl9D72bZ8wuosJsQN5bBEXeej94WDcxdDK/tl B3699NsHpZOu2W/uO6KgDsDCpnoRvsNRzVciapoCcBCyUS/tWcqfFe/iq8C+9h2c2BxS yH3g== X-Gm-Message-State: APjAAAXzqjKyWjyZ5xKKQFHlRjygSI/oP/Y9kYDhJHzL1jqcTePhFJh0 32cUKa6Ts2jfWY6H9kjCLmN98/K97Yw= X-Google-Smtp-Source: APXvYqx4Q8iPQdiKzbWyAAjxS+rqiIfkgAn/mDx8u6dlWZ2HCufQNgNAYg9ahISdtcWelHEbWROW4g== X-Received: by 2002:a63:fe52:: with SMTP id x18mr7506395pgj.344.1567763246506; Fri, 06 Sep 2019 02:47:26 -0700 (PDT) Received: from localhost.localdomain (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id 4sm6696914pfe.76.2019.09.06.02.47.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 06 Sep 2019 02:47:25 -0700 (PDT) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH V3 1/2][SRU][OEM-OSP1-B] drm/i915/fbc: disable framebuffer compression on GeminiLake Date: Fri, 6 Sep 2019 17:47:19 +0800 Message-Id: <20190906094720.44538-2-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190906094720.44538-1-vicamo.yang@canonical.com> References: <20190906094720.44538-1-vicamo.yang@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Daniel Drake BugLink: https://bugs.launchpad.net/bugs/1840236 On many (all?) the Gemini Lake systems we work with, there is frequent momentary graphical corruption at the top of the screen, and it seems that disabling framebuffer compression can avoid this. The ticket was reported 6 months ago and has already affected a multitude of users, without any real progress being made. So, lets disable framebuffer compression on GeminiLake until a solution is found. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108085 Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") Cc: Paulo Zanoni Cc: Daniel Vetter Cc: Jani Nikula Cc: # v4.11+ Reviewed-by: Paulo Zanoni Signed-off-by: Daniel Drake Signed-off-by: Jian-Hong Pan Signed-off-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20190423092810.28359-1-jian-hong@endlessm.com (cherry picked from commit 1d25724b41fad7eeb2c3058a5c8190d6ece73e08) Signed-off-by: You-Sheng Yang --- drivers/gpu/drm/i915/intel_fbc.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index 8b9c92e80715b..6d3c5057b2413 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++ b/drivers/gpu/drm/i915/intel_fbc.c @@ -1279,6 +1279,10 @@ static int intel_sanitize_fbc_option(struct drm_i915_private *dev_priv) if (!HAS_FBC(dev_priv)) return 0; + /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */ + if (IS_GEMINILAKE(dev_priv)) + return 0; + if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9) return 1;