[1/1] package/luv: install libluv.pc.in
diff mbox series

Message ID 20190905170731.3520-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series
  • [1/1] package/luv: install libluv.pc.in
Related show

Commit Message

Fabrice Fontaine Sept. 5, 2019, 5:07 p.m. UTC
Archive 1.30.1-0 doesn't contain libluv.pc.in which will break the build

Fixes:
 - http://autobuild.buildroot.org/results/5ec6b5a3622c343f7e401b7da7d4a1da15be2733

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/luv/libluv.pc.in | 12 ++++++++++++
 package/luv/luv.mk       |  6 ++++++
 2 files changed, 18 insertions(+)
 create mode 100644 package/luv/libluv.pc.in

Comments

Jörg Krause Sept. 5, 2019, 6:41 p.m. UTC | #1
On Thu, 2019-09-05 at 19:07 +0200, Fabrice Fontaine wrote:
> Archive 1.30.1-0 doesn't contain libluv.pc.in which will break the build
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/5ec6b5a3622c343f7e401b7da7d4a1da15be2733
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/luv/libluv.pc.in | 12 ++++++++++++
>  package/luv/luv.mk       |  6 ++++++
>  2 files changed, 18 insertions(+)
>  create mode 100644 package/luv/libluv.pc.in
> 
> diff --git a/package/luv/libluv.pc.in b/package/luv/libluv.pc.in
> new file mode 100644
> index 0000000000..d1544f6504
> --- /dev/null
> +++ b/package/luv/libluv.pc.in
> @@ -0,0 +1,12 @@
> +prefix=@prefix@
> +exec_prefix=${prefix}
> +libdir=@libdir@
> +includedir=@includedir@
> +
> +Name: libluv
> +Version: @LUV_VERSION@
> +Description: Bare and full libuv bindings for Lua/LuaJIT.
> +URL: https://github.com/luvit/luv
> +
> +Libs: -L${libdir} -lluv @LIBS@
> +Cflags: -I${includedir}
> diff --git a/package/luv/luv.mk b/package/luv/luv.mk
> index 31288ffca3..c6a8eab158 100644
> --- a/package/luv/luv.mk
> +++ b/package/luv/luv.mk
> @@ -11,6 +11,12 @@ LUV_LICENSE_FILES = LICENSE.txt
>  LUV_DEPENDENCIES = libuv
>  LUV_INSTALL_STAGING = YES
>  
> +# Archive 1.30.1-0 doesn't contain libluv.pc.in so install it in this hook
> +define LUV_INSTALL_PC_IN
> +	cp package/luv/libluv.pc.in $(@D)/
> +endef
> +LUV_POST_EXTRACT_HOOKS += LUV_INSTALL_PC_IN
> +
>  LUV_CONF_OPTS += \
>  	-DBUILD_MODULE=OFF \
>  	-DWITH_SHARED_LIBUV=ON \

Acked-by: Jörg Krause <joerg.krause@embedded.rocks>
Thomas Petazzoni Sept. 15, 2019, 8:21 p.m. UTC | #2
On Thu,  5 Sep 2019 19:07:31 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Archive 1.30.1-0 doesn't contain libluv.pc.in which will break the build
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/5ec6b5a3622c343f7e401b7da7d4a1da15be2733
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/luv/libluv.pc.in | 12 ++++++++++++
>  package/luv/luv.mk       |  6 ++++++
>  2 files changed, 18 insertions(+)
>  create mode 100644 package/luv/libluv.pc.in

Applied to master, thanks. I've extended the commit log to mention that
the issue has been fixed upstream in
https://github.com/luvit/luv/commit/946784fba047bcd275554b5040949e3d70994b30.
So we need to remember to drop the hack/workaround when luv will be
bumped next time.

Thanks!

Thomas

Patch
diff mbox series

diff --git a/package/luv/libluv.pc.in b/package/luv/libluv.pc.in
new file mode 100644
index 0000000000..d1544f6504
--- /dev/null
+++ b/package/luv/libluv.pc.in
@@ -0,0 +1,12 @@ 
+prefix=@prefix@
+exec_prefix=${prefix}
+libdir=@libdir@
+includedir=@includedir@
+
+Name: libluv
+Version: @LUV_VERSION@
+Description: Bare and full libuv bindings for Lua/LuaJIT.
+URL: https://github.com/luvit/luv
+
+Libs: -L${libdir} -lluv @LIBS@
+Cflags: -I${includedir}
diff --git a/package/luv/luv.mk b/package/luv/luv.mk
index 31288ffca3..c6a8eab158 100644
--- a/package/luv/luv.mk
+++ b/package/luv/luv.mk
@@ -11,6 +11,12 @@  LUV_LICENSE_FILES = LICENSE.txt
 LUV_DEPENDENCIES = libuv
 LUV_INSTALL_STAGING = YES
 
+# Archive 1.30.1-0 doesn't contain libluv.pc.in so install it in this hook
+define LUV_INSTALL_PC_IN
+	cp package/luv/libluv.pc.in $(@D)/
+endef
+LUV_POST_EXTRACT_HOOKS += LUV_INSTALL_PC_IN
+
 LUV_CONF_OPTS += \
 	-DBUILD_MODULE=OFF \
 	-DWITH_SHARED_LIBUV=ON \